From: Xu Yu <xuyu@linux.alibaba.com>
To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Cc: arnd@arndb.de, gregkh@linuxfoundation.org,
viro@zeniv.linux.org.uk, dhowells@redhat.com
Subject: [PATCH] chardev: call tty_init() in real chrdev_init()
Date: Mon, 7 Feb 2022 00:27:31 +0800 [thread overview]
Message-ID: <4e753e51d0516413fbf557cf861d654ca73486cc.1644164597.git.xuyu@linux.alibaba.com> (raw)
It is confusing that tty_init() in called in the initialization of
memdev, i.e., static chr_dev_init().
Through blame, it is introduced by commit 31d1d48e199e ("Fix init
ordering of /dev/console vs callers of modprobe"), which fixes the
initialization order of /dev/console driver. However, there seems
to be a typo in the patch, i.e., chrdev_init, instead of chr_dev_init.
This fixes the typo, IIUC.
Note that the return value of tty_init() is always 0, and thus no error
handling is provided in chrdev_init().
Fixes: 31d1d48e199e ("Fix init ordering of /dev/console vs callers of modprobe")
Signed-off-by: Xu Yu <xuyu@linux.alibaba.com>
---
drivers/char/mem.c | 2 +-
fs/char_dev.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/char/mem.c b/drivers/char/mem.c
index cc296f0823bd..8c90881f8115 100644
--- a/drivers/char/mem.c
+++ b/drivers/char/mem.c
@@ -775,7 +775,7 @@ static int __init chr_dev_init(void)
NULL, devlist[minor].name);
}
- return tty_init();
+ return 0;
}
fs_initcall(chr_dev_init);
diff --git a/fs/char_dev.c b/fs/char_dev.c
index ba0ded7842a7..fc042a0a098f 100644
--- a/fs/char_dev.c
+++ b/fs/char_dev.c
@@ -667,6 +667,7 @@ static struct kobject *base_probe(dev_t dev, int *part, void *data)
void __init chrdev_init(void)
{
cdev_map = kobj_map_init(base_probe, &chrdevs_lock);
+ tty_init();
}
--
2.20.1.2432.ga663e714
next reply other threads:[~2022-02-06 16:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-06 16:27 Xu Yu [this message]
2022-02-06 17:03 ` Greg KH
2022-02-07 6:37 ` Yu Xu
2022-02-07 7:14 ` Greg KH
2022-02-08 7:02 ` [chardev] c194b1c9f0: BUG:kernel_NULL_pointer_dereference,address kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e753e51d0516413fbf557cf861d654ca73486cc.1644164597.git.xuyu@linux.alibaba.com \
--to=xuyu@linux.alibaba.com \
--cc=arnd@arndb.de \
--cc=dhowells@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®