mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shivang Upadhyay <shivangu@linux.ibm.com>
To: Sourabh Jain <sourabhjain@linux.ibm.com>,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Cc: maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com,
	chleroy@kernel.org, adri.vero.dev@gmail.com,
	adityag@linux.ibm.com, anushree.mathur@linux.vnet.ibm.com
Subject: Re: [PATCH] ppc/fadump: collect dump if the collected size is lesser than reserved
Date: Wed, 29 Jul 2026 12:30:45 +0530	[thread overview]
Message-ID: <4e7bd9342efa0cbdd162445a994f73c9ad473645.camel@linux.ibm.com> (raw)
In-Reply-To: <7eb8ed5f-0652-4675-9369-913a17463093@linux.ibm.com>

On Wed, 2026-07-29 at 11:58 +0530, Sourabh Jain wrote:
> > > 
> > Yes, I made it this way by reading the dump_bytes and source_len
> > relation. PAPR only says that dumped_bytes should not exceed the
> > source_len. My change reflects the same restriction in sw. Also
> > along
> > with this lengths check, we have firmware reported error flag also,
> > which should take care of overflow (Qemu handles it like this [1]).
> 
> But the firmware not copying the entire Real Mode memory is also a 
> problem for
> the kernel, isn't it?
> 

I think it should be fine. Firmware will report it status flags, right?
There are these valid flag values. 

Dump Error Flags (set by platform)
 Bit mask
 0x8000 = Invalid section data type
 0x4000 = Invalid source address
 0x2000 = Requested section length exceeds source
 0x1000 = Invalid partition destination address
 0x0800 = Partition memory destination too small

I think these should cover all our error cases.

~Shivang.

  reply	other threads:[~2026-07-29  7:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-14 17:30 Shivang Upadhyay
2026-07-19  7:09 ` Sourabh Jain
2026-07-22  9:11   ` Shivang Upadhyay
2026-07-29  3:44     ` Sourabh Jain
2026-07-29  6:06       ` Shivang Upadhyay
2026-07-29  6:28         ` Sourabh Jain
2026-07-29  7:00           ` Shivang Upadhyay [this message]
2026-07-29  8:13             ` Sourabh Jain
2026-07-29  8:29               ` Shivang Upadhyay
2026-07-29 10:01                 ` Sourabh Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4e7bd9342efa0cbdd162445a994f73c9ad473645.camel@linux.ibm.com \
    --to=shivangu@linux.ibm.com \
    --cc=adityag@linux.ibm.com \
    --cc=adri.vero.dev@gmail.com \
    --cc=anushree.mathur@linux.vnet.ibm.com \
    --cc=chleroy@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=sourabhjain@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome