From: "Bean Huo (beanhuo)" <beanhuo@micron.com>
To: "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"shawn.lin@rock-chips.com" <shawn.lin@rock-chips.com>,
"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
"axboe@fb.com" <axboe@fb.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Bean Huo (beanhuo)" <beanhuo@micron.com>,
"Zoltan Szubbocsev (zszubbocsev)" <zszubbocsev@micron.com>
Subject: [PATCH V1] mmc: core: fix still flush cache when eMMC cache off
Date: Sun, 19 Mar 2017 00:45:40 +0000 [thread overview]
Message-ID: <4e7d0b4b8df1430698e822b1a36bcc11@SIWEX5A.sing.micron.com> (raw)
This patch fixes the issue that mmc_blk_issue_rq still
flushes cache when eMMC cache has already been off
through user space tool, such as mmc-utils.
The reason is that card->ext_csd.cache_ctrl isn't reset.
Signed-off-by: beanhuo <beanhuo@micron.com>
---
drivers/mmc/core/block.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c
index 1621fa0..fb3635ac 100644
--- a/drivers/mmc/core/block.c
+++ b/drivers/mmc/core/block.c
@@ -64,6 +64,7 @@ MODULE_ALIAS("mmc:block");
#define MMC_BLK_TIMEOUT_MS (10 * 60 * 1000) /* 10 minute timeout */
#define MMC_SANITIZE_REQ_TIMEOUT 240000
#define MMC_EXTRACT_INDEX_FROM_ARG(x) ((x & 0x00FF0000) >> 16)
+#define MMC_EXTRACT_VALUE_FROM_ARG(x) ((x & 0x0000FF00) >> 8)
#define mmc_req_rel_wr(req) ((req->cmd_flags & REQ_FUA) && \
(rq_data_dir(req) == WRITE))
@@ -535,6 +536,14 @@ static int __mmc_blk_ioctl_cmd(struct mmc_card *card, struct mmc_blk_data *md,
return data.error;
}
+ if ((MMC_EXTRACT_INDEX_FROM_ARG(cmd.arg) == EXT_CSD_CACHE_CTRL) &&
+ (cmd.opcode == MMC_SWITCH) && (card->ext_csd.cache_size > 0)) {
+ if (MMC_EXTRACT_VALUE_FROM_ARG(cmd.arg) & 1)
+ card->ext_csd.cache_ctrl = 1;
+ else
+ card->ext_csd.cache_ctrl = 0;
+ }
+
/*
* According to the SD specs, some commands require a delay after
* issuing the command.
--
2.7.4
next reply other threads:[~2017-03-19 1:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-19 0:45 Bean Huo (beanhuo) [this message]
2017-03-20 7:33 ` Shawn Lin
[not found] ` <CGME20170320113503epcas1p1115fcb2a974a38a4133230b5b9013fbb@epcas1p1.samsung.com>
2017-03-20 11:35 ` Bartlomiej Zolnierkiewicz
2017-03-22 17:31 ` Bean Huo (beanhuo)
2017-03-23 10:03 ` Ulf Hansson
2017-03-23 10:45 ` Bean Huo (beanhuo)
2017-03-23 13:10 ` Ulf Hansson
2017-03-24 11:16 ` Bean Huo (beanhuo)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e7d0b4b8df1430698e822b1a36bcc11@SIWEX5A.sing.micron.com \
--to=beanhuo@micron.com \
--cc=adrian.hunter@intel.com \
--cc=axboe@fb.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=ulf.hansson@linaro.org \
--cc=zszubbocsev@micron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®