From: "Jiaxun Yang" <jiaxun.yang@flygoat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>
Cc: linux-kernel@vger.kernel.org,
"Huacai Chen" <chenhuacai@kernel.org>,
"kernel test robot" <lkp@intel.com>
Subject: Re: [PATCH] MIPS: Loongson64: Fix more __iomem attributes
Date: Sat, 22 Jul 2023 12:46:18 +0800 [thread overview]
Message-ID: <4e7e7e55-ba5a-4e48-a5f4-1bab69cc87fb@app.fastmail.com> (raw)
In-Reply-To: <ef4b3c72-1676-fc73-9eb6-5ea6539d8876@linaro.org>
在2023年7月19日七月 下午7:39，Philippe Mathieu-Daudé写道：
> On 18/7/23 15:44, Jiaxun Yang wrote:
>> There are some __iomem type casting being missed in previous patch.
>> Fix them here.
>>
>> Fixes: 5bd3990723bd ("MIPS: Loongson64: Prefix ipi register address pointers with __iomem")
>> Reported-by: kernel test robot <lkp@intel.com>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202307020639.QCZOKp8B-lkp@intel.com/
>> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
>> ---
>> arch/mips/loongson64/smp.c | 168 ++++++++++++++++++-------------------
>> 1 file changed, 84 insertions(+), 84 deletions(-)
>
>
>> static void ipi_mailbox_buf_init(void)
>> {
>> - ipi_mailbox_buf[0] = (void *)
>> + ipi_mailbox_buf[0] = (void __iomem *)
>> (SMP_CORE_GROUP0_BASE + SMP_CORE0_OFFSET + BUF);
>> - ipi_mailbox_buf[1] = (void *)
>> + ipi_mailbox_buf[1] = (void __iomem *)
>> (SMP_CORE_GROUP0_BASE + SMP_CORE1_OFFSET + BUF);
>> - ipi_mailbox_buf[2] = (void *)
>> + ipi_mailbox_buf[2] = (void __iomem *)
>> (SMP_CORE_GROUP0_BASE + SMP_CORE2_OFFSET + BUF);
>> - ipi_mailbox_buf[3] = (void *)
>> + ipi_mailbox_buf[3] = (void __iomem *)
>> (SMP_CORE_GROUP0_BASE + SMP_CORE3_OFFSET + BUF);
>> - ipi_mailbox_buf[4] = (void *)
>> + ipi_mailbox_buf[4] = (void __iomem *)
>> (SMP_CORE_GROUP1_BASE + SMP_CORE0_OFFSET + BUF);
>> - ipi_mailbox_buf[5] = (void *)
>> + ipi_mailbox_buf[5] = (void __iomem *)
>> (SMP_CORE_GROUP1_BASE + SMP_CORE1_OFFSET + BUF);
>> - ipi_mailbox_buf[6] = (void *)
>> + ipi_mailbox_buf[6] = (void __iomem *)
>> (SMP_CORE_GROUP1_BASE + SMP_CORE2_OFFSET + BUF);
>> - ipi_mailbox_buf[7] = (void *)
>> + ipi_mailbox_buf[7] = (void __iomem *)
>> (SMP_CORE_GROUP1_BASE + SMP_CORE3_OFFSET + BUF);
>> - ipi_mailbox_buf[8] = (void *)
>> + ipi_mailbox_buf[8] = (void __iomem *)
>> (SMP_CORE_GROUP2_BASE + SMP_CORE0_OFFSET + BUF);
>> - ipi_mailbox_buf[9] = (void *)
>> + ipi_mailbox_buf[9] = (void __iomem *)
>> (SMP_CORE_GROUP2_BASE + SMP_CORE1_OFFSET + BUF);
>> - ipi_mailbox_buf[10] = (void *)
>> + ipi_mailbox_buf[10] = (void __iomem *)
>> (SMP_CORE_GROUP2_BASE + SMP_CORE2_OFFSET + BUF);
>> - ipi_mailbox_buf[11] = (void *)
>> + ipi_mailbox_buf[11] = (void __iomem *)
>> (SMP_CORE_GROUP2_BASE + SMP_CORE3_OFFSET + BUF);
>> - ipi_mailbox_buf[12] = (void *)
>> + ipi_mailbox_buf[12] = (void __iomem *)
>> (SMP_CORE_GROUP3_BASE + SMP_CORE0_OFFSET + BUF);
>> - ipi_mailbox_buf[13] = (void *)
>> + ipi_mailbox_buf[13] = (void __iomem *)
>> (SMP_CORE_GROUP3_BASE + SMP_CORE1_OFFSET + BUF);
>> - ipi_mailbox_buf[14] = (void *)
>> + ipi_mailbox_buf[14] = (void __iomem *)
>> (SMP_CORE_GROUP3_BASE + SMP_CORE2_OFFSET + BUF);
>> - ipi_mailbox_buf[15] = (void *)
>> + ipi_mailbox_buf[15] = (void __iomem *)
>> (SMP_CORE_GROUP3_BASE + SMP_CORE3_OFFSET + BUF);
>> }
>
> OK up to here,
>
>> @@ -782,7 +782,7 @@ void play_dead(void)
>>
>> if (prid_imp == PRID_IMP_LOONGSON_64G) {
>> play_dead_at_ckseg1 =
>> - (void *)CKSEG1ADDR((unsigned long)loongson3_type3_play_dead);
>> + (void __iomem *)CKSEG1ADDR((unsigned long)loongson3_type3_play_dead);
>
> but these changes look dubious.
Oops, will fix later.
Thanks
>
>> goto out;
>> }
>>
>> @@ -790,19 +790,19 @@ void play_dead(void)
>> case PRID_REV_LOONGSON3A_R1:
>> default:
>> play_dead_at_ckseg1 =
>> - (void *)CKSEG1ADDR((unsigned long)loongson3_type1_play_dead);
>> + (void __iomem *)CKSEG1ADDR((unsigned long)loongson3_type1_play_dead);
>> break;
>> case PRID_REV_LOONGSON3B_R1:
>> case PRID_REV_LOONGSON3B_R2:
>> play_dead_at_ckseg1 =
>> - (void *)CKSEG1ADDR((unsigned long)loongson3_type2_play_dead);
>> + (void __iomem *)CKSEG1ADDR((unsigned long)loongson3_type2_play_dead);
>> break;
>> case PRID_REV_LOONGSON3A_R2_0:
>> case PRID_REV_LOONGSON3A_R2_1:
>> case PRID_REV_LOONGSON3A_R3_0:
>> case PRID_REV_LOONGSON3A_R3_1:
>> play_dead_at_ckseg1 =
>> - (void *)CKSEG1ADDR((unsigned long)loongson3_type3_play_dead);
>> + (void __iomem *)CKSEG1ADDR((unsigned long)loongson3_type3_play_dead);
>> break;
>> }
>>
--
- Jiaxun
prev parent reply other threads:[~2023-07-22 4:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 13:44 Jiaxun Yang
2023-07-19 11:39 ` Philippe Mathieu-Daudé
2023-07-22 4:46 ` Jiaxun Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e7e7e55-ba5a-4e48-a5f4-1bab69cc87fb@app.fastmail.com \
--to=jiaxun.yang@flygoat.com \
--cc=chenhuacai@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=lkp@intel.com \
--cc=philmd@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®