From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2B3C198822 for ; Wed, 18 Dec 2024 10:22:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734517376; cv=none; b=iAFyo6tam8T2V2Rfto1q0BKFuy6o03sdAoQRH/1gOC3z6yUsQ20feb8ukBBwNVWsQJgJoqeetB1L9Nbqn8kxOTMJBTChs5y59Rd1Dg2jGKhJzikkIQk3Mx7ZEuGlC9AiNzXZhdnFc1KgD4nlS0TCZCMJSKMPTPpeo9Q5d2Oz17w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734517376; c=relaxed/simple; bh=pVgaDgXOVIUNxuWBHzHjMy1JhyGRca/aDruYf8oxSvE=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=EYa1iaXR+TEC+Cx5/ccbGVuIxlM3n10eK6Rbx9r066qIyrNTd/5ggoEqAE46VsZga0DIZZ4HVBuJoroQjLShEHTEofyR9B0001n77k3pFgr4vFSvLk767kBcgVkg7XeR+M9Tl2n94DSAHTa2A6gMlh+QPiGQ//fLrqYtZ+VulEs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=s02bxsO3; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="s02bxsO3" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-436202dd730so45083675e9.2 for ; Wed, 18 Dec 2024 02:22:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1734517373; x=1735122173; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=RZGs7Y66+td6OqVHaSIclRCB7zumQQqsxzXpa2zyvVQ=; b=s02bxsO3YRJtFXOtYJTEcpsqM8jJFT3mAyeZN814SqOiKx9W8umutz0/m4Dt+Q2X9y zcxFQRPuasIO1dRfG2QlqgeyeMPLJY+2rKrUqzZ3HLHPRX8JOlHERb8kv0ZbevR2C3JA lbmaBWa5mjpJq5LwvX6DF48lnoTtcGJWhLGN9wilP8K2qat2ELCn0P41FWNy4X2/YQ98 q7kaTcfi7QvDTeQhbzkOeXbp+G7D54S9/5KUG3rC+sbey+xpE0lAzTCVSBuhOLzq+gI7 GFZrXDyaFj4TCeW2k2wUwKvmakl2VelCblakJkcambFDjCfuP6FKeQsPa0SX6dmZYgGU aDdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734517373; x=1735122173; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=RZGs7Y66+td6OqVHaSIclRCB7zumQQqsxzXpa2zyvVQ=; b=kMr9f2nfbMY3N18HhmUJ10gyDPlcIqylN+QkCk2Rncd4vT8VVbB9q/uNq35BVlFTJa TBLxPMjMmtYWTafE2NowDs5Sn6JITRHxUzA98SZX7owpeLMWjsX250eiCjXIk1NxpzKg HrPury+4fA9RLL2x45QJ8YAq1EgbHAbX3urXwKSzT/O3Ok3D/VD20mZg3jWX2VLAjqol nAjfPYu1v8PZOQK8bpbrgoL26AMur/8JndL3jbOJBLR+QlqBua5UCu06g+I0XojfHW2G YuZ55yHVK1QZjPLjntRwusFDPHsJ4unx/Q80b90ezSUMmDW+OF72TuJvwazeA6JiG0a/ pnhw== X-Gm-Message-State: AOJu0YyroHqCFs5U1l+X/GANwz4WESkVeFNoQWDrodXJMKrl2bjf2b62 GwnsD4E4Tz1B7P1SL5NGVeB2rcOqjpCMcoDrIgcXiixksaCtegTNXUJXIIUTYiw= X-Gm-Gg: ASbGncuhYv9Rw6fP7taxZ07rQnwdMtt3qvOg/sq+Uxr44PoCt+Agf3qK5SGCd34iOEc 1hXgIVxsRo9Aypo+yfn75qajytOnHxpL89Bv37RxcXpM3XdK6ALlLzIdB+WvWd4Pbdi/7NQNHoP J+grQk0kvZyYbDDu1IRRSddjFJ3JLtmM7BdJmo6Ecp79T+tJh/ZQFizjjxRD4k0n4GY5G7ZMWOE ZO12sS/g62U2v7d9NUtmWOaViT+2HtsE7Hojp57gxYZ6/r7JwUbZ0311+rdVxSuW5jwRQN/8HDS BcCiI/JfrrNIEzG6lJnWRAvOwl46iKM= X-Google-Smtp-Source: AGHT+IFgP/8IN1QuIOTy/xgV92NDu3DdLi4jkcpMDZGLpnVCK4EHeQqLf+BtnvjiFM8k8omeri7SUQ== X-Received: by 2002:a05:600c:468e:b0:431:3bf9:3ebb with SMTP id 5b1f17b1804b1-436553f4d28mr17417405e9.24.1734517372986; Wed, 18 Dec 2024 02:22:52 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:e596:468d:657e:c30? ([2a01:e0a:982:cbb0:e596:468d:657e:c30]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43656afd57esm15715435e9.5.2024.12.18.02.22.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Dec 2024 02:22:52 -0800 (PST) Message-ID: <4e7f0951-4b83-4d5c-b4e6-8d7327614840@linaro.org> Date: Wed, 18 Dec 2024 11:22:51 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 2/2] drm/i2c: move TDA drivers under drivers/gpu/drm/bridge To: Dmitry Baryshkov , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Liviu Dudau , Andrzej Hajda , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Russell King Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20241215-drm-move-tda998x-v1-0-7817122b1d73@linaro.org> <20241215-drm-move-tda998x-v1-2-7817122b1d73@linaro.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20241215-drm-move-tda998x-v1-2-7817122b1d73@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 15/12/2024 12:09, Dmitry Baryshkov wrote: > TDA998x is the HDMI bridge driver, incorporating drm_connector and > optional drm_encoder (created via the component bind API by the TICLDC > and HDLCD drivers). Thus it should be residing together with the other > DRM bridge drivers under drivers/gpu/drm/bridge/. > > TDA9950 is an I2C-CEC translator, being present on-die on the TDA9989 > and TDA19989 chips, so it is being instantiated by the TDA998x driver. > Move it together with the TDA998x under bridge drivers subdir. > > Signed-off-by: Dmitry Baryshkov > --- > MAINTAINERS | 2 +- > drivers/gpu/drm/arm/Kconfig | 1 + > drivers/gpu/drm/bridge/Kconfig | 2 ++ > drivers/gpu/drm/bridge/Makefile | 1 + > drivers/gpu/drm/bridge/tda/Kconfig | 13 +++++++++++++ > drivers/gpu/drm/bridge/tda/Makefile | 4 ++++ > drivers/gpu/drm/{i2c => bridge/tda}/tda9950.c | 0 > drivers/gpu/drm/{i2c => bridge/tda}/tda998x_drv.c | 0 > drivers/gpu/drm/i2c/Kconfig | 13 ------------- > drivers/gpu/drm/i2c/Makefile | 4 ---- > 10 files changed, 22 insertions(+), 18 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 9a23e80abf309cbd918a74683895f8dbe0507a6e..a4c7afd564e721e14aebaf828b75776e50760a45 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -16982,7 +16982,7 @@ M: Russell King > S: Maintained > T: git git://git.armlinux.org.uk/~rmk/linux-arm.git drm-tda998x-devel > T: git git://git.armlinux.org.uk/~rmk/linux-arm.git drm-tda998x-fixes > -F: drivers/gpu/drm/i2c/tda998x_drv.c > +F: drivers/gpu/drm/bridge/tda/tda998x_drv.c I'd rather move the entry it to drm-misc in the same move, I don't think we want externally maintained bridge drivers mixed in the other bridges. Russell, so you agree ? Apart that: Acked-by: Neil Armstrong Neil > F: include/dt-bindings/display/tda998x.h > K: "nxp,tda998x" > > diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig > index c901ac00c0c3a8f356bd53d97305c6b39b3e6662..ed3ed617c6884876368c8bd072c53f1b710df443 100644 > --- a/drivers/gpu/drm/arm/Kconfig > +++ b/drivers/gpu/drm/arm/Kconfig > @@ -9,6 +9,7 @@ config DRM_HDLCD > select DRM_CLIENT_SELECTION > select DRM_KMS_HELPER > select DRM_GEM_DMA_HELPER > + select DRM_BRIDGE # for TDA998x > help > Choose this option if you have an ARM High Definition Colour LCD > controller. > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig > index 6b4664d91faa80f096ac6a0548ed342e802ae68b..1ef16dcc2ae53eb172604de2d6899004c080a979 100644 > --- a/drivers/gpu/drm/bridge/Kconfig > +++ b/drivers/gpu/drm/bridge/Kconfig > @@ -438,4 +438,6 @@ source "drivers/gpu/drm/bridge/imx/Kconfig" > > source "drivers/gpu/drm/bridge/synopsys/Kconfig" > > +source "drivers/gpu/drm/bridge/tda/Kconfig" > + > endmenu > diff --git a/drivers/gpu/drm/bridge/Makefile b/drivers/gpu/drm/bridge/Makefile > index 97304b429a530c108dcbff906965cda091b0a7a2..52e6c9b3094bba0fd6aaf28af1b58f4bd8bf26d0 100644 > --- a/drivers/gpu/drm/bridge/Makefile > +++ b/drivers/gpu/drm/bridge/Makefile > @@ -43,3 +43,4 @@ obj-y += analogix/ > obj-y += cadence/ > obj-y += imx/ > obj-y += synopsys/ > +obj-y += tda/ > diff --git a/drivers/gpu/drm/bridge/tda/Kconfig b/drivers/gpu/drm/bridge/tda/Kconfig > new file mode 100644 > index 0000000000000000000000000000000000000000..5f13e4ffc24eeaa8dd0015c7e84d0dbac93e170c > --- /dev/null > +++ b/drivers/gpu/drm/bridge/tda/Kconfig > @@ -0,0 +1,13 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +config DRM_I2C_NXP_TDA998X > + tristate "NXP Semiconductors TDA998X HDMI encoder" > + default m if DRM_TILCDC > + select CEC_CORE if CEC_NOTIFIER > + select SND_SOC_HDMI_CODEC if SND_SOC > + help > + Support for NXP Semiconductors TDA998X HDMI encoders. > + > +config DRM_I2C_NXP_TDA9950 > + tristate "NXP Semiconductors TDA9950/TDA998X HDMI CEC" > + select CEC_NOTIFIER > + select CEC_CORE > diff --git a/drivers/gpu/drm/bridge/tda/Makefile b/drivers/gpu/drm/bridge/tda/Makefile > new file mode 100644 > index 0000000000000000000000000000000000000000..31fd35527d99d7eb23851d290175a3ff0c756772 > --- /dev/null > +++ b/drivers/gpu/drm/bridge/tda/Makefile > @@ -0,0 +1,4 @@ > +# SPDX-License-Identifier: GPL-2.0 > +tda998x-y := tda998x_drv.o > +obj-$(CONFIG_DRM_I2C_NXP_TDA998X) += tda998x.o > +obj-$(CONFIG_DRM_I2C_NXP_TDA9950) += tda9950.o > diff --git a/drivers/gpu/drm/i2c/tda9950.c b/drivers/gpu/drm/bridge/tda/tda9950.c > similarity index 100% > rename from drivers/gpu/drm/i2c/tda9950.c > rename to drivers/gpu/drm/bridge/tda/tda9950.c > diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/bridge/tda/tda998x_drv.c > similarity index 100% > rename from drivers/gpu/drm/i2c/tda998x_drv.c > rename to drivers/gpu/drm/bridge/tda/tda998x_drv.c > diff --git a/drivers/gpu/drm/i2c/Kconfig b/drivers/gpu/drm/i2c/Kconfig > index 6f19e1c35e30b0e595c1a60628a6b8cf313fcabc..3205cdb827b95209a4bba9fb126ad2df27ddbdfb 100644 > --- a/drivers/gpu/drm/i2c/Kconfig > +++ b/drivers/gpu/drm/i2c/Kconfig > @@ -20,17 +20,4 @@ config DRM_I2C_SIL164 > when used in pairs) TMDS transmitters, used in some nVidia > video cards. > > -config DRM_I2C_NXP_TDA998X > - tristate "NXP Semiconductors TDA998X HDMI encoder" > - default m if DRM_TILCDC > - select CEC_CORE if CEC_NOTIFIER > - select SND_SOC_HDMI_CODEC if SND_SOC > - help > - Support for NXP Semiconductors TDA998X HDMI encoders. > - > -config DRM_I2C_NXP_TDA9950 > - tristate "NXP Semiconductors TDA9950/TDA998X HDMI CEC" > - select CEC_NOTIFIER > - select CEC_CORE > - > endmenu > diff --git a/drivers/gpu/drm/i2c/Makefile b/drivers/gpu/drm/i2c/Makefile > index a962f6f085686674ed33010345730db776815ebe..1df3869491e277ca210368c4e48efe6d11af62b6 100644 > --- a/drivers/gpu/drm/i2c/Makefile > +++ b/drivers/gpu/drm/i2c/Makefile > @@ -4,7 +4,3 @@ obj-$(CONFIG_DRM_I2C_CH7006) += ch7006.o > > sil164-y := sil164_drv.o > obj-$(CONFIG_DRM_I2C_SIL164) += sil164.o > - > -tda998x-y := tda998x_drv.o > -obj-$(CONFIG_DRM_I2C_NXP_TDA998X) += tda998x.o > -obj-$(CONFIG_DRM_I2C_NXP_TDA9950) += tda9950.o >