From: "Paul E. McKenney" <paulmck@kernel.org>
To: Frederic Weisbecker <frederic@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Boqun Feng <boqun.feng@gmail.com>,
Joel Fernandes <joel@joelfernandes.org>,
Neeraj Upadhyay <neeraj.upadhyay@amd.com>,
Uladzislau Rezki <urezki@gmail.com>,
Zqiang <qiang.zhang1211@gmail.com>, rcu <rcu@vger.kernel.org>
Subject: Re: [PATCH 3/3] rcu: Report callbacks enqueued on offline CPU blind spot
Date: Tue, 8 Oct 2024 19:03:50 -0700 [thread overview]
Message-ID: <4e81816e-3a4d-4642-a86c-fd9bd49ca163@paulmck-laptop> (raw)
In-Reply-To: <Zv1f8-1tLd-r1cyu@localhost.localdomain>
On Wed, Oct 02, 2024 at 05:00:03PM +0200, Frederic Weisbecker wrote:
> Le Wed, Oct 02, 2024 at 04:57:38PM +0200, Frederic Weisbecker a écrit :
> > Callbacks enqueued after rcutree_report_cpu_dead() fall into RCU barrier
> > blind spot. Report any potential misuse.
> >
> > Reported-by: Paul E. McKenney <paulmck@kernel.org>
> > Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
> > ---
> > kernel/rcu/tree.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> > index a60616e69b66..36070b6bf4a1 100644
> > --- a/kernel/rcu/tree.c
> > +++ b/kernel/rcu/tree.c
> > @@ -3084,8 +3084,11 @@ __call_rcu_common(struct rcu_head *head, rcu_callback_t func, bool lazy_in)
> > head->func = func;
> > head->next = NULL;
> > kasan_record_aux_stack_noalloc(head);
> > +
> > local_irq_save(flags);
> > rdp = this_cpu_ptr(&rcu_data);
> > + RCU_LOCKDEP_WARN(rcu_rdp_cpu_online(rdp), "Callback enqueued on offline
> > CPU!");
>
> This should be !rcu_rdp_cpu_online(rdp)
>
> Sigh...
I am pulling this in for testing with this change, thank you!
Thanx, Paul
> > +
> > lazy = lazy_in && !rcu_async_should_hurry();
> >
> > /* Add the callback to our list. */
> > --
> > 2.46.0
> >
> >
next prev parent reply other threads:[~2024-10-09 2:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 14:57 [PATCH 0/3] rcu: Fix yet another wake up from offline related issue Frederic Weisbecker
2024-10-02 14:57 ` [PATCH 1/3] rcu/nocb: Use switch/case on NOCB timer state machine Frederic Weisbecker
2024-10-10 8:16 ` Boqun Feng
2024-10-10 12:55 ` Frederic Weisbecker
2024-10-02 14:57 ` [PATCH 2/3] rcu/nocb: Fix rcuog wake-up from offline softirq Frederic Weisbecker
2024-10-09 18:23 ` Joel Fernandes
2024-10-09 20:56 ` Frederic Weisbecker
2024-10-10 0:27 ` Joel Fernandes
2024-10-02 14:57 ` [PATCH 3/3] rcu: Report callbacks enqueued on offline CPU blind spot Frederic Weisbecker
2024-10-02 15:00 ` Frederic Weisbecker
2024-10-09 2:03 ` Paul E. McKenney [this message]
2024-10-09 15:13 ` Paul E. McKenney
2024-10-10 14:30 ` Joel Fernandes
2024-10-09 2:24 ` Neeraj Upadhyay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e81816e-3a4d-4642-a86c-fd9bd49ca163@paulmck-laptop \
--to=paulmck@kernel.org \
--cc=boqun.feng@gmail.com \
--cc=frederic@kernel.org \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neeraj.upadhyay@amd.com \
--cc=qiang.zhang1211@gmail.com \
--cc=rcu@vger.kernel.org \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®