From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751674AbdJWQfr (ORCPT <rfc822;w@1wt.eu>);
        Mon, 23 Oct 2017 12:35:47 -0400
Received: from mga07.intel.com ([134.134.136.100]:7129 "EHLO mga07.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751288AbdJWQfq (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 23 Oct 2017 12:35:46 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.43,423,1503385200"; 
   d="scan'208";a="912814353"
Subject: Re: [PATCH] drm/i915/gvt: Clean up dead code in cmd_parser
To: Christos Gkekas <chris.gekas@gmail.com>, fred gao <fred.gao@intel.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>, David Airlie <airlied@linux.ie>,
        intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <1508106723-17935-1-git-send-email-chris.gekas@gmail.com>
From: Zhi Wang <zhi.a.wang@intel.com>
Message-ID: <4e82b159-0031-6781-f21b-b86ce370c8f3@intel.com>
Date: Tue, 24 Oct 2017 00:35:42 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <1508106723-17935-1-git-send-email-chris.gekas@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Thanks, applied! :)

On 10/16/17 06:32, Christos Gkekas wrote:
> Delete variables 'gma_bottom' that are set but never used.
> 
> Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
> ---
>   drivers/gpu/drm/i915/gvt/cmd_parser.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/cmd_parser.c b/drivers/gpu/drm/i915/gvt/cmd_parser.c
> index 2c0ccbb..d75ce70 100644
> --- a/drivers/gpu/drm/i915/gvt/cmd_parser.c
> +++ b/drivers/gpu/drm/i915/gvt/cmd_parser.c
> @@ -2511,7 +2511,7 @@ static int command_scan(struct parser_exec_state *s,
>   
>   static int scan_workload(struct intel_vgpu_workload *workload)
>   {
> -	unsigned long gma_head, gma_tail, gma_bottom;
> +	unsigned long gma_head, gma_tail;
>   	struct parser_exec_state s;
>   	int ret = 0;
>   
> @@ -2521,7 +2521,6 @@ static int scan_workload(struct intel_vgpu_workload *workload)
>   
>   	gma_head = workload->rb_start + workload->rb_head;
>   	gma_tail = workload->rb_start + workload->rb_tail;
> -	gma_bottom = workload->rb_start +  _RING_CTL_BUF_SIZE(workload->rb_ctl);
>   
>   	s.buf_type = RING_BUFFER_INSTRUCTION;
>   	s.buf_addr_type = GTT_BUFFER;
> @@ -2557,7 +2556,7 @@ static int scan_workload(struct intel_vgpu_workload *workload)
>   static int scan_wa_ctx(struct intel_shadow_wa_ctx *wa_ctx)
>   {
>   
> -	unsigned long gma_head, gma_tail, gma_bottom, ring_size, ring_tail;
> +	unsigned long gma_head, gma_tail, ring_size, ring_tail;
>   	struct parser_exec_state s;
>   	int ret = 0;
>   	struct intel_vgpu_workload *workload = container_of(wa_ctx,
> @@ -2573,7 +2572,6 @@ static int scan_wa_ctx(struct intel_shadow_wa_ctx *wa_ctx)
>   			PAGE_SIZE);
>   	gma_head = wa_ctx->indirect_ctx.guest_gma;
>   	gma_tail = wa_ctx->indirect_ctx.guest_gma + ring_tail;
> -	gma_bottom = wa_ctx->indirect_ctx.guest_gma + ring_size;
>   
>   	s.buf_type = RING_BUFFER_INSTRUCTION;
>   	s.buf_addr_type = GTT_BUFFER;
>