From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7DFF30E834 for ; Wed, 25 Feb 2026 06:57:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772002662; cv=none; b=YNM7UrCUqBlseQACGbaCYaXotZ9ynudHmzIVimZete9FwKdsRa2nO2XcPXieoc1/5q8YT85De4LY76WHObot2Y+L8mJUlkcgd1Qqn8yzqF5lYoNCfy0X/O5GaEc589qJlpmT8WiGO3IwScB1S9j0cnTBxQITpRgMZjsb5M/IPzg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772002662; c=relaxed/simple; bh=xM+pXNjx5WhrwV2vpwiDD9Imq0ziFnk304V3V+OEhA8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ActBU1u2iIbVgVLhyWk55Bv6yme73/cFoAPLmdOtr2HrukyMxeK4Q4rp54fo3PB2D7gY3DYcg4EXes9Y+jpS+HCSKUac7DZtGKuCMyuYlcvJJo41xtkVsw5xhyjbD/nBPSsnyLOVIU+gm7nEgoEDWFHMgPcCjFKgMNssqGuHLC8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JmiIWvEK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JmiIWvEK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F5DAC19422; Wed, 25 Feb 2026 06:57:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772002662; bh=xM+pXNjx5WhrwV2vpwiDD9Imq0ziFnk304V3V+OEhA8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=JmiIWvEKpIk7l3GZIT4aKA0Rf2HNZC3Zpc/iTN9ugFqCH5S0X8y2As+Gk3XmSNRLc ccIIqpZlYvfPkL4dPxfJQHzCxW07cwGpCD0dW9DQ3L17zZIPXRPlfy4Yq4sgJtvU1S 53Qtep+OJShmsM4S4uUhBGtq8vLAIGZ2j9gHmhRDknwjA0IOncOUBebu6HThAVLMw2 8nI5rCYjOMwhipIw2g3qrah+kkO4T+/sCNY4NgwLDeYy6Ddw6ZnVeqvcS9ugQl9Oo5 5isKXZ3FUa46jib7wJHbxlLmr1QFKMS6KqhvjxTG9v/W7gFGSZlB3AqfoWwU6+ZZQE vhIXNkiQsM7ww== Message-ID: <4e84b9ea-9e7b-420a-bca9-6febd87a80cb@kernel.org> Date: Wed, 25 Feb 2026 07:57:39 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] powerpc/ps3: fix ps3.h kernel-doc warnings To: Randy Dunlap , linux-kernel@vger.kernel.org Cc: Geoff Levand , linuxppc-dev@lists.ozlabs.org, Madhavan Srinivasan , Michael Ellerman References: <20260222060101.2086504-1-rdunlap@infradead.org> Content-Language: fr-FR From: "Christophe Leroy (CS GROUP)" In-Reply-To: <20260222060101.2086504-1-rdunlap@infradead.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Randy, Le 22/02/2026 à 07:01, Randy Dunlap a écrit : > Eliminate all kernel-doc warnings in ps3.h: > - add one missing struct member description > - add one missing function short description > - correct one enum name typo > - change several incomplete kernel-doc comments to plain "/*" comments > > Examples: > > Warning: arch/powerpc/include/asm/ps3.h:96 struct member 'dev' not > described in 'ps3_dma_region' > Warning: arch/powerpc/include/asm/ps3.h:408 missing initial short > description on line: * ps3_system_bus_set_drvdata - > Warning: arch/powerpc/include/asm/ps3.h:473 Enum value > 'PS3_LPM_TB_TYPE_INTERNAL' not described in enum 'ps3_lpm_tb_type' > Warning: arch/powerpc/include/asm/ps3.h:473 Excess enum value > '@PS3_LPM_RIGHTS_USE_TB' description in 'ps3_lpm_tb_type' > > Signed-off-by: Randy Dunlap You sent a V2 with the same subject some time ago, see https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20251129183636.1893634-1-rdunlap@infradead.org/ Is this patch something else, does it superseeds V2, or is it a wrong resend of V1 ? Christophe > --- > Cc: Geoff Levand > Cc: linuxppc-dev@lists.ozlabs.org > Cc: Madhavan Srinivasan > Cc: Michael Ellerman > > arch/powerpc/include/asm/ps3.h | 26 ++++++++++++++------------ > 1 file changed, 14 insertions(+), 12 deletions(-) > > --- linux-next-20260220.orig/arch/powerpc/include/asm/ps3.h > +++ linux-next-20260220/arch/powerpc/include/asm/ps3.h > @@ -65,6 +65,7 @@ struct ps3_dma_region_ops; > > /** > * struct ps3_dma_region - A per device dma state variables structure > + * @dev: The device that this struct describes. > * @did: The HV device id. > * @page_size: The ioc pagesize. > * @region_type: The HV region type. > @@ -108,18 +109,19 @@ struct ps3_dma_region_ops { > dma_addr_t bus_addr, > unsigned long len); > }; > -/** > + > +struct ps3_system_bus_device; > + > +/* > * struct ps3_dma_region_init - Helper to initialize structure variables > * > * Helper to properly initialize variables prior to calling > * ps3_system_bus_device_register. > */ > - > -struct ps3_system_bus_device; > - > int ps3_dma_region_init(struct ps3_system_bus_device *dev, > struct ps3_dma_region *r, enum ps3_dma_page_size page_size, > enum ps3_dma_region_type region_type, void *addr, unsigned long len); > + > int ps3_dma_region_create(struct ps3_dma_region *r); > int ps3_dma_region_free(struct ps3_dma_region *r); > int ps3_dma_map(struct ps3_dma_region *r, unsigned long virt_addr, > @@ -136,7 +138,7 @@ enum ps3_mmio_page_size { > }; > > struct ps3_mmio_region_ops; > -/** > +/* > * struct ps3_mmio_region - a per device mmio state variables structure > * > * Current systems can be supported with a single region per device. > @@ -155,13 +157,13 @@ struct ps3_mmio_region_ops { > int (*create)(struct ps3_mmio_region *); > int (*free)(struct ps3_mmio_region *); > }; > -/** > - * struct ps3_mmio_region_init - Helper to initialize structure variables > + > +/* > + * ps3_mmio_region_init - Helper to initialize structure variables > * > * Helper to properly initialize variables prior to calling > * ps3_system_bus_device_register. > */ > - > int ps3_mmio_region_init(struct ps3_system_bus_device *dev, > struct ps3_mmio_region *r, unsigned long bus_addr, unsigned long len, > enum ps3_mmio_page_size page_size); > @@ -342,7 +344,7 @@ enum ps3_system_bus_device_type { > PS3_DEVICE_TYPE_LPM, > }; > > -/** > +/* > * struct ps3_system_bus_device - a device on the system bus > */ > > @@ -371,7 +373,7 @@ struct ps3_system_bus_device { > int ps3_open_hv_device(struct ps3_system_bus_device *dev); > int ps3_close_hv_device(struct ps3_system_bus_device *dev); > > -/** > +/* > * struct ps3_system_bus_driver - a driver for a device on the system bus > */ > > @@ -405,7 +407,7 @@ static inline struct ps3_system_bus_driv > } > > /** > - * ps3_system_bus_set_drvdata - > + * ps3_system_bus_set_drvdata - save driver private pointer in @dev > * @dev: device structure > * @data: Data to set > */ > @@ -464,7 +466,7 @@ enum ps3_lpm_rights { > * enum ps3_lpm_tb_type - Type of trace buffer lv1 should use. > * > * @PS3_LPM_TB_TYPE_NONE: Do not use a trace buffer. > - * @PS3_LPM_RIGHTS_USE_TB: Use the lv1 internal trace buffer. Must have > + * @PS3_LPM_TB_TYPE_INTERNAL: Use the lv1 internal trace buffer. Must have > * rights @PS3_LPM_RIGHTS_USE_TB. > */ > >