From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752632AbcISRoz (ORCPT ); Mon, 19 Sep 2016 13:44:55 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:34148 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750971AbcISRox (ORCPT ); Mon, 19 Sep 2016 13:44:53 -0400 Subject: Re: [PATCH] clk: st: clk-flexgen: Unmap region obtained by of_iomap To: Stephen Boyd References: <57d92940.6329c80a.3d959.9d78@mx.google.com> <20160914182454.GR7243@codeaurora.org> Cc: mturquette@baylibre.com, a.hajda@samsung.com, lee.jones@linaro.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org From: arvind Yadav Message-ID: <4e87aaaf-9169-0c19-e3ad-21b23babb20e@gmail.com> Date: Mon, 19 Sep 2016 23:14:46 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160914182454.GR7243@codeaurora.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 14 September 2016 11:54 PM, Stephen Boyd wrote: > On 09/14, arvind.yadav.cs@gmail.com wrote: >> @@ -337,6 +339,8 @@ static void __init st_of_flexgen_setup(struct device_node *np) >> return; >> >> err: >> + if (reg) > This is always true? Why check? > I have removed this check. Please review updated patch. >> + iounmap(reg); >> if (clk_data) >> kfree(clk_data->clks); >> kfree(clk_data); >> -- >> 1.7.9.5 >>