From: Ping-Ke Shih <pkshih@realtek.com>
To: "arnd@kernel.org" <arnd@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"kvalo@kernel.org" <kvalo@kernel.org>,
"Jes.Sorensen@gmail.com" <Jes.Sorensen@gmail.com>,
"rtl8821cerfe2@gmail.com" <rtl8821cerfe2@gmail.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"edumazet@google.com" <edumazet@google.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>
Subject: Re: [PATCH] wifi: rtl8xxxu: add LEDS_CLASS dependency
Date: Fri, 17 Feb 2023 11:50:53 +0000 [thread overview]
Message-ID: <4e88fae65e85366bfc5d728c0e4c47133c7b9523.camel@realtek.com> (raw)
In-Reply-To: <20230217095910.2480356-1-arnd@kernel.org>
On Fri, 2023-02-17 at 10:59 +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> rtl8xxxu now unconditionally uses LEDS_CLASS, so a Kconfig dependency
> is required to avoid link errors:
>
> aarch64-linux-ld: drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.o: in function
> `rtl8xxxu_disconnect':
> rtl8xxxu_core.c:(.text+0x730): undefined reference to `led_classdev_unregister'
>
> ERROR: modpost: "led_classdev_unregister" [drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.ko]
> undefined!
> ERROR: modpost: "led_classdev_register_ext" [drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.ko]
> undefined!
>
> Fixes: 3be01622995b ("wifi: rtl8xxxu: Register the LED and make it blink")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/net/wireless/realtek/rtl8xxxu/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/Kconfig
> b/drivers/net/wireless/realtek/rtl8xxxu/Kconfig
> index 091d3ad98093..2eed20b0988c 100644
> --- a/drivers/net/wireless/realtek/rtl8xxxu/Kconfig
> +++ b/drivers/net/wireless/realtek/rtl8xxxu/Kconfig
> @@ -5,6 +5,7 @@
> config RTL8XXXU
> tristate "Realtek 802.11n USB wireless chips support"
> depends on MAC80211 && USB
> + depends on LEDS_CLASS
With 'depends on', this item will disappear if LEDS_CLASS isn't selected.
Would it use 'select' instead?
Ping-Ke
next prev parent reply other threads:[~2023-02-17 11:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 9:59 Arnd Bergmann
2023-02-17 11:50 ` Ping-Ke Shih [this message]
2023-02-17 12:17 ` Arnd Bergmann
2023-02-17 16:31 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e88fae65e85366bfc5d728c0e4c47133c7b9523.camel@realtek.com \
--to=pkshih@realtek.com \
--cc=Jes.Sorensen@gmail.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rtl8821cerfe2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®