From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C7E5C04A95 for ; Thu, 29 Sep 2022 07:23:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234877AbiI2HXD (ORCPT ); Thu, 29 Sep 2022 03:23:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235212AbiI2HW6 (ORCPT ); Thu, 29 Sep 2022 03:22:58 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA2A51181F7 for ; Thu, 29 Sep 2022 00:22:49 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id g20so570220ljg.7 for ; Thu, 29 Sep 2022 00:22:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=MezbcwOoul10g9j1qktZYyuEnrjgCGFz14Jt2OIrWcU=; b=RhniWHb7IPXZdipNBOkrg2N2RPwnujVy2ZHUcFjJqBAAyZ+M8xTFHYrzfpIMhTY3D7 vyACY7zKLtg0e0PQ7Jd36pZWSw6Y25tUHKDTZopGN5QzHEUNqJcR8bg7iuy/dg3m1YOe 9YZa+L+76BZZVi/r3qzlsQ2KyB3F1+aWNFbUqyvVFMmuzfq42OdMTB67FB/rTAu/61sq xpAZyzBdHYFr+/mNGcXwLMqst/ykhLJUa89bvphSzgn3T5NkMYs41qhD0qRDfc6Om7Fl 7/myZVmBXsyGoTeCLw0E6gxNxUDc9qb3rHvWTQOhSD1wl9RlS/rATvrQ265OnTM/3+gv b4OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=MezbcwOoul10g9j1qktZYyuEnrjgCGFz14Jt2OIrWcU=; b=BsrwOp8mzRvSEXXtAo7Q9+seqE0a27Cr/hgo3jrEbzqNQsEcvK1nugwBosFIEKmSsC rRK87fGfBPIr/7sC4OUF7lZSemLITlozKuySa8CcaMxZ4s21LZrWbdtupiFtXUS9ytqu i2aogVJkkw2s7w9wK7OexAAm0dBKg7okKzJUXRr8SRaSrYA884pEuebvhbmDdOZc9AVt SEJQv7n4ds9umRPZqjElGW6iiNkQmVaKPnNa330EACCQKmNYhCf6do5PyEaWfs7D+an0 gfORFI28pRc4lt5Ux/w62sobaeG/9x49FT6qNWVBLG4Je2/r0/uwM9GRmLnLGGiUOm+5 YlDA== X-Gm-Message-State: ACrzQf3cBnuuzbP2g0acvj3y20T+wfVfPUA2NX2jkjrEvqxEw06wiUg9 0dXshUUh7P2W/LzEZ70GzP5chQ== X-Google-Smtp-Source: AMsMyM6G2n0Z1F3luJ+lGSBmmYESgaPvryPRha5PxI/XaKOCaJdB1gaXz9Rb5f0m4SUJFlXrO/h+yw== X-Received: by 2002:a2e:98c2:0:b0:26c:5d10:63dd with SMTP id s2-20020a2e98c2000000b0026c5d1063ddmr663534ljj.326.1664436167326; Thu, 29 Sep 2022 00:22:47 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id z12-20020ac2418c000000b00494813c689dsm701400lfh.219.2022.09.29.00.22.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Sep 2022 00:22:46 -0700 (PDT) Message-ID: <4e896382-c666-55c6-f50b-5c442e428a2b@linaro.org> Date: Thu, 29 Sep 2022 09:22:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v2 3/4] dt-bindings: net: qcom,ethqos: Convert bindings to yaml Content-Language: en-US To: Bhupesh Sharma , devicetree@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org, agross@kernel.org, bhupesh.linux@gmail.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, netdev@vger.kernel.org, Bjorn Andersson , Rob Herring , Vinod Koul , David Miller References: <20220929060405.2445745-1-bhupesh.sharma@linaro.org> <20220929060405.2445745-4-bhupesh.sharma@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20220929060405.2445745-4-bhupesh.sharma@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/09/2022 08:04, Bhupesh Sharma wrote: > Convert Qualcomm ETHQOS Ethernet devicetree binding to YAML. > > While at it, also add Qualcomm Ethernet ETHQOS compatible checks > in snps,dwmac YAML binding document. There are no checks added to snps,dwmac. > > Cc: Bjorn Andersson > Cc: Rob Herring > Cc: Vinod Koul > Cc: David Miller > Signed-off-by: Bhupesh Sharma > --- > .../devicetree/bindings/net/qcom,ethqos.txt | 66 -------- > .../devicetree/bindings/net/qcom,ethqos.yaml | 145 ++++++++++++++++++ > 2 files changed, 145 insertions(+), 66 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/net/qcom,ethqos.txt > create mode 100644 Documentation/devicetree/bindings/net/qcom,ethqos.yaml > > diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.txt b/Documentation/devicetree/bindings/net/qcom,ethqos.txt > deleted file mode 100644 > index 1f5746849a71..000000000000 > --- a/Documentation/devicetree/bindings/net/qcom,ethqos.txt > +++ /dev/null > @@ -1,66 +0,0 @@ > -Qualcomm Ethernet ETHQOS device > - > -This documents dwmmac based ethernet device which supports Gigabit > -ethernet for version v2.3.0 onwards. > - > -This device has following properties: > - > -Required properties: > - > -- compatible: Should be one of: > - "qcom,qcs404-ethqos" > - "qcom,sm8150-ethqos" > - > -- reg: Address and length of the register set for the device > - > -- reg-names: Should contain register names "stmmaceth", "rgmii" > - > -- clocks: Should contain phandle to clocks > - > -- clock-names: Should contain clock names "stmmaceth", "pclk", > - "ptp_ref", "rgmii" > - > -- interrupts: Should contain phandle to interrupts > - > -- interrupt-names: Should contain interrupt names "macirq", "eth_lpi" > - > -Rest of the properties are defined in stmmac.txt file in same directory > - > - > -Example: > - > -ethernet: ethernet@7a80000 { > - compatible = "qcom,qcs404-ethqos"; > - reg = <0x07a80000 0x10000>, > - <0x07a96000 0x100>; > - reg-names = "stmmaceth", "rgmii"; > - clock-names = "stmmaceth", "pclk", "ptp_ref", "rgmii"; > - clocks = <&gcc GCC_ETH_AXI_CLK>, > - <&gcc GCC_ETH_SLAVE_AHB_CLK>, > - <&gcc GCC_ETH_PTP_CLK>, > - <&gcc GCC_ETH_RGMII_CLK>; > - interrupts = , > - ; > - interrupt-names = "macirq", "eth_lpi"; > - snps,reset-gpio = <&tlmm 60 GPIO_ACTIVE_LOW>; > - snps,reset-active-low; > - > - snps,txpbl = <8>; > - snps,rxpbl = <2>; > - snps,aal; > - snps,tso; > - > - phy-handle = <&phy1>; > - phy-mode = "rgmii"; > - > - mdio { > - #address-cells = <0x1>; > - #size-cells = <0x0>; > - compatible = "snps,dwmac-mdio"; > - phy1: phy@4 { > - device_type = "ethernet-phy"; > - reg = <0x4>; > - }; > - }; > - > -}; > diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml > new file mode 100644 > index 000000000000..d3d8f6799d18 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml > @@ -0,0 +1,145 @@ > +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/qcom,ethqos.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Ethernet ETHQOS device > + > +maintainers: > + - Bhupesh Sharma > + > +description: > + This binding describes the dwmmac based Qualcomm ethernet devices which > + support Gigabit ethernet (version v2.3.0 onwards). > + > + So, this file documents platform glue layer for dwmmac stmmac based Qualcomm > + ethernet devices. > + > +allOf: > + - $ref: snps,dwmac.yaml# > + > +properties: > + compatible: > + enum: > + - qcom,qcs404-ethqos > + - qcom,sm8150-ethqos > + > + reg: > + maxItems: 2 > + > + reg-names: > + items: > + - const: stmmaceth > + - const: rgmii > + > + interrupts: > + items: > + - description: Combined signal for various interrupt events > + - description: The interrupt that occurs when Rx exits the LPI state > + > + interrupt-names: > + items: > + - const: macirq > + - const: eth_lpi > + > + clocks: > + maxItems: 4 > + > + clock-names: > + items: > + - const: stmmaceth > + - const: pclk > + - const: ptp_ref > + - const: rgmii > + > + iommus: > + maxItems: 1 > + > + mdio: > + $ref: mdio.yaml# > + unevaluatedProperties: false > + > + properties: > + compatible: > + const: snps,dwmac-mdio > + > + phy-handle: > + maxItems: 1 > + > + phy-mode: > + maxItems: 1 > + > + snps,reset-gpio: > + maxItems: 1 Why is this one here? It's already in snps,dwmac. Actually this applies to several other properties. You have unevaluatedProperties:false, so you do not have to duplicate snps,dwmac. You only need to constrain it, like we said about interrupts in your previous patch. > + > + power-domains: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > + rx-fifo-depth: > + $ref: /schemas/types.yaml#/definitions/uint32 > + > + tx-fifo-depth: > + $ref: /schemas/types.yaml#/definitions/uint32 > + > + snps,tso: > + type: boolean > + description: Enables the TSO feature (otherwise managed by MAC HW capability register). You add here several new properties. Mention in commit msg changes from pure conversion with answer to "why". > + > +required: > + - compatible > + - clocks > + - clock-names > + > +unevaluatedProperties: false > + Best regards, Krzysztof