From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752477AbcFINnh (ORCPT ); Thu, 9 Jun 2016 09:43:37 -0400 Received: from mx0a-0016f401.pphosted.com ([67.231.148.174]:3659 "EHLO mx0a-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751817AbcFINnf convert rfc822-to-8bit (ORCPT ); Thu, 9 Jun 2016 09:43:35 -0400 From: Amitkumar Karwar To: Javier Martinez Canillas , "linux-kernel@vger.kernel.org" CC: Xinming Hu , Kalle Valo , "netdev@vger.kernel.org" , "linux-wireless@vger.kernel.org" , "Nishant Sarmukadam" Subject: RE: [PATCH 0/8] mwifiex: Fix some error handling issues in mwifiex_sdio_probe() function Thread-Topic: [PATCH 0/8] mwifiex: Fix some error handling issues in mwifiex_sdio_probe() function Thread-Index: AQHRuCKw43NR+aQjeUe0zeHNXK8upp/hNlrw Date: Thu, 9 Jun 2016 13:43:32 +0000 Message-ID: <4e8cc9d4a8db4283aaa38564b6a36556@SC-EXCH04.marvell.com> References: <1464358702-19083-1-git-send-email-javier@osg.samsung.com> In-Reply-To: <1464358702-19083-1-git-send-email-javier@osg.samsung.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.93.176.43] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-06-09_05:,, signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1606090149 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Javier Martinez Canillas [mailto:javier@osg.samsung.com] > Sent: Friday, May 27, 2016 7:48 PM > To: linux-kernel@vger.kernel.org > Cc: Xinming Hu; Javier Martinez Canillas; Amitkumar Karwar; Kalle Valo; > netdev@vger.kernel.org; linux-wireless@vger.kernel.org; Nishant > Sarmukadam > Subject: [PATCH 0/8] mwifiex: Fix some error handling issues in > mwifiex_sdio_probe() function > > Hello, > > While booting a system with a mwifiex WiFi card, I noticed the following > missleading error message: > > [ 12.480042] mwifiex_sdio mmc2:0001:1: sdio platform data not available > > This error only applies to platforms that define a child node for the > SDIO device, but it's currently shown even in platforms that don't have > a child node defined. > > So this series fixes this issue and others I found in the .probe > function (mostly related to error handling and the error path) while > looking at it. > > Best regards, > Javier > > > Javier Martinez Canillas (8): > mwifiex: only call mwifiex_sdio_probe_of() if dev has an OF node > mwifiex: propagate sdio_enable_func() errno code in > mwifiex_sdio_probe() > mwifiex: propagate mwifiex_add_card() errno code in > mwifiex_sdio_probe() > mwifiex: consolidate mwifiex_sdio_probe() error paths > mwifiex: use dev_err() instead of pr_err() in mwifiex_sdio_probe() > mwifiex: check if mwifiex_sdio_probe_of() fails and return error > mwifiex: don't print an error if an optional DT property is missing > mwifiex: use better message and error code when OF node doesn't match > > drivers/net/wireless/marvell/mwifiex/sdio.c | 46 ++++++++++++++++++---- > ------- > 1 file changed, 28 insertions(+), 18 deletions(-) > Thanks for fixing the error handling code. These patches look fine to me. Acked-by: Amitkumar Karwar Regards, Amitkumar