From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B9063ED11F for ; Fri, 6 Feb 2026 13:53:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770385995; cv=none; b=TlHw0pK2YbmP2b4M7GQj3kVNIRGN4mtpN7aMrQTd4m8HnK9eua1yO7hrqGuTXYGXzNrtWOHPmAeupFzacwpffDJ3ivOhxeMVnfoJ24MuXBeinb5v7vAg6L3/QO+Ux6OLnYGKLmF9L61ERje0dYSjPxEvgZbRdR8it9hqm0IX2PU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770385995; c=relaxed/simple; bh=BTCl1waTtoigMsMpnR8YBbB0Si4sJa507CsBFJUe/4I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pDgJTwGwAPNlctlnbVjr/m8V+sSQ+0XduTWsFk+D9SOIP7iol2l3tvYIHKR6YSnst/fnokGrUFOaDqaZp1BF4mTtxmjvURLukaa4tEsD1cgZZVOD/MDVN5fhoIFLnM40dfFoorPRmrPqoaPtIizMYYbY/CVESnsjJs8sTj9f2YQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=jwgDK9Ge; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="jwgDK9Ge" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 568501A2C4D; Fri, 6 Feb 2026 13:53:13 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 19CB460729; Fri, 6 Feb 2026 13:53:13 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 5B10D119D1DE5; Fri, 6 Feb 2026 14:53:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1770385992; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=IkegMkQjQ9Huckg5GnwS8w6Cf+9nWxzGJJ7tJM78RNE=; b=jwgDK9GepwUjC/MF1b3f9sikxDOTwNUwaCe0/C4F9H18iQxp9poUHflEM1IM7NdezWbVhO RdatYMVsxG0s4DiWiKVPocrmGkcWt0KfVqe5PILZeYtmbrDynfpMBt/MPQfrqWiQPREZXm FRohhBzQGdpgyHZC5aMiaKiZhKMuYwE4dte3PFKZaGlMZfOCYpBRKmWokvBoYelBUgjDRO X2Wu1J79hg6b/wT9LhVh1OWekEZ0/6VHUfkHWRMpg7tfZiWR7T3V+/TOKtGcbVdNChwRk/ oR5e1xPXkIy08DH1Jm/0YoSV6p8b+b+lOU7SqNh1BR7Asligu226K7cY3wcOUQ== Message-ID: <4e8f0724-d747-4712-854c-c231a31e9e2c@bootlin.com> Date: Fri, 6 Feb 2026 14:53:34 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] drm/vkms: Add YUV410, YUV411, YVU410, and YVU411 support To: Renjun Wang , hamohammed.sa@gmail.com, simona@ffwll.ch, melissa.srw@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org References: Content-Language: en-US From: Louis Chauvet In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 On 2/2/26 16:11, Renjun Wang wrote: > Add support for the following planar YUV formats: > - DRM_FORMAT_YUV410 > - DRM_FORMAT_YUV411 > - DRM_FORMAT_YVU410 > - DRM_FORMAT_YVU411 > > These formats are handled by the existing planar_yuv_read_line() > function, which correctly handles the subsampling defined in each > format's drm_format_info. > > The YVU variants (YVU410, YVU411) are also added to > get_conversion_matrix_to_argb_u16() to ensure the U and V columns > are swapped correctly in the conversion matrix. Reviewed-by: Louis Chauvet > v2: > - update vkms_formats[] to add new formats. > > Signed-off-by: Renjun Wang > --- > drivers/gpu/drm/vkms/vkms_formats.c | 6 ++++++ > drivers/gpu/drm/vkms/vkms_plane.c | 4 ++++ > 2 files changed, 10 insertions(+) > > diff --git a/drivers/gpu/drm/vkms/vkms_formats.c b/drivers/gpu/drm/vkms/vkms_formats.c > index dfb8e13cba87..5ef5d49a44ef 100644 > --- a/drivers/gpu/drm/vkms/vkms_formats.c > +++ b/drivers/gpu/drm/vkms/vkms_formats.c > @@ -730,9 +730,13 @@ pixel_read_line_t get_pixel_read_line_function(u32 format) > case DRM_FORMAT_P012: > case DRM_FORMAT_P016: > return &YUV161616_semiplanar_read_line; > + case DRM_FORMAT_YUV410: > + case DRM_FORMAT_YUV411: > case DRM_FORMAT_YUV420: > case DRM_FORMAT_YUV422: > case DRM_FORMAT_YUV444: > + case DRM_FORMAT_YVU410: > + case DRM_FORMAT_YVU411: > case DRM_FORMAT_YVU420: > case DRM_FORMAT_YVU422: > case DRM_FORMAT_YVU444: > @@ -921,6 +925,8 @@ void get_conversion_matrix_to_argb_u16(u32 format, > memcpy(matrix, matrix_to_copy, sizeof(*matrix_to_copy)); > > switch (format) { > + case DRM_FORMAT_YVU410: > + case DRM_FORMAT_YVU411: > case DRM_FORMAT_YVU420: > case DRM_FORMAT_YVU422: > case DRM_FORMAT_YVU444: > diff --git a/drivers/gpu/drm/vkms/vkms_plane.c b/drivers/gpu/drm/vkms/vkms_plane.c > index 19fe6acad306..44773a82fbfd 100644 > --- a/drivers/gpu/drm/vkms/vkms_plane.c > +++ b/drivers/gpu/drm/vkms/vkms_plane.c > @@ -35,9 +35,13 @@ static const u32 vkms_formats[] = { > DRM_FORMAT_NV21, > DRM_FORMAT_NV61, > DRM_FORMAT_NV42, > + DRM_FORMAT_YUV410, > + DRM_FORMAT_YUV411, > DRM_FORMAT_YUV420, > DRM_FORMAT_YUV422, > DRM_FORMAT_YUV444, > + DRM_FORMAT_YVU410, > + DRM_FORMAT_YVU411, > DRM_FORMAT_YVU420, > DRM_FORMAT_YVU422, > DRM_FORMAT_YVU444,