From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCE183E8C7F for ; Tue, 17 Mar 2026 14:39:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773758388; cv=none; b=nKrV7ZwL9UE5zgz7INbCeBX5AG9V9BI0phnTJRRemoJlHUoxmrWc2K2fNpP5pHcvwCsHtrNh5au0y5bsAwOXVbvgDztC/m0HejJRDklUemw/jRZrP5Ldwv1jlVrwP3Y0A6jPUeMhl+wA8ktehjRnagFORXpLUN2+5KAx75VLM+I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773758388; c=relaxed/simple; bh=BB/X+NV5GRChWNW3f6GBQfx7H2/PWP9X+pfyMu9gT0c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=W3fqLpkD9Bo2gvkbl8RsskVBL4YbpdDjW6EAG1Bu0/gkiLk8vhKoJ12jLJnbDAXUyzuQ9wYoV26w6uPIS8n0PKmSTJn3oAk4bLbRwSkCwfvQ9swXiKHStWRZvg8hg7mT6pBmIeDaeY0FHwrvlIXhpSEn53MX2TuPh/DrIHIxZVs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ifG9ik3/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=T0cxbh35; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ifG9ik3/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="T0cxbh35" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62HE1mvd2905944 for ; Tue, 17 Mar 2026 14:39:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= HfH7+8xyCnKEFj/t4NkpCGyDGSuPLP2Tdj+9N2X9m7U=; b=ifG9ik3/MZH0ludP KkU0sHezaNpXxdmn7Jpymgy+afyKhOSDBYq3tr6zRD2JSF/b5FA9sPWlzYZrp9F6 4pm4u1/Gyj0EC8ANe3uA/vuCloTuNOVgTZEQ/Vhc3an8wYuLfhxkNV58Q1BdYuzM Zi4wMcgABHr3Bxrdc59XKFrPtBvMPtQJn+iJex2jelpru1u213VH7UM2TOeRX2tq ME20BP9bybdcCyZ9Hb20xd2f4dwShwu4fOV4jvSG3/5cAGQ9hijnsdnxfgfPBDq/ vFMlAByO3C0eXxBKKMRnu9t1Opc0JOpUZBtR9CTbHGjbTR5vXNDkOjQ2b7i+Ejj7 Bxi/Iw== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cy2jxhkaw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Mar 2026 14:39:45 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8cd98d96382so668519985a.0 for ; Tue, 17 Mar 2026 07:39:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773758385; x=1774363185; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=HfH7+8xyCnKEFj/t4NkpCGyDGSuPLP2Tdj+9N2X9m7U=; b=T0cxbh35brJRVH5RstFVilBrNrSUBqSu+HtDimIvSvM2AmYq+5EIYczTt3CmwK1pHj 27SG2TZQaLZELwU9DD35kv0KFAYhJj1GPQqq9pfqHGVHnuau/ouOcH1SQOv3bnwgzQfF ll4ZRO2YBvQ77JJ2AiwIsPoH3t2Mwrd7SQZ8J+2ZX1auv3Mya4G2RaI5T9YCmQuSyFr2 LrGiVyJ3M9zWWnGNjx+H/i0A7/6oMFI1N+VV+3o5wACjJX+Bo2FXgFhqiL9zAtzaurB7 01p8s4d4DI+6OAzKONB4tni7vHvtFxHG9SFeqi4lMxGc013MCAs2oBWwsi1fq+xCY2Q1 KiVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773758385; x=1774363185; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HfH7+8xyCnKEFj/t4NkpCGyDGSuPLP2Tdj+9N2X9m7U=; b=YgSY6mN0LsNca1Z51Q4n3mP/3Ir4xFT+nOGHUMUrNOZStnuXsmLAqDpFXCTDAGm1KV 93NoCANHownSpiQaG+RctrjJyNGkSrpPJ57ZHK90Y+VyqJdKSQK71Pn4GQmatCCCQjxZ kJaKyMPVPeCBEcydD1QHQ7JGGj4HOr/+hozwtPjqYEawgMFZXZv7ekcN6FNLehR9CklN 8+58aZEQ2UedhORtVzoLc9kDgBwnxilta5CyViP5DnPbP19jFGvXrXZV2naL6ZaKGgcR D2cI4xdyfhBqtFum4tvYXshc4FOJzOLA1oZo5dBqdnO3fsOqVfau0pznCIfqMkVFRr7i XTpQ== X-Forwarded-Encrypted: i=1; AJvYcCV5cHZLzVAsIaN8WYj5WUuNRDQH+vgFVRNLzlwwoLycnTO1St53dWFRG/uIrBy40FIvsSXYoZxTEFo42Fg=@vger.kernel.org X-Gm-Message-State: AOJu0YzH+iG5FWyEjLyNraYUX5EmdlSAy2oDpPHn6UZIUYsdwJ+W3K7i Uuwa1+TmJEwYBwGxd+GBT1EBJXSl/Ndp1bi+nRmt1t+5fubLPiBa6ZxKioRHws/RBxiFB0fCrKR 0R7yLX/GDtgC8IdOA+CMiPqla8pku5B9L4lird1RgGSbJY3fvaT+P7LmQhDDt7LcZ2HqZJOZq+/ A= X-Gm-Gg: ATEYQzzmLrfUf6Y9inUiS66v5+vu2ddR75wI7W9xgn32D15PgCRiLizdSoG1Y9NoRD6 tn888+1W28KySCMvClTWQnlfmOKwJAVZuYaUZFubpXGUcEJG+ViDUwl6vyImjQYZIKq1G3Xz8I9 Mpiz3/uTNw1l91gCSN2BAI9hMUy8+qo5Glc1+LlVYXUbh9RbpDti4NsAk9lnNLwL8K52IkE+/Qd 4XzQ8804iYWhyAHChcPHprT2T/ESAsfiZidk5OWNVNwsgSkxgWv59DwY64GsLP+NN46H3V/6RuG KGj4CQpLTU9qryzO08vvjo+h6sFVu3ztqAOJ/o5ytyYtoNtrIOZ0QLMSnoOf6iekwivVwS4/63v 75AORBy94VnLvLbwFKo3utvaolmo3AK3wyO64CcekV6in/PRU X-Received: by 2002:a05:620a:444f:b0:8c6:db05:8eb5 with SMTP id af79cd13be357-8cdb5b5627amr2252398585a.67.1773758384540; Tue, 17 Mar 2026 07:39:44 -0700 (PDT) X-Received: by 2002:a05:620a:444f:b0:8c6:db05:8eb5 with SMTP id af79cd13be357-8cdb5b5627amr2252393385a.67.1773758383983; Tue, 17 Mar 2026 07:39:43 -0700 (PDT) Received: from [192.168.1.29] ([178.197.219.94]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b976cefb9a7sm785769966b.45.2026.03.17.07.39.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Mar 2026 07:39:43 -0700 (PDT) Message-ID: <4e93db73-20d2-436c-b9e4-4b41e5c237fa@oss.qualcomm.com> Date: Tue, 17 Mar 2026 15:39:41 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RESEND PATCH] mux: mmio: Zero the allocated memory To: Greg Kroah-Hartman Cc: Peter Rosin , linux-kernel@vger.kernel.org References: <20260317124826.233006-2-krzysztof.kozlowski@oss.qualcomm.com> <2026031710-implicit-hungrily-3b47@gregkh> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@oss.qualcomm.com; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTpLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQG9zcy5xdWFsY29tbS5jb20+wsGXBBMB CgBBFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmkknB4CGwMFCRaWdJoFCwkIBwICIgIGFQoJ CAsCBBYCAwECHgcCF4AACgkQG5NDfTtBYpuCRw/+J19mfHuaPt205FXRSpogs/WWdheqNZ2s i50LIK7OJmBQ8+17LTCOV8MYgFTDRdWdM5PF2OafmVd7CT/K4B3pPfacHATtOqQFHYeHrGPf 2+4QxUyHIfx+Wp4GixnqpbXc76nTDv+rX8EbAB7e+9X35oKSJf/YhLFjGOD1Nl/s1WwHTJtQ a2XSXZ2T9HXa+nKMQfaiQI4WoFXjSt+tsAFXAuq1SLarpct4h52z4Zk//ET6Xs0zCWXm9HEz v4WR/Q7sycHeCGwm2p4thRak/B7yDPFOlZAQNdwBsnCkoFE1qLXI8ZgoWNd4TlcjG9UJSwru s1WTQVprOBYdxPkvUOlaXYjDo2QsSaMilJioyJkrniJnc7sdzcfkwfdWSnC+2DbHd4wxrRtW kajTc7OnJEiM78U3/GfvXgxCwYV297yClzkUIWqVpY2HYLBgkI89ntnN95ePyTnLSQ8WIZJk ug0/WZfTmCxX0SMxfCYt36QwlWsImHpArS6xjTvUwUNTUYN6XxYZuYBmJQF9eLERK2z3KUeY 2Ku5ZTm5axvlraM0VhUn8yv7G5Pciv7oGXJxrA6k4P9CAvHYeJSTXYnrLr/Kabn+6rc0my/l RMq9GeEUL3LbIUadL78yAtpf7HpNavYkVureuFD8xK8HntEHySnf7s2L28+kDbnDi27WR5kn u/POwU0EVUNcNAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDy fv4dEKuCqeh0hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOG mLPRIBkXHqJYoHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6 H79LIsiYqf92H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4ar gt4e+jum3NwtyupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8 nO2N5OsFJOcd5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFF knCmLpowhct95ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz 7fMkcaZU+ok/+HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgN yxBZepj41oVqFPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMi p+12jgw4mGjy5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYC GwwWIQSb0H4ODFH41ZZ3t1Qbk0N9O0FimwUCaBdQXwUJFpZbKgAKCRAbk0N9O0Fim07TD/92 Vcmzn/jaEBcqyT48ODfDIQVvg2nIDW+qbHtJ8DOT0d/qVbBTU7oBuo0xuHo+MTBp0pSTWbTh LsSN1AuyP8wFKChC0JPcwOZZRS0dl3lFgg+c+rdZUHjsa247r+7fvm2zGG1/u+33lBJgnAIH 5lSCjhP4VXiGq5ngCxGRuBq+0jNCKyAOC/vq2cS/dgdXwmf2aL8G7QVREX7mSl0x+CjWyrpF c1D/9NV/zIWBG1NR1fFb+oeOVhRGubYfiS62htUQjGLK7qbTmrd715kH9Noww1U5HH7WQzeP t/SvC0RhQXNjXKBB+lwwM+XulFigmMF1KybRm7MNoLBrGDa3yGpAkHMkJ7NM4iSMdSxYAr60 RtThnhKc2kLIzd8GqyBh0nGPIL+1ZVMBDXw1Eu0/Du0rWt1zAKXQYVAfBLCTmkOnPU0fjR7q VT41xdJ6KqQMNGQeV+0o9X91X6VBeK6Na3zt5y4eWkve65DRlk1aoeBmhAteioLZlXkqu0pZ v+PKIVf+zFKuh0At/TN/618e/QVlZPbMeNSp3S3ieMP9Q6y4gw5CfgiDRJ2K9g99m6Rvlx1q wom6QbU06ltbvJE2K9oKd9nPp1NrBfBdEhX8oOwdCLJXEq83vdtOEqE42RxfYta4P3by0BHp cwzYbmi/Et7T2+47PN9NZAOyb771QoVr8A== In-Reply-To: <2026031710-implicit-hungrily-3b47@gregkh> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: cyWHEEqXiO7iRDz0uRMZWx5daprHYaqM X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE3MDEyOSBTYWx0ZWRfX1tjh5vibYl7P kCuYv/oGOYhJBTxigCw5s2gfkOD9m0QYvYbQsvyvLx9ul6wx2PCYoc8WWh5e9wh4khO5dyYSs0T 1qnTWQNXLDd/k1YGlVmJxtmP4goDtuJ8zsyvVX71OWD/w4sb8IPxs4he1LGKwXTjSJ15wu2x5RO 8Gu/1c0q2lxGO0wNFSC2fg5ymGNgSHJfR2eGvFgUBdEcBeMphmY/IqCSpxKwxV2POakLZJc+WzM jtFFk8tPRXf6+RH8npY60oqWeP9fZsKU4g9mE+qjZI85r7IoqaeNUG3E8b+hlT2d/Xa+TjQjpnQ XSMZfVTVgeOVISh6xcvnhtQQsC9rV9vnM3O4kcDnkIzdK5YgHxGVv7+6/xviWfsekANmlJzXgeJ 3xHgWYZHVsfiXKu85FAV5uFo68uqpqOhZ5tGyb2f3vTvj8BvyPeRpTVRQVRwblmgH29K8ffLehd JRjXzh4ad4wfHnNPdBA== X-Authority-Analysis: v=2.4 cv=c4imgB9l c=1 sm=1 tr=0 ts=69b967b1 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=gOEeR9iKwsj33Yj5oN/cWg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=7kGuuEbt49_fgmZw5MAA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-ORIG-GUID: cyWHEEqXiO7iRDz0uRMZWx5daprHYaqM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-17_01,2026-03-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 malwarescore=0 impostorscore=0 phishscore=0 priorityscore=1501 bulkscore=0 spamscore=0 suspectscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603170129 On 17/03/2026 14:33, Greg Kroah-Hartman wrote: > On Tue, Mar 17, 2026 at 01:48:27PM +0100, Krzysztof Kozlowski wrote: >> Zero the allocated memory in probe() for fields and states for increased >> code safety and to match expected Linux coding style. > > What "style"? I'm all for zeroing out memory to start with, but as this That style ^^^ that we expect zero'ed memory :). Also, memory-allocation.rst says: "And, to be on the safe side it's best to use routines that set memory to zero, like kzalloc()." So the style/preference is actually documented. > has lived for so long without this, are you sure it's still needed? Are > there uninitialized fields in here that we are now properly > initializing? Yes. The second allocation is for "hardware_states" which does not receive initialization in the probe, but first assignment is in suspend() callback. Zeroing the first allocation for "fields" is rather style or convention, because the probe assigns it further in the probe. However if the driver exists probe via error path, these bits would remain random heap data, which most likely does not matter. I can expand commit msg with above. Best regards, Krzysztof