From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DB73C4332F for ; Fri, 16 Dec 2022 11:48:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230070AbiLPLsH (ORCPT ); Fri, 16 Dec 2022 06:48:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229495AbiLPLsE (ORCPT ); Fri, 16 Dec 2022 06:48:04 -0500 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA38F9598 for ; Fri, 16 Dec 2022 03:48:02 -0800 (PST) Received: from dggpemm500017.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4NYS1c4BkczJpMl; Fri, 16 Dec 2022 19:44:20 +0800 (CST) Received: from [10.174.178.220] (10.174.178.220) by dggpemm500017.china.huawei.com (7.185.36.178) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 16 Dec 2022 19:48:00 +0800 Message-ID: <4e9f9b32-7835-e4c5-55cb-9db82c98f9c1@huawei.com> Date: Fri, 16 Dec 2022 19:47:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] cma:tracing: Print alloc result in trace_cma_alloc_finish Content-Language: en-US To: Steven Rostedt , Masami Hiramatsu , Andrew Morton , , CC: , References: <20221208142130.1501195-1-haowenchao@huawei.com> From: Wenchao Hao In-Reply-To: <20221208142130.1501195-1-haowenchao@huawei.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.220] X-ClientProxiedBy: dggpeml500015.china.huawei.com (7.185.36.226) To dggpemm500017.china.huawei.com (7.185.36.178) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/12/8 22:21, Wenchao Hao wrote: > The result of allocation is not printed in trace_cma_alloc_finish > now, while it's important to do it so we can set filters to catch > specific error on allocation or trigger some operations on specific > error. > > Although we have printed the result in log, but the log is > conditional and could not be filtered by tracing event. > > What's more, it introduce little overhead to print this result. > The result of allocation is named as errorno in trace. > > Signed-off-by: Wenchao Hao > --- > include/trace/events/cma.h | 32 +++++++++++++++++++++++++++++--- > mm/cma.c | 2 +- > 2 files changed, 30 insertions(+), 4 deletions(-) > > diff --git a/include/trace/events/cma.h b/include/trace/events/cma.h > index 3d708dae1542..ef75ea606ab2 100644 > --- a/include/trace/events/cma.h > +++ b/include/trace/events/cma.h > @@ -91,12 +91,38 @@ TRACE_EVENT(cma_alloc_start, > __entry->align) > ); > > -DEFINE_EVENT(cma_alloc_class, cma_alloc_finish, > +TRACE_EVENT(cma_alloc_finish, > > TP_PROTO(const char *name, unsigned long pfn, const struct page *page, > - unsigned long count, unsigned int align), > + unsigned long count, unsigned int align, int errorno), > > - TP_ARGS(name, pfn, page, count, align) > + TP_ARGS(name, pfn, page, count, align, errorno), > + > + TP_STRUCT__entry( > + __string(name, name) > + __field(unsigned long, pfn) > + __field(const struct page *, page) > + __field(unsigned long, count) > + __field(unsigned int, align) > + __field(int, errorno) > + ), > + > + TP_fast_assign( > + __assign_str(name, name); > + __entry->pfn = pfn; > + __entry->page = page; > + __entry->count = count; > + __entry->align = align; > + __entry->errorno = errorno; > + ), > + > + TP_printk("name=%s pfn=0x%lx page=%p count=%lu align=%u errorno=%d", > + __get_str(name), > + __entry->pfn, > + __entry->page, > + __entry->count, > + __entry->align, > + __entry->errorno) > ); > > DEFINE_EVENT(cma_alloc_class, cma_alloc_busy_retry, > diff --git a/mm/cma.c b/mm/cma.c > index 4a978e09547a..a75b17b03b66 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -491,7 +491,7 @@ struct page *cma_alloc(struct cma *cma, unsigned long count, > start = bitmap_no + mask + 1; > } > > - trace_cma_alloc_finish(cma->name, pfn, page, count, align); > + trace_cma_alloc_finish(cma->name, pfn, page, count, align, ret); > > /* > * CMA can allocate multiple page blocks, which results in different pinging