mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bastien Nocera <hadess@hadess.net>
To: "Sumedh W. Jambekar" <linuxsumedh@gmail.com>,
	marcel@holtmann.org,  luiz.dentz@gmail.com,
	linux-bluetooth@vger.kernel.org,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bluetooth btusb.c: Add pr_info() for logging.
Date: Mon, 23 Jun 2025 11:42:07 +0200	[thread overview]
Message-ID: <4ea897245e112fc5a5fbba3d3f34e6f7f51be8fa.camel@hadess.net> (raw)
In-Reply-To: <20250622165753.65461-1-linuxsumedh@gmail.com>

On Sun, 2025-06-22 at 22:27 +0530, Sumedh W. Jambekar wrote:
> In this commit, the pr_info() call is added in the
> probe function for logging purposes. This is done
> as part of the assignment in the LFD103 course.

Do not submit junk contributions to upstream as part of your course
work. This is a burden on upstream, and you failed to even run it
through checkpatch.pl which would have shown that you used the wrong
spacing.

This is a good way to get blocked upstream, don't send another patch
unless it is something that can be merged upstream.

> 
> Signed-off-by: Sumedh W. Jambekar <linuxsumedh@gmail.com>
> ---
>  drivers/bluetooth/btusb.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 9ab661d2d1e6..5ecb9a61a33b 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -3858,6 +3858,7 @@ static int btusb_probe(struct usb_interface
> *intf,
>  	unsigned ifnum_base;
>  	int i, err, priv_size;
>  
> +    pr_info("SWJ changed the btusb driver in the Linux Kernel\n");
>  	BT_DBG("intf %p id %p", intf, id);
>  
>  	if ((id->driver_info & BTUSB_IFNUM_2) &&

      reply	other threads:[~2025-06-23  9:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-22 16:57 Sumedh W. Jambekar
2025-06-23  9:42 ` Bastien Nocera [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ea897245e112fc5a5fbba3d3f34e6f7f51be8fa.camel@hadess.net \
    --to=hadess@hadess.net \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxsumedh@gmail.com \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®