From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBB5641B379 for ; Wed, 4 Feb 2026 16:10:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770221457; cv=none; b=uAdpASmpZ2QWS1HlA4mnb7Blx8lxR0QLZA3JYSOInHi6UKwlmM+k3Bt3m8sfzBjo1yWk982a2M/51DNQ87kOFQuArwsfeS6Hj7Ms9tThsWH96tsjFfkgpX/1ShysF3F5Q7P49xNM6xrKw2BrJWTuAuUveYyLIXYCgfoJOnwiizM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770221457; c=relaxed/simple; bh=4E1jH7wOwRsAxSfEB1aLRRNC3xEDX0UlJw3aUJFDyj8=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=mkD6egfZA8tRWOWxSXGn/z1N37SOgUBSuynkS6g4KrbQavwEWXgNSY1TbpbSqxEP55f9QLIS6LFf7JYrlIyS9Bla2tJa8rPbAcFvzKhPbIrXmP70xoT5ix81u702VzbNnwlNQjNuZwhSzz1SicwnINS9Kxl593H5NIkT1lTKy18= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jSFz9wGu; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jSFz9wGu" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-480142406b3so53242535e9.1 for ; Wed, 04 Feb 2026 08:10:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770221455; x=1770826255; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=0zp6ukmR5KrJWp6xEwH+jtTQlqHxCZ+qzDHuKO7DipM=; b=jSFz9wGuk90pcsb/O3xYUeHhjgpDirrIQd8XShawYoSAmrJO10KuO+vHGLF0+EKdLi DRBwVqorZSqEcK/FS0TAn6aTcJ3/d0dVkpZXlyLmku1EFCvEeGNOzGRS2ZhxKzbJiuVF e+m3dNY8MTGe7y+DYDNEqwiQrVvo7UBmCaBBCVMEfMgTiq8CSnSEiT32XXMSLgpyLuc8 DU/cyRbDvCVi+uvBNHbgfjzmPNQNq4fyXjRQey49kkn7NX/hAuILUt+yhUsDZktdnW7b 7XuV+YaODfpZp10PioxobEC5Bq3FB5oq0pg29+FJ1/7Wo+wF89zqNu22oVvGlvkTHIHh o9ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770221455; x=1770826255; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0zp6ukmR5KrJWp6xEwH+jtTQlqHxCZ+qzDHuKO7DipM=; b=CdjH1DAXkYt9e/gUYq+GeG5DC8hfr2AuqfcgFRwm3TYRC65i59VurPjhJxqIi4+A2b U1IUStqOMoMUFTaVBzR2WLtk2HXmnNF75vUoRQOBZfyvIY4XERVfk6XRFoMBb2KGX5BK otbBCMQUsU+9LnQnWZimA9gh1Zw8LmpBq65LfXbPQCeh/XJXv0slt4FkAIn8pN6+ENJn 5ewj14qnMIH50/HVo7uyFTZbGo5040PVIiQkYxxogwk46XydzkUWkrANNX/Jz1I6AIFf fRd4TAd0q0EN06o+3HlUhF4U7MwTKmVludLdj3xUtDMG14smC4ENKheMIjAsSm8N8Xkz 6ZlA== X-Forwarded-Encrypted: i=1; AJvYcCWnUrkD/qwkucFBxXnAxhMgq3hLadw9irV6PupazHJC98Gl68JcCqnA0RvZr5BBC9fFXiZOoZACnkNO2X8=@vger.kernel.org X-Gm-Message-State: AOJu0YwWVAWnkxBGHvJLbHaT+wYDQHY/TKaN9zXZD1cPLbPGxv62ziW4 Vh764atbbc/t29Q/zFUbf5bL23L8DaegYKiv7sVSjvC0ZH7Nq6j3al/X9zSlyg== X-Gm-Gg: AZuq6aLJcTR9y1UagymFYJKNaU30hcJU/f57FqnDb0ijxWzdXsUiHnouC5gPYNpL6YL +Opx2d83PmWFP9Wi26qeP4czsKkyKSDzYpCBScjieD2m5Ok20zeArnLg9L03W74ZxRJUCXgG4Ht 6IDrODRzswefsA5DnqnZKPfarEJT667IEPgrFikzWmkQBoEDZSFsQFiRwDk0UXaFzGK3FMZFh94 dcJEyQWOZUQSknkLkO3GZXjKl/AaFIcz3Q+EX4/cDd/WYigrjEJ+dX67+mWrOzPaV/R9mlfCBER /cqq7yTvO77ZH9JueZ7ggR4imyPjDPdWDpdZOpeuw8TXAXKsJCiGQbBPLETcGEY5Z4O6cR7eLs/ PqkVYiPNjMnVpHZQnd6Yb5w11Ohan2m6KX3h2NVaT9lnEnF6s+Gf8+OTxDWRvEV1uuKvmJH6cFC VC8GXYKksoO4gXsLU4utY= X-Received: by 2002:a05:600c:8b8a:b0:480:68ed:1e70 with SMTP id 5b1f17b1804b1-4830e99d515mr43578965e9.35.1770221454940; Wed, 04 Feb 2026 08:10:54 -0800 (PST) Received: from [192.168.1.187] ([148.63.225.166]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4361805faf7sm7225027f8f.30.2026.02.04.08.10.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Feb 2026 08:10:54 -0800 (PST) Message-ID: <4eacb9b5e846b74df5ebb02f1c77135fb1b2fa0f.camel@gmail.com> Subject: Re: [PATCH 2/3] iio: adc: ad7768-1: prevent one-shot mode with wideband filter From: Nuno =?ISO-8859-1?Q?S=E1?= To: Jonathan Santos , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Michael.Hennerich@analog.com, lars@metafoo.de, jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org Date: Wed, 04 Feb 2026 16:11:37 +0000 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Sat, 2026-01-31 at 22:35 -0300, Jonathan Santos wrote: > The AD7768-1 datasheet specifies that the wideband low ripple FIR filter > is only available in continuous conversion mode and should not be used > with one-shot mode to avoid malfunction and incorrect data. >=20 > Add filter type checks in ad7768_scan_direct() to skip one-shot mode > switching when wideband filter is configured. >=20 > Signed-off-by: Jonathan Santos > --- > =C2=A0drivers/iio/adc/ad7768-1.c | 25 +++++++++++++++---------- > =C2=A01 file changed, 15 insertions(+), 10 deletions(-) >=20 > diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c > index 8d39b71703ae..374614ea97ac 100644 > --- a/drivers/iio/adc/ad7768-1.c > +++ b/drivers/iio/adc/ad7768-1.c > @@ -463,14 +463,17 @@ static int ad7768_scan_direct(struct iio_dev *indio= _dev) > =C2=A0 struct ad7768_state *st =3D iio_priv(indio_dev); > =C2=A0 int readval, ret; > =C2=A0 > - ret =3D ad7768_set_mode(st, AD7768_ONE_SHOT); > - if (ret < 0) > - return ret; > + /* Wideband filter is not available in One-Shot conversion mode */ > + if (st->filter_type !=3D AD7768_FILTER_WIDEBAND) { > + ret =3D ad7768_set_mode(st, AD7768_ONE_SHOT); > + if (ret < 0) > + return ret; > =C2=A0 > - /* One-shot mode requires a SYNC pulse to generate a new sample */ > - ret =3D ad7768_send_sync_pulse(st); > - if (ret) > - return ret; > + /* One-shot mode requires a SYNC pulse to generate a new sample */ > + ret =3D ad7768_send_sync_pulse(st); > + if (ret) > + return ret; > + } > =C2=A0 > =C2=A0 reinit_completion(&st->completion); > =C2=A0 > @@ -496,9 +499,11 @@ static int ad7768_scan_direct(struct iio_dev *indio_= dev) > =C2=A0 * Any SPI configuration of the AD7768-1 can only be > =C2=A0 * performed in continuous conversion mode. > =C2=A0 */ > - ret =3D ad7768_set_mode(st, AD7768_CONTINUOUS); > - if (ret < 0) > - return ret; > + if (st->filter_type !=3D AD7768_FILTER_WIDEBAND) { > + ret =3D ad7768_set_mode(st, AD7768_CONTINUOUS); > + if (ret < 0) > + return ret; > + } So the idea is to still have continuous mode running and get the latest sam= ple after we do reinit_completion()? If that's the case, why do we have the one shot = logic? Does it bring that much added value? Asking because I'm just wondering we could = just let it in continuous mode all the time. This also sounds like a fix so maybe a Fixes tag? - Nuno S=C3=A1