From: Breno Leitao <leitao@debian.org>
To: David Laight <David.Laight@ACULAB.COM>,
"kuba@kernel.org" <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: leit@meta.com, "leit@fb.com" <leit@fb.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Michael van der Westhuizen <rmikey@meta.com>
Subject: Re: [PATCH v3] netpoll: Remove 4s sleep during carrier detection
Date: Thu, 26 Jan 2023 10:52:11 +0000 [thread overview]
Message-ID: <4eaff461-47d1-cb9e-b24f-3699a77c3a3d@debian.org> (raw)
In-Reply-To: <6d13242627e84bde8129e75b6324d905@AcuMS.aculab.com>
On 26/01/2023 09:04, David Laight wrote:
>> This patch removes the msleep(4s) during netpoll_setup() if the carrier
>> appears instantly.
>>
>> Here are some scenarios where this workaround is counter-productive in
>> modern ages:
>>
>> Servers which have BMC communicating over NC-SI via the same NIC as gets
>> used for netconsole. BMC will keep the PHY up, hence the carrier
>> appearing instantly.
>>
>> The link is fibre, SERDES getting sync could happen within 0.1Hz, and
>> the carrier also appears instantly.
>>
>> Other than that, if a driver is reporting instant carrier and then
>> losing it, this is probably a driver bug.
>
> I can't help feeling that this will break something.
If we see breakages after this patch, then we can identify broken
drivers, and fix the driver itself.
On the other side, if we keep this workaround, we are penalizing the
boot of every modern machine in 4s, just because we might have some
broken driver somewhere.
next prev parent reply other threads:[~2023-01-26 10:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 18:52 Breno Leitao
2023-01-26 9:04 ` David Laight
2023-01-26 10:52 ` Breno Leitao [this message]
2023-01-26 13:22 ` Andrew Lunn
2023-01-28 8:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4eaff461-47d1-cb9e-b24f-3699a77c3a3d@debian.org \
--to=leitao@debian.org \
--cc=David.Laight@ACULAB.COM \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=leit@fb.com \
--cc=leit@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmikey@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®