From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24E02C4332D for ; Thu, 19 Mar 2020 13:31:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0300120409 for ; Thu, 19 Mar 2020 13:31:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728489AbgCSNbk (ORCPT ); Thu, 19 Mar 2020 09:31:40 -0400 Received: from mga01.intel.com ([192.55.52.88]:17575 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729673AbgCSNRj (ORCPT ); Thu, 19 Mar 2020 09:17:39 -0400 IronPort-SDR: 4NF+HAzRbU2lcDbFSMKGOyq1U2aJPs6l5SHX6G7R+/eTvI+wJ52k3QrKO/3/hDXd5WQhIHvlTt tL/Hrd4vANjw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Mar 2020 06:17:39 -0700 IronPort-SDR: 13+14NwKfODm3LUqECGN0X6N4/JeF1gSWFftIsTQQaHgh6TqEtdjX59Tpkus1Jmuk7BqQuHJLS B3SRkzWbrNrA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,571,1574150400"; d="scan'208";a="245157334" Received: from crojewsk-mobl1.ger.corp.intel.com (HELO [10.249.128.140]) ([10.249.128.140]) by orsmga003.jf.intel.com with ESMTP; 19 Mar 2020 06:17:36 -0700 Subject: Re: snd_hda_intel/sst-acpi sound breakage on suspend/resume since 5.6-rc1 To: Dominik Brodowski , kuninori.morimoto.gx@renesas.com Cc: Pierre-Louis Bossart , Keyon Jie , alsa-devel@alsa-project.org, curtis@malainey.com, linux-kernel@vger.kernel.org, tiwai@suse.com, liam.r.girdwood@linux.intel.com, broonie@kernel.org References: <20200318063022.GA116342@light.dominikbrodowski.net> <41d0b2b5-6014-6fab-b6a2-7a7dbc4fe020@linux.intel.com> <20200318123930.GA2433@light.dominikbrodowski.net> <20200318162029.GA3999@light.dominikbrodowski.net> <20200318192213.GA2987@light.dominikbrodowski.net> <20200318215218.GA2439@light.dominikbrodowski.net> <20200319130049.GA2244@light.dominikbrodowski.net> From: Cezary Rojewski Message-ID: <4eb2859f-d1a9-e99b-28c3-54a9dc6f9d17@intel.com> Date: Thu, 19 Mar 2020 14:17:35 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200319130049.GA2244@light.dominikbrodowski.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-03-19 14:00, Dominik Brodowski wrote: > On Wed, Mar 18, 2020 at 11:20:55PM +0100, Cezary Rojewski wrote: >> >> Thanks for quick reply. Revert of said commit fixes stream==NULL issue for >> me. See if there were any changes in dmesg. >> Will ask technicians to assist me on site tomorrow. > > Have some good news now, namely that a bisect is complete: That pointed to > 1272063a7ee4 ("ASoC: soc-core: care .ignore_suspend for Component suspend"); > therefore I've added Kuninori Morimoto to this e-mail thread. > > Additionally, I have tested mainline (v5.6-rc6+ as of 5076190daded) with > *both* 64df6afa0dab (which you suggested yesterday) and 1272063a7ee4 > reverted. And that works like a charm as well. > > Hope this helps! > > Thanks, > Dominik > To make everyone not miss a bit - I believe we had 2 issues here, even though that one may seem harmless from user perspective: From IPC logs indeed it looks like a redundant (additional) stream initialization has occurred - said redundant stream is destroyed right after it has been created, and only to be recreated yet again.. Can share the logs if required. While hw_params() handled doubled init nicely, _reset and _free did not (during on pcm_close()) -> secondary invokes attempted to RESET and FREE stream despite it being destroyed long ago. With revert of patch I had mentioned, no lines: !!! haswell-pcm-audio haswell-pcm-audio: warning: stream is NULL, no stream to reset, ignore it. !!! haswell-pcm-audio haswell-pcm-audio: warning: stream is NULL, no stream to free, ignore it. should appear. I'll focus now on the commits you found offending during your bisect. Thank you Dominik! Czarek