From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6176724BBE4 for ; Wed, 14 Jan 2026 07:21:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768375314; cv=none; b=IV+rzZbFDAbuxtDPqzAjKt5WsbGCHWeCP5vQkwr0ewb5QSL4J5gacgnoH7c+FDciENOrF8D2G2O4mOrOZHOl7G2g8wyjG4AEXdWUuYUIGFhqlb/eCMsYxO849XxW5By2xaHvkT3Z+w/8pYHIKL6OECeealcAVP7Sx8ua5sMeLWQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768375314; c=relaxed/simple; bh=pin1cn/u9jir+M+excFeD+YAXNJE7hBZaT7EnKEdnQk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CBZmsiGycf9iguXwKYphOBWvh2GdJCOHDCWwVccFeRC+6y0UWwzqSiXq+5cPI8Yv1p80bvCqipJAOpjad1NufKzMlHOqREmVXrEQyQoayv11Ja5jD0ovDVPGyIjkGxoRuag4EckogiibNNdHslK8HpnOL2fHCpRIwHYzdk/qCpc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lvGWSc+M; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RgsNOfN5; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lvGWSc+M"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RgsNOfN5" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60E66hfC2378189 for ; Wed, 14 Jan 2026 07:21:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mGua2V69u9ZPUxAilzeukZAAVkpOgN6IHQHMHMdlgeM=; b=lvGWSc+MdI+XfEAl O0tX2sTXTqZIrLDL8P5OkdFw+MwRsZyDEmsrVgvhr1nLT7F0LjOv8GUeD2+U4jKO Imjo1oMDeFUgeQo/JEQitkGDHQdBWjsZO+eK95RRxNmNaePE6FLlXayJbNI7+fE3 53QM2wRTOsmCcpL+QqP5Zm3SENpt0fK/zkkStwMvuoa0R4VXqITHwdcgrkEjcsRG 1WoCB+AcrCPGOG0uZ41d9jny9bGwSqUgcCB/42d3kEnO1Jf5exxs0puMvbeljbKC CWYwmHTORpuTbe0x1tgAqLbhpcnFoe3A2c8b56eZj13lB2eFIZcM7Aii0EijV5zB e1rNVQ== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bnymsscvf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 14 Jan 2026 07:21:46 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2a0f47c0e60so58075785ad.3 for ; Tue, 13 Jan 2026 23:21:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768375306; x=1768980106; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mGua2V69u9ZPUxAilzeukZAAVkpOgN6IHQHMHMdlgeM=; b=RgsNOfN50vJU9S9JpC9RS/eRczWlNQENsjsGnkHca1C+LxgKHkXAxYvvxbKQ1adap1 zeMZ/4CRCYwbfvrAFS1b4D8Fby4RjW/2IGTeV91uYmEYppT2eIuFZ3geuJ/wtAVtwmwE t5m2DWo7f9Tm3aCmV0+Rm4xaz/JwJzCYSJWiqj1/FGdOUDcWjocUT8faM0d12Ee67uSQ S5Cv6ndhoGzguOJXgn7cITe2SMP3O7Pi8pk2Jh74BeRp7X8xcYCeuZLrfQf67r4LP2d4 J+7O6/Ink4DPzyDUNtUezWI7DqsH3pOrZg1HfPvF/6QS26phFI+Ayc+6Pu5Y74KTN2f2 eKYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768375306; x=1768980106; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mGua2V69u9ZPUxAilzeukZAAVkpOgN6IHQHMHMdlgeM=; b=mNg2Ocl6ehrwJ6d3w1k+5OhG3rQkcrnJlJNHK+qrfeIbh83toW8syVp5N0ueSBFfIq lc/6joji5whEhfJGUW1mttK37YU+OVtbF+MpNu+D/flkeCz0XeYx0Ije5hyKptq5lp8j lKQzXcNTk+tXnji6mBVQ3K3v9gkWRkQGUeadkhLfQA+PWlO1R+NAcEaruWZkrwceqV9H 1YO+iiW3JFOr2l6Yaklj3RZ5hapaxu1xeI7Gj8C8QaTfnPuGwYusb0WWUlWB0ajNTiae NeYHtf5JH119uwGcvLMGS6ROmhdnt/L3j+nJ7EjzpGpPgWhCJB6rcOMHh01JmyAINqFz 9Zgg== X-Forwarded-Encrypted: i=1; AJvYcCUFKl+FIr58U5JhZH8f2lV/z5+hcJ2jkgzlfHn4E4txrNSSrqI95URkrzJHnrSbk04oqsr7MFhyYOcKIk0=@vger.kernel.org X-Gm-Message-State: AOJu0YwwvmB5jaUR5SbnCl4gGa9pPnOj9aB8sCVKwWOzDZ/IPjyaePXf EMGlyBJ3YUp6FfjK0gC8xmrohfsL/hgRarrH+LdDZFRfh6APkhnSluD69Og1UfW3uxP0ymhEQ4H f6+XJirbNxrnSi89iv82nhgxgU9Hpkj9rHErQUDq7mITyve8SSCLgRzh+s56NMIfqC6I= X-Gm-Gg: AY/fxX7JJbDg7ITt4YzRwM7SQz/bAedTpkVyDX3K3ZS2AMzGULL012YaUVNFPRODB/4 4kgqnNgWXOpyvRFqWYQAmJShn1ZAkBUZDH/bmtw07SsmiPbIy4snaqhpaAcTFPOSZbloWH4bi+L nGHfeV51z/TJXIoPhsweDoFsdPRs2GdqV80gRgQsaxQpZQeeeKysYBxvQ5P5VlWMcMP88CoUAmC HfXaPhgG2DthMPKHDtbslpg6PSh+0PcJNw7yidFUoNyO1T0Ugq8F+mBkY1teamUKR16kLkKswK/ f8WoWGB5zP+XMsECGoyedDYEHltBud0l4BmEqq0Hi+0ecsIfFIBSPXONpM+2G2j9PWaupDXEq04 7XHV7yfj55NUXYAlJv3d0WhdsUPkD6T2OZmTf0r0CSQ2R X-Received: by 2002:a17:903:19e8:b0:29d:7b9b:515b with SMTP id d9443c01a7336-2a59bb74387mr12706435ad.20.1768375306037; Tue, 13 Jan 2026 23:21:46 -0800 (PST) X-Received: by 2002:a17:903:19e8:b0:29d:7b9b:515b with SMTP id d9443c01a7336-2a59bb74387mr12706145ad.20.1768375305597; Tue, 13 Jan 2026 23:21:45 -0800 (PST) Received: from [10.206.109.90] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3c48cc3sm220685455ad.39.2026.01.13.23.21.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jan 2026 23:21:45 -0800 (PST) Message-ID: <4eb4818f-115b-d0af-cfc8-109984190f5d@oss.qualcomm.com> Date: Wed, 14 Jan 2026 12:51:38 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 02/11] soc: qcom: ubwc: add helper to get min_acc length Content-Language: en-US To: Dmitry Baryshkov , Bjorn Andersson , Konrad Dybcio , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Akhil P Oommen , Vikash Garodia , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-media@vger.kernel.org, Bryan O'Donoghue References: <20260113-iris-ubwc-v2-0-4346a6ef07a9@oss.qualcomm.com> <20260113-iris-ubwc-v2-2-4346a6ef07a9@oss.qualcomm.com> From: Dikshita Agarwal In-Reply-To: <20260113-iris-ubwc-v2-2-4346a6ef07a9@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE0MDA1NiBTYWx0ZWRfXw/nD7g/VvxiD Y4rDvfa9CXxf6HVcKveAF7zqDKWAsqV/Q3WAFtOhPIDjtD0T0U+LNzYh7OczOCpappVNAj86yU1 HDVOGH/x5dOXf0tyBSP/qIADe8XpYYDbhEV0PVaGnrBkwVw/Uucy+PlkQ9ATHapNDU598JzL+r1 17T/jOIQI6wIjm6Gaf18URPYxr+5af0J3yqAv6W1wIfkKRTur+Gs3sTtsbM0qEq2X7Pkn4bjByy pRhqdZ3D6ra27hgnK5myrSOmnkxq27wyMsNDLSrny5tUfZjiOSMLtU4Yy+9rd5i6iPDAIRKX11F t/6kJ6hM/HT3JuOQ1Wax5WQS6zjxYO8q7WWvDNoOXlHZ16iTyjZkiOTjvIDotWpt8fd58wpmcg0 lgAz8CyWXCSVuzIf9VaFj5a/BpeCJOUZ0WN0HvMjFqPWm5eiBaOttzklX+ljcBm6AHaajSXqFjn IaPHAoq2Hv5/+bQg9/A== X-Proofpoint-GUID: _0_dCuP8luWOblPvyccfEDc3fn5xdK5y X-Proofpoint-ORIG-GUID: _0_dCuP8luWOblPvyccfEDc3fn5xdK5y X-Authority-Analysis: v=2.4 cv=RuDI7SmK c=1 sm=1 tr=0 ts=6967440a cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=o9KUHpD5kIPiLnKsU4kA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-14_02,2026-01-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 phishscore=0 adultscore=0 priorityscore=1501 spamscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601140056 On 1/13/2026 10:27 PM, Dmitry Baryshkov wrote: > MDSS and GPU drivers use different approaches to get min_acc length. > Add helper function that can be used by all the drivers. > > The helper reflects our current best guess, it blindly copies the > approach adopted by the MDSS drivers and it matches current values > selected by the GPU driver. > > Reviewed-by: Bryan O'Donoghue > Signed-off-by: Dmitry Baryshkov > --- > include/linux/soc/qcom/ubwc.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/include/linux/soc/qcom/ubwc.h b/include/linux/soc/qcom/ubwc.h > index f052e241736c..5bdeca18d54d 100644 > --- a/include/linux/soc/qcom/ubwc.h > +++ b/include/linux/soc/qcom/ubwc.h > @@ -74,4 +74,14 @@ static inline bool qcom_ubwc_get_ubwc_mode(const struct qcom_ubwc_cfg_data *cfg) > return ret; > } > > +/* > + * This is the best guess, based on the MDSS driver, which worked so far. > + */ > +static inline bool qcom_ubwc_min_acc_length_64b(const struct qcom_ubwc_cfg_data *cfg) > +{ > + return cfg->ubwc_enc_version == UBWC_1_0 && > + (cfg->ubwc_dec_version == UBWC_2_0 || > + cfg->ubwc_dec_version == UBWC_3_0); > +} > + > #endif /* __QCOM_UBWC_H__ */ > Based on what I could check from video side, above looks correct. Reviewed-by: Dikshita Agarwal Thanks, Dikshita