From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793914068; b=YPLgO2z8OhIdu8HTGovywM+2r17NhzhJxC4DKk7yQPOI7wVB1oY9xMOqEtoLzNlP4/4D OboPRQuuAH/L7675uQVVvN2QL45aTen1EgbLsXfG4SRUHFq2v5q16Yq8DEcIn5x6wG3mD v/n+qRka/D8BXUvzWAuo+7ZyP0t03cn3m+c2zHK/u13qVM0Ku+2cZmRSJL+ZB4da0+M1V j6VfoT6E7scdFA9pHAPV2FNtt65MgYbhPUHc24c87PovYMQotrz5iSLYVdoLOvmvVvy0a Y4Ni5mwnQnAQsq27YSHHYr+JcggOm9mfkg/OfFpmQfiZ/ZyHkUk6UCJe2nKAgh3qq8A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793914068; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-Proofpoint-Spam-Info:X-Proofpoint-GUID: X-Proofpoint-Spam-Details-Enc:X-Authority-Analysis: X-Proofpoint-ORIG-GUID:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=ZWnXimVpeQxb/+8pu9gZLHGbBkrdMiXRvBKJrkwrSno=; b=QG2ffpSyK7yfiEJVuUiLP7KsJwSfPwVncx2y+uEOLj25yrt1pMjuqWxRmaU3gfBpdXXs NwZxo5BcWB7sd+P9gIytQG1r7a4pzxjMLdOXnksjpno53WtBt3qE6Pn1ggWuAuoH8UNOf JoAZa+ZQyII8pGsKJT6raW7deXpZAzzF5ZTYAcOWwflhxoajVA8Vfxkty0zFo4BYHJeuX 3yHMnnAaQi10WS3bl0kUatCQiBZtb6ZO0PxA1DkacUUPlQDeEYOKkxfDUHMctE59LCf0S nwwYIwLL7pBeOlFx7ZOTUjq/+QMivpW6xGj3jszlI2EXpPMEu6JWRwMQAYctNr5Gktg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=CVsdHCQv; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=C4qq4Dzd; arc=none smtp.remote-ip=205.220.180.131 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E75E6606A32C for ; Thu, 5 Nov 2026 21:27:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org E75E6606A32C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=CVsdHCQv; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=C4qq4Dzd Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6A5L6HQT844813 for ; Thu, 5 Nov 2026 21:27:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ZWnXimVpeQxb/+8pu9gZLHGbBkrdMiXRvBKJrkwrSno=; b=CVsdHCQv4Yh9N6q8 riZuA1weyRqQjS9kyvUPvnkHayKLNCqxz7VB6mh/XKWqSc14Iv+AQlxsM3ajCWa/ o/RD6PMzixrN8SlognVAeWuvk4vTpOqvnBz+UctsBBtiDfgIyjbN+L9xj0ZMVLff NmYZRoqpwB81nsLgg+CwO/gWVXaoLolsqGLqG+KhJWWDs5O+cFLpzMu3GkbmMw0/ bNB1gSqCNDqa4DMsMDhfz5Pmd7OpQ8ZV0Eoj8rsXLduAs851Jb3lfAVDNKO8bRYg JArPJou9AKWvopAQZ3soVW2flwjKR7KoEOhH8B86jG+pHl+eXVxBUX0cuezVOssV 5QWhrA== Received: from mail-dy1-f198.google.com (mail-dy1-f198.google.com [74.125.82.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hryvv0h6x-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 05 Nov 2026 21:27:45 +0000 (GMT) Received: by mail-dy1-f198.google.com with SMTP id 5a478bee46e88-3552883bd19so4468302eec.1 for ; Thu, 05 Nov 2026 13:27:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1793914065; x=1794518865; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ZWnXimVpeQxb/+8pu9gZLHGbBkrdMiXRvBKJrkwrSno=; b=C4qq4DzdeaEamJtXDPIDiWnU8LKLiHM50QDO4fm5ulC1h+UIljnB9n778zdWfD/ugl EBEpsXA62K9R/H8ES6LQVBNX8kFP1AdU7D88X+sLs84BfqNEw2kRtAtg3i7CHDfEA9q1 itGH1Too3rF6jznqtQZFJgLeGc1LglcWDq+6BO8RL85KVqBgYMZ+xbKaLeQOWIhGMNLl Dy4dbU197VPqovH745/yLhEvOwPKZFUMukDq4cYhNfmkS73NMYyf2YvEyIbm0a6kCshq JYkTC1kHkSW0q8JuMw6lzOmiW4+IC46tMIfprDvp9C5SS/vYcoqBNSpMxr7WM4hDmk4V Uzyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793914065; x=1794518865; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ZWnXimVpeQxb/+8pu9gZLHGbBkrdMiXRvBKJrkwrSno=; b=D80iJGo4yMGpzz9z+9sc+ishi7cgspKdfQYs9tUTTmb7YCsA3I98SAbpGE+Vv9PQHS rGIpZ2u+67jEYWbQfvGA7Wegw5OjO1PSmls/B8T2MlX0eeJinhkMnnPbgsJagb0Uy6YM pOeI1DHuz+nnJj2uxssyut1NCR4qx6qa4bVY3xXAMBvrqExNNDv4LP6DrFZQ5KWbFLWV TPaQoLxbXnfxVsGRuOamJ0GNG02VHq7c3XkWwZ0fRES+HAlhHK5EEi3nfUw8UfwmfI/d l7Dt0n7SKuLOvVX4NE+oX8t7Cc/hCSlUk7r0LQyR/jfuk38K6RNRgQdzBR1ldW/jKIYF LcdQ== X-Forwarded-Encrypted: i=1; AKwUvBxG4SFTPbsS0nzFwN18ZTcInLMXGE0Q4UQflWXfrr4kANXe9q6h+e1PZ5qkUzFdft87o+EgpE1a838iN8Q=@vger.kernel.org X-Gm-Message-State: APuU4Z/pQM5EAj9CgGCqN2o67RwVsx8X/XKp/WvzXgqG5esC2U0tLE+h DDEDhKD0TLjS2q3X7eUzhoJT/UTKoFD7ulREHcsO/YbmFdTeM7hP9qf8U/fFvpWuyT5BfZXxedg 7YUWO0+1Z6G29u65pG3jPgK5fIyemGj7421WUKnnqSSdCRjgnBvdxE70j8kfseEFqkWo= X-Gm-Gg: AYBFou1S7HV7TJBV16hebBOucM+pprh4UgqWg1Azp+rCz6+tUK/MzTNcWRBDQA4g0t3 6K9ryMeLOmdPP7oQHCImAeMPPGysHQqsUVjO3Wjg17PhH+AZoJTglHEUlQeQxsqIALhp4BEi7YH 9Sg6DmmjLFvVv9WQVYTri5ukwP5EuPWUMZHck0NQzHBZDD4A1qYa3db1aMgzykxHRFZibxncRtl C0t22aAbvGhIAJ59p+p5TQfNMCr37Q4Fo0u1W6xrC2Po1wA7hp52/ZZUisLlPsl4ityU3bip7KQ qjt1K/qGslbZCM8WMGTqsrP2tm/lXWF7lJag67cBa7WwfoW/Pl7PTLprmUIzXlCCeEAk2J2GoCu 8GSILYE1zLHP7lc3DyHLlqEt+MpiJ6mRGun5bY6O5mvzPVSvzBGWuMeeoj2huIzeDX4tLfjY= X-Received: by 2002:a05:7300:8245:b0:36d:25e:1961 with SMTP id 5a478bee46e88-36f76c16096mr455685eec.22.1793914064611; Thu, 05 Nov 2026 13:27:44 -0800 (PST) X-Received: by 2002:a05:7300:8245:b0:36d:25e:1961 with SMTP id 5a478bee46e88-36f76c16096mr455637eec.22.1793914063996; Thu, 05 Nov 2026 13:27:43 -0800 (PST) Received: from [192.168.1.9] ([106.222.231.155]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-36f7369c69fsm912457eec.6.2026.11.05.13.27.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Nov 2026 13:27:43 -0800 (PST) Message-ID: <4eb8aa1d-08ff-43a0-ad85-85005b0bdf33@oss.qualcomm.com> Date: Fri, 6 Nov 2026 02:57:37 +0530 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 0/6] drm/msm: Decouple IFPC disable and sysprof To: Rob Clark , dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Anna Maniscalco , Abhinav Kumar , David Airlie , Dmitry Baryshkov , Jessica Zhang , Konrad Dybcio , open list , Marijn Suijten , Sean Paul , Simona Vetter References: <20261105164158.23263-1-robin.clark@oss.qualcomm.com> Content-Language: en-US From: Akhil P Oommen In-Reply-To: <20261105164158.23263-1-robin.clark@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYxMTA1MDA4NSBTYWx0ZWRfX8oGw6TDxE3K9 AgDBKnTuYknJv1fZ/fG/N6cACmeFhH9Eg8rRGWfI8mGhmnzaxOmojUfMIUY2peCMyA/HGFq2y0M Z9luMYgMHO7Q1ZkV6KZ3R6URpvLjKqk= X-Proofpoint-GUID: B1kh1HiXuTvrLnQHM2fi9P4mdYlAmJvU X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMTA1MDA4NSBTYWx0ZWRfX/Q0CzDkI93iJ zsbBlAORjwSObaqYfBQFdsu0KhHN9r8B53Hp+6DLxoaix5v8oqVuewaC1JcANQ1J8jYF1jgW/kh Bz0yDJ0G13s//FJlCArwVROkDUDO8LjLt+AAyD+G0oZ1/XdweArGdeJxjVf8Dn0S3Df8youO3cJ qln65Ns3/iekmusfnAHWNUw7rLjjYKmgykteCXIwygCPPr5Ard7wr5BMlq9moig3oN4/ITX0f8t YM3tbhMyfB/xRbDXFpcSxVT9MB0r/IDNJ740cvR6tltanjsv+9E2WLezjLzC/q5mxEJISxUymVw 4n9gRxhWqF1QDybFcsCG64qDmkuO9yeMIZfrXCE68me8wSutY9PvVIvCoy06rIEoC0b1nN8ZtP0 WI6AZFsY7jlQ8IDSDu1OEBoOsVizFfRAtYD3ON6cAMvk1u01mav7AjFY+tjMtgc3y8VP9UIYmmx xm+/DxdNjEDb14EzaiA== X-Authority-Analysis: v=2.4 cv=dKUzC+Zb c=1 sm=1 tr=0 ts=6aecf4d1 cx=c_pps a=wEP8DlPgTf/vqF+yE6f9lg==:117 a=Hj0ah+TxS5FywmoD0uLh0Q==:17 a=IkcTkHD0fZMA:10 a=zJRp6_cAMcgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=e5mUnYsNAAAA:8 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=aFxOFIhO4BgZX6uqFnUA:9 a=QEXdDO2ut3YA:10 a=bBxd6f-gb0O0v-kibOvt:22 a=Vxmtnl_E_bksehYqCbjh:22 X-Proofpoint-ORIG-GUID: B1kh1HiXuTvrLnQHM2fi9P4mdYlAmJvU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-11-05_06,2026-11-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 adultscore=0 priorityscore=1501 spamscore=0 clxscore=1015 malwarescore=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610300000 definitions=main-2611050085 On 11/5/2026 10:11 PM, Rob Clark wrote: > Convert IFPC-disable into it's own refcnt so that multiple threads can > request IFPC to be disabled without stomping on each other. > > Extracted out of gen8 GPU state capture series[1], as other than fixing > a missing IFPC disable in debugfs state capture path, it is unrelated. > > [1] https://patchwork.freedesktop.org/series/176505/ > > v6: > - Fix potential runpm ref leak in sel_worker() > - Acquire gpu->lock before runpm > - Fix unmatched OOB clear in a6xx_gmu_shutdown() > - Link to v5: https://lore.kernel.org/all/20261104175931.28475-1-robin.clark@oss.qualcomm.com/ > > v5: > - Skip unneeded msm_context_set_sysprof() call in msm_postclose() > - Fix potential sel_worker deadlock > - Revert back to original gpu-lock/runpm ordering > - Link to v4: https://lore.kernel.org/all/20261103231850.17493-1-robin.clark@oss.qualcomm.com/ > > v4: > - Don't clear GMU_STATUS_OOB_PERF_SET in suspend path. Restore it in > hw_init() > - Don't require gpu->lock in a6xx_gmu_ifpc_update(), but instead warn > if needs_hw_init > - Move perfcntr resume to after hw_init() > - Link to v3: https://lore.kernel.org/all/20261103184713.29664-1-robin.clark@oss.qualcomm.com > > v3: > - Rework IFPC disable harder to play nicer with hw_init(). If we > need_hw_init, simply update gmu->status mask and let hw_init() > restore the OOB request in a sequence that won't anger the fw. > - Link to v2: https://lore.kernel.org/all/20261102190010.720443-1-robin.clark@oss.qualcomm.com/ > > v2: > - Fix double acquire of gmu->lock > - Fix missing a8xx hw_init() path > - Link to v1: https://lore.kernel.org/all/20261101174631.23637-1-robin.clark@oss.qualcomm.com/ > > > Rob Clark (6): > drm/msm: Hold runpm ref in set_sysprof() > drm/msm: Resume perfcntrs after hw_init > drm/msm: Rework IFPC disable > drm/msm: Add cleanup help for disabling IFPC > drm/msm/debugfs: Use cleanup.h for gpu state dump > drm/msm: Inhibit IFPC for state snapshot > > drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 27 +++++++---------- > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 9 +++--- > drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 2 +- > drivers/gpu/drm/msm/adreno/a8xx_gpu.c | 3 +- > drivers/gpu/drm/msm/adreno/adreno_device.c | 5 +--- > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 1 - > drivers/gpu/drm/msm/msm_debugfs.c | 32 +++++++++----------- > drivers/gpu/drm/msm/msm_drv.c | 2 +- > drivers/gpu/drm/msm/msm_gpu.c | 5 +++- > drivers/gpu/drm/msm/msm_gpu.h | 34 ++++++++++++++++++++-- > drivers/gpu/drm/msm/msm_perfcntr.c | 17 ++++++----- > drivers/gpu/drm/msm/msm_submitqueue.c | 20 +++++++++---- > 12 files changed, 94 insertions(+), 63 deletions(-) For the series: Reviewed-by: Akhil P Oommen -Akhil.>