From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751200AbdE2Qff (ORCPT ); Mon, 29 May 2017 12:35:35 -0400 Received: from mail-wm0-f47.google.com ([74.125.82.47]:38302 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750951AbdE2Qfd (ORCPT ); Mon, 29 May 2017 12:35:33 -0400 Subject: Re: [PATCH 3/3] pinctrl: bcm: clean up modular vs. non-modular distinctions To: Linus Walleij , Paul Gortmaker References: <20170522205648.23545-1-paul.gortmaker@windriver.com> <20170522205648.23545-4-paul.gortmaker@windriver.com> Cc: "linux-kernel@vger.kernel.org" , Eric Anholt , Florian Fainelli , Jon Mason , Ray Jui , Scott Branden , Stefan Wahren , Sherman Yin , bcm-kernel-feedback-list , "linux-gpio@vger.kernel.org" , linux-rpi-kernel From: Scott Branden Message-ID: <4eb8be51-8cf9-31b9-c6e6-52fdb9cd202d@broadcom.com> Date: Mon, 29 May 2017 09:35:27 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Linus, On 17-05-29 01:31 AM, Linus Walleij wrote: > On Mon, May 22, 2017 at 10:56 PM, Paul Gortmaker > wrote: > >> Fixups here tend to be more of a conglomerate of some of the other >> repeated/systematic ones we've seen in the earlier pinctrl cleanups. >> >> We remove module.h from code that isn't doing anything modular at >> all; if they have __init sections, then replace it with init.h >> >> One driver has a .remove that would be dispatched on module_exit, >> and as that code is essentially orphaned, so we remove it. In case >> anyone was previously doing the (pointless) unbind to get to that >> function, we disable unbind for this one driver as well. >> >> A couple bool drivers (hence non-modular) are converted over to >> to builtin_platform_driver(). >> >> Since module_platform_driver() uses the same init level priority as >> builtin_platform_driver() the init ordering remains unchanged with >> this commit. >> >> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. >> >> We also delete the MODULE_LICENSE tag etc. since all that information >> was (or is now) contained at the top of the file in the comments. >> >> Cc: Eric Anholt >> Cc: Florian Fainelli >> Cc: Jon Mason >> Cc: Linus Walleij >> Cc: Ray Jui >> Cc: Scott Branden >> Cc: Stefan Wahren >> Cc: Sherman Yin >> Cc: bcm-kernel-feedback-list@broadcom.com >> Cc: linux-gpio@vger.kernel.org >> Cc: linux-rpi-kernel@lists.infradead.org >> Signed-off-by: Paul Gortmaker > Patch applied with Stefan Wahren's Tested-by tag. > > I can't take header standardization into account, header files are not > ABI, further see > Documentation/process/stable-api-nonsense.rst It is a simple ask to place the new information in a new comment after the legal header. An aim at consistency helps reduce confusion (internal and external) of what license header template to apply to files. Modifying these headers and placing information in the middle of them does not help in this effort. > Yours, > Linus Walleij Regards, Scott