From: Tom Lendacky <thomas.lendacky@amd.com>
To: Sean Christopherson <seanjc@google.com>,
wuzongyong <wuzongyo@mail.ustc.edu.cn>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
x86@kernel.org, linux-coco@lists.linux.dev
Subject: Re: [Question] int3 instruction generates a #UD in SEV VM
Date: Mon, 31 Jul 2023 10:03:34 -0500 [thread overview]
Message-ID: <4ebb3e20-a043-8ad3-ef6c-f64c2443412c@amd.com> (raw)
In-Reply-To: <ZMfFaF2M6Vrh/QdW@google.com>
On 7/31/23 09:30, Sean Christopherson wrote:
> On Sat, Jul 29, 2023, wuzongyong wrote:
>> Hi,
>> I am writing a firmware in Rust to support SEV based on project td-shim[1].
>> But when I create a SEV VM (just SEV, no SEV-ES and no SEV-SNP) with the firmware,
>> the linux kernel crashed because the int3 instruction in int3_selftest() cause a
>> #UD.
>
> ...
>
>> BTW, if a create a normal VM without SEV by qemu & OVMF, the int3 instruction always generates a
>> #BP.
>> So I am confused now about the behaviour of int3 instruction, could anyone help to explain the behaviour?
>> Any suggestion is appreciated!
>
> Have you tried my suggestions from the other thread[*]?
>
> : > > I'm curious how this happend. I cannot find any condition that would
> : > > cause the int3 instruction generate a #UD according to the AMD's spec.
> :
> : One possibility is that the value from memory that gets executed diverges from the
> : value that is read out be the #UD handler, e.g. due to patching (doesn't seem to
> : be the case in this test), stale cache/tlb entries, etc.
> :
> : > > BTW, it worked nomarlly with qemu and ovmf.
> : >
> : > Does this happen every time you boot the guest with your firmware? What
> : > processor are you running on?
> :
> : And have you ruled out KVM as the culprit? I.e. verified that KVM is NOT injecting
> : a #UD. That obviously shouldn't happen, but it should be easy to check via KVM
> : tracepoints.
I have a feeling that KVM is injecting the #UD, but it will take
instrumenting KVM to see which path the #UD is being injected from.
Wu Zongyo, can you add some instrumentation to figure that out if the
trace points towards KVM injecting the #UD?
Thanks,
Tom
>
> [*] https://lore.kernel.org/all/ZMFd5kkehlkIfnBA@google.com
next prev parent reply other threads:[~2023-07-31 15:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-29 3:15 wuzongyong
2023-07-31 14:30 ` Sean Christopherson
2023-07-31 15:03 ` Tom Lendacky [this message]
2023-07-31 15:45 ` wuzongyong
2023-08-02 11:56 ` Wu Zongyo
2023-08-02 14:01 ` Sean Christopherson
2023-08-02 14:25 ` Tom Lendacky
2023-08-02 14:33 ` Tom Lendacky
2023-08-02 15:04 ` Sean Christopherson
2023-08-02 15:26 ` Tom Lendacky
2023-08-02 15:35 ` Sean Christopherson
2023-08-02 20:03 ` Tom Lendacky
2023-08-03 3:27 ` Wu Zongyo
2023-08-03 8:44 ` Wu Zongyo
2023-08-03 14:34 ` Sean Christopherson
2023-08-04 2:33 ` Wu Zongyo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ebb3e20-a043-8ad3-ef6c-f64c2443412c@amd.com \
--to=thomas.lendacky@amd.com \
--cc=kvm@vger.kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=seanjc@google.com \
--cc=wuzongyo@mail.ustc.edu.cn \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®