mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dinh Nguyen <dinguyen@kernel.org>
To: tze.yee.ng@altera.com, linux-kernel@vger.kernel.org
Cc: Adrian Ng Ho Yin <adrian.ho.yin.ng@altera.com>,
	Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>
Subject: Re: [PATCH v2 0/3] firmware: stratix10-rsu: expose QSPI flash size and erase size from firmware
Date: Tue, 19 May 2026 07:13:53 -0500	[thread overview]
Message-ID: <4ebc5633-a44c-4dbb-9407-23c48f96c507@kernel.org> (raw)
In-Reply-To: <cover.1778807839.git.tze.yee.ng@altera.com>

Hi Tze Yee,

On 5/14/26 21:11, tze.yee.ng@altera.com wrote:
> From: Tze Yee Ng <tze.yee.ng@altera.com>
> 
> This series lets user space read per-device QSPI flash size and erase
> size for the Intel Stratix 10 RSU driver, using the existing service
> layer SMC path.
> 
> Patch 1 documents the new sysfs attributes (size0-size3 and
> erase_size0-erase_size3).
> 
> Patch 2 implements COMMAND_RSU_GET_DEVICE_INFO in the RSU and service
> drivers, caches up to four devices in the driver, and adds the sysfs
> files.
> 
> Patch 3 fixes probe/remove teardown after the async client is registered:
> remove the async client before freeing the SVC channel so async state
> is not leaked. It also corrects probe return values on the affected
> error paths.
> 
> Changes in v2:
> - No code changes in all patches, only documentation updates to fix commit
>   title and description in Patch 3.
> 
> Tze Yee Ng (3):
>    Documentation: ABI: add stratix10-rsu QSPI size and erase_size sysfs
>    firmware: stratix10-rsu: Add flash device info retrieval via SMC
>    firmware: stratix10-rsu: remove async client before freeing channel on
>      probe errors
> 
>   .../sysfs-devices-platform-stratix10-rsu      |  58 +++++
>   drivers/firmware/stratix10-rsu.c              | 210 +++++++++++++++++-
>   drivers/firmware/stratix10-svc.c              |  94 +++++++-
>   include/linux/firmware/intel/stratix10-smc.h  |  25 ++-
>   .../firmware/intel/stratix10-svc-client.h     |  12 +-
>   5 files changed, 382 insertions(+), 17 deletions(-)
> 

I've applied the first 2 patches in this series, but for patch 3/3, 
please make the following update and re-send:

- You have marked a patch with a "Fixes:" tag for a commit that is in an
   older released kernel, yet you do not have a cc: stable line in the
   signed-off-by area at all, which means that the patch will not be
   applied to any older kernel releases.  To properly fix this, please
   follow the documented rules in the
   Documentation/process/stable-kernel-rules.rst file for how to resolve
   this.

And I think for patch 3, it might be a :

Cc: stable@vger.kernel.org # v6.18+,

but please double check.

Thanks,
Dinh



  parent reply	other threads:[~2026-05-19 12:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-15  2:11 tze.yee.ng
2026-05-15  2:11 ` [PATCH v2 1/3] Documentation: ABI: add stratix10-rsu QSPI size and erase_size sysfs tze.yee.ng
2026-05-15  2:11 ` [PATCH v2 2/3] firmware: stratix10-rsu: Add flash device info retrieval via SMC tze.yee.ng
2026-05-15  2:11 ` [PATCH v2 3/3] firmware: stratix10-rsu: remove async client before freeing channel on probe errors tze.yee.ng
2026-05-19 12:13 ` Dinh Nguyen [this message]
2026-05-20  3:58   ` [PATCH v2 0/3] firmware: stratix10-rsu: expose QSPI flash size and erase size from firmware NG, TZE YEE

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ebc5633-a44c-4dbb-9407-23c48f96c507@kernel.org \
    --to=dinguyen@kernel.org \
    --cc=adrian.ho.yin.ng@altera.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=muhammad.nazim.amirul.nazle.asmade@altera.com \
    --cc=tze.yee.ng@altera.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®