mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Yupeng Li <liyupeng@zbhlos.com>,
	chenhuacai@kernel.org, jiaxun.yang@flygoat.com,
	tsbogend@alpha.franken.de, jdelvare@suse.com
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-hwmon@vger.kernel.org, caizp2008@163.com
Subject: Re: [PATCH 1/1] MIPS: Loongson-3: fix compile mips cpu_hwmon as module build error.
Date: Tue, 7 Jun 2022 18:41:29 -0700	[thread overview]
Message-ID: <4ebf3fb3-47c8-b4b4-e9b2-630e3f540316@roeck-us.net> (raw)
In-Reply-To: <20220608011229.2056016-1-liyupeng@zbhlos.com>

On 6/7/22 18:12, Yupeng Li wrote:
>    set cpu_hwmon as a module build with loongson_sysconf, loongson_chiptemp
>    undefined error,fix cpu_hwmon compile options to be bool.Some kernel
>    compilation error information is as follows:
> 
>    Checking missing-syscalls for N32
>    CALL    scripts/checksyscalls.sh
>    Checking missing-syscalls for O32
>    CALL    scripts/checksyscalls.sh
>    CALL    scripts/checksyscalls.sh
>    CHK     include/generated/compile.h
>    CC [M]  drivers/platform/mips/cpu_hwmon.o
>    Building modules, stage 2.
>    MODPOST 200 modules
> ERROR: "loongson_sysconf" [drivers/platform/mips/cpu_hwmon.ko] undefined!
> ERROR: "loongson_chiptemp" [drivers/platform/mips/cpu_hwmon.ko] undefined!
> make[1]: *** [scripts/Makefile.modpost:92:__modpost] 错误 1
> make: *** [Makefile:1261:modules] 错误 2
> 
> Signed-off-by: Yupeng Li <liyupeng@zbhlos.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   drivers/platform/mips/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/mips/Kconfig b/drivers/platform/mips/Kconfig
> index d421e1482395..6b51ad01f791 100644
> --- a/drivers/platform/mips/Kconfig
> +++ b/drivers/platform/mips/Kconfig
> @@ -17,7 +17,7 @@ menuconfig MIPS_PLATFORM_DEVICES
>   if MIPS_PLATFORM_DEVICES
>   
>   config CPU_HWMON
> -	tristate "Loongson-3 CPU HWMon Driver"
> +	bool "Loongson-3 CPU HWMon Driver"
>   	depends on MACH_LOONGSON64
>   	select HWMON
>   	default y


  reply	other threads:[~2022-06-08  4:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-08  1:12 Yupeng Li
2022-06-08  1:41 ` Guenter Roeck [this message]
2022-06-08  4:11   ` Huacai Chen
2022-06-09 20:25 ` Thomas Bogendoerfer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ebf3fb3-47c8-b4b4-e9b2-630e3f540316@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=caizp2008@163.com \
    --cc=chenhuacai@kernel.org \
    --cc=jdelvare@suse.com \
    --cc=jiaxun.yang@flygoat.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=liyupeng@zbhlos.com \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®