From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757368AbbEVPIv (ORCPT ); Fri, 22 May 2015 11:08:51 -0400 Received: from mta01.ornl.gov ([128.219.177.14]:57757 "EHLO mta01.ornl.gov" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756048AbbEVPIr convert rfc822-to-8bit (ORCPT ); Fri, 22 May 2015 11:08:47 -0400 X-SG: RELAYLIST X-IronPort-AV: E=Sophos;i="5.13,476,1427774400"; d="scan'208";a="103469663" From: "Simmons, James A." To: "'Dan Carpenter'" , James Simmons CC: "devel@driverdev.osuosl.org" , James Simmons , James Simmons , Greg Kroah-Hartman , Linux Kernel Mailing List , Oleg Drokin , "HPDD-discuss@ml01.01.org" , "lustre-devel@lists.lustre.org" Subject: RE: [lustre-devel] [PATCH 1/3] staging:lustre: remove tcpip abstraction from libcfs Thread-Topic: [lustre-devel] [PATCH 1/3] staging:lustre: remove tcpip abstraction from libcfs Thread-Index: AQHQlIDDz9SUbhsp00+k1OeO1fjxG52IF/wQ Date: Fri, 22 May 2015 15:08:44 +0000 Message-ID: <4ebf8ca4e2dd466c8ff68291b6670515@EXCHCS32.ornl.gov> References: <1432248378-28912-2-git-send-email-jsimmons@infradead.org> <20150522111536.GA19434@mwanda> In-Reply-To: <20150522111536.GA19434@mwanda> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [128.219.12.132] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >This patch does a lot of stuff all at once and it is hard to review. It >could easily be broken into patches which are easy to review. I have more very large patches. With breaking them up that means you are going to see hundreds of patches coming from me. >Ok in this next section we move functions around and rename them but >also introduce some bad changes in the new function. Thanks for pointing out these bugs. We are still carrying these bugs in the OpenSFS branch. Once you approve these changes I will sync up lib-socket.c in the OpenSFS branch. P.S Does the 3rd patch look okay to you?