mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: "Zhang Rui" <rui.zhang@intel.com>, "Rafał Miłecki" <rafal@milecki.pl>
Cc: Markus Mayer <code@mmayer.net>,
	Eduardo Valentin <edubezval@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Doug Berger <opendmb@gmail.com>,
	Brian Norris <computersforpeace@gmail.com>,
	Gregory Fong <gregory.0xf0@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>, Arnd Bergmann <arnd@arndb.de>,
	Olof Johansson <olof@lixom.net>,
	Broadcom Kernel List <bcm-kernel-feedback-list@broadcom.com>,
	Power Management List <linux-pm@vger.kernel.org>,
	Device Tree List <devicetree@vger.kernel.org>,
	ARM Kernel List <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Markus Mayer <mmayer@broadcom.com>
Subject: Re: [PATCH v4 2/4] thermal: add brcmstb AVS TMON driver
Date: Sun, 24 Sep 2017 14:11:25 -0700	[thread overview]
Message-ID: <4ec0715e-fcd7-3aec-3589-96426575c373@gmail.com> (raw)
In-Reply-To: <1502779721.2591.4.camel@intel.com>

Le 08/14/17 à 23:48, Zhang Rui a écrit :
> On Tue, 2017-08-15 at 08:42 +0200, Rafał Miłecki wrote:
>> On 2017-08-15 08:08, Zhang Rui wrote:
>>>
>>>>
>>>> diff --git a/drivers/thermal/broadcom/Kconfig
>>>> b/drivers/thermal/broadcom/Kconfig
>>>> index 42c098e..c106a15 100644
>>>> --- a/drivers/thermal/broadcom/Kconfig
>>>> +++ b/drivers/thermal/broadcom/Kconfig
>>>> @@ -6,6 +6,13 @@ config BCM2835_THERMAL
>>>>  	help
>>>>  	  Support for thermal sensors on Broadcom bcm2835 SoCs.
>>>>  
>>>> +config BRCMSTB_THERMAL
>>>> +	tristate "Broadcom STB AVS TMON thermal driver"
>>>> +	depends on ARCH_BRCMSTB || COMPILE_TEST
>>>> +	help
>>>> +	  Enable this driver if you have a Broadcom STB SoC and
>>>> would like
>>>> +	  thermal framework support.
>>>> +
>>> I don't understand why I got the following checkpatch warning
>>>
>>> WARNING: please write a paragraph that describes the config symbol
>>> fully
>>> #73: FILE: drivers/thermal/broadcom/Kconfig:9:
>>> +config BRCMSTB_THERMAL
>>>
>>> I didn't see this for other Kconfig changes.
>> It's because your help message is only 2 lines long (instead of 3).
>>
>> Some (many?) maintainers aren't pedantic about that, a common sense 
>> should
>> be applied ;)
> 
> thanks for explaining.
> Patch 1 and 2 queued for next merge window.

Humm, I don't see this driver in your latest 4.14 pull request to Linus,
so what happened here exactly? Can we expect this driver to be submitted
for 4.14 or we just happened to have missed this window now?
-- 
Florian

  reply	other threads:[~2017-09-24 21:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-09 22:02 [PATCH v4 0/4] " Markus Mayer
2017-08-09 22:02 ` [PATCH v4 1/4] Documentation: devicetree: add binding for Broadcom STB AVS TMON Markus Mayer
2017-08-17 15:10   ` Rob Herring
2017-08-09 22:02 ` [PATCH v4 2/4] thermal: add brcmstb AVS TMON driver Markus Mayer
2017-08-15  6:08   ` Zhang Rui
2017-08-15  6:42     ` Rafał Miłecki
2017-08-15  6:48       ` Zhang Rui
2017-09-24 21:11         ` Florian Fainelli [this message]
2017-09-26  3:02           ` Zhang, Rui
2017-09-26  4:13             ` Florian Fainelli
2017-09-26  6:17               ` Zhang, Rui
2017-09-26 21:36                 ` Markus Mayer
2017-08-09 22:02 ` [PATCH v4 3/4] ARM: multi_v7_defconfig: add CONFIG_BRCMSTB_THERMAL Markus Mayer
2017-08-15 17:23   ` Florian Fainelli
2017-08-09 22:02 ` [PATCH v4 4/4] arm64: defconfig: " Markus Mayer
2017-08-15 17:24   ` Florian Fainelli
2017-08-11  5:35 ` [PATCH v4 0/4] thermal: add brcmstb AVS TMON driver Zhang Rui
2017-08-13  4:57   ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ec0715e-fcd7-3aec-3589-96426575c373@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=arnd@arndb.de \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=catalin.marinas@arm.com \
    --cc=code@mmayer.net \
    --cc=computersforpeace@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=edubezval@gmail.com \
    --cc=gregory.0xf0@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=mmayer@broadcom.com \
    --cc=olof@lixom.net \
    --cc=opendmb@gmail.com \
    --cc=rafal@milecki.pl \
    --cc=robh+dt@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®