From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sebastian Raase <basti@sraa.de>
Cc: Sebastian Raase <linux@sraa.de>,
marijn.suijten@somainline.org,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sdm630-nile: add pinctrl for camera key
Date: Fri, 15 Mar 2024 09:33:25 +0100 [thread overview]
Message-ID: <4ec0fae0-afcd-4b64-bf26-21a7972a5d0f@linaro.org> (raw)
In-Reply-To: <20240315002338.3fe1dcfc@probook>
On 15/03/2024 00:23, Sebastian Raase wrote:
>>> gpio-keys {
>>> compatible = "gpio-keys";
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&gpio_keys_default>;
>>
>> A nit: Please reverse the order: pinctrl-0 then names
>
> All existing pinctrl definitions use pinctrl-names first, so I followed the existing file. Is this still okay?
No, not all. If you are sending v2, why you cannot fix this in new code?
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-03-15 8:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 20:00 Sebastian Raase
2024-03-14 20:37 ` Krzysztof Kozlowski
2024-03-14 23:23 ` Sebastian Raase
2024-03-15 8:33 ` Krzysztof Kozlowski [this message]
2024-03-14 23:20 ` [PATCH v2] " Sebastian Raase
2024-03-14 23:49 ` Konrad Dybcio
2024-03-15 8:32 ` Krzysztof Kozlowski
2024-03-15 9:04 ` Sebastian Raase
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ec0fae0-afcd-4b64-bf26-21a7972a5d0f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andersson@kernel.org \
--cc=basti@sraa.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@sraa.de \
--cc=marijn.suijten@somainline.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®