mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sharath Srinivasan <sharath.srinivasan@oracle.com>
To: Leon Romanovsky <leon@kernel.org>, Jason Gunthorpe <jgg@ziepe.ca>
Cc: Parav Pandit <parav@nvidia.com>,
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH rdma-next] RDMA/core: release devices_rwsem when calling device_del
Date: Mon, 26 Jan 2026 10:47:10 -0800	[thread overview]
Message-ID: <4ec19bf5-68da-4a6c-adcb-c8e127a7fcae@oracle.com> (raw)
In-Reply-To: <20260125134759.GD13967@unreal>

On 2026-01-25 5:47 a.m., Leon Romanovsky wrote:
> On Mon, Jan 19, 2026 at 03:53:29PM -0400, Jason Gunthorpe wrote:
>> On Mon, Jan 19, 2026 at 11:43:52AM -0800, Sharath Srinivasan wrote:
>>> The sync strategy in remove_all_compat_devs() can improved
>>> by adopting that of rdma_dev_exit_net() which releases devices_rwsem
>>> before calling remove_one_compat_dev()/device_del().
>>>
>>> Also fixes a comment typo in rdma_dev_exit_net().
>>
>> You cannot change this locking without writing a huge commit message
>> explaining in detail the reason why any change like this is safe..
> 
> We can drop this patch, it doesn't even apply.
> 
> Thanks
> 

Thanks for trying. I'll send a rebased-v2 with an expanded commit message as Jason suggested.

Regards,
Sharath

>>
>> Jason
>>
> 


      reply	other threads:[~2026-01-26 18:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-19 19:43 Sharath Srinivasan
2026-01-19 19:53 ` Jason Gunthorpe
2026-01-25 13:47   ` Leon Romanovsky
2026-01-26 18:47     ` Sharath Srinivasan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ec19bf5-68da-4a6c-adcb-c8e127a7fcae@oracle.com \
    --to=sharath.srinivasan@oracle.com \
    --cc=jgg@ziepe.ca \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=parav@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome