From: David Hildenbrand <david@redhat.com>
To: xu.xin16@zte.com.cn, willy@infradead.org, ziy@nvidia.com,
akpm@linux-foundation.org
Cc: ran.xiaokai@zte.com.cn, yang.yang29@zte.com.cn,
mhocko@kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH linux-next] mm: huge_memory: remove is_transparent_hugepage()
Date: Wed, 5 Jun 2024 10:56:54 +0200 [thread overview]
Message-ID: <4ec4dd03-abf1-42a2-9460-b15df6ca21c3@redhat.com> (raw)
In-Reply-To: <20240605163731027tu4GJzm7fzc00snHCyF_3@zte.com.cn>
On 05.06.24 10:37, xu.xin16@zte.com.cn wrote:
> From: Ran Xiaokai <ran.xiaokai@zte.com.cn>
>
> is_transparent_hugepage() was first introduced to ensure the page is
> 2M THP page. After commit de53c05f2ae3 ("mm: add large_rmappable
> page flag") and commit fc4d182316bd ("mm: huge_memory: enable debugfs
> to split huge pages to any order"), any large folio of mTHP suitable order
> can be split, not only 2M THP page.
Yes.
> so the check in split_huge_pages_pid() is not needed here, instead
> a folio_test_large() check is sufficient. To ensure a 2M THP folio,
> we should use "folio_order(folio) == HPAGE_PMD_ORDER" for now.
What about some kernel-allocated large folio that got mapped using
vm_insert_pages() and friends? Are we sure these pages (that are not
large_rmappable and not splittable) are properly handled?
--
Cheers,
David / dhildenb
prev parent reply other threads:[~2024-06-05 8:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 8:37 " xu.xin16
2024-06-05 8:56 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ec4dd03-abf1-42a2-9460-b15df6ca21c3@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=ran.xiaokai@zte.com.cn \
--cc=willy@infradead.org \
--cc=xu.xin16@zte.com.cn \
--cc=yang.yang29@zte.com.cn \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®