From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F9A93D5240 for ; Tue, 19 May 2026 07:33:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779175992; cv=none; b=P5/OwPcQgez+D83Gv61aopxsZ6UygfW6FokPCqrnlmxjdsm3h4kkeQxCAeC0sLGnMWrQ9v68mbbRmHo1FGZZwNtruFvewbl1+BkgpDznpV4efZVcauhXrKcxnK7P+RMrmOziIlfJFE4LxBVEKkjxpbcRR/hPXd4gURNAEmKiZ+Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779175992; c=relaxed/simple; bh=63fCVpVCCBjxxYbmfDQo/xpMJK2+HMCNSI/bp8jVe0s=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=H7votlrf/l9MglnOTlfPKo5wpMpc2CUr30PQRWbzpiBta6j46u3qia01CR7UOvel/mu+LD5ToSxijzkYlJHsfceZNhuN1wo39zqQAVeazLqg4aV34ilpGWN+DPiQFkE4j9hBJxSGWA28QWJpoT/BRv9HYNs00hG5COmRouRjBb0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=C7kXWMJ9; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="C7kXWMJ9" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-488ad135063so24136465e9.0 for ; Tue, 19 May 2026 00:33:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1779175990; x=1779780790; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=WT2XihSgFDy/lOv8L6CXXNwwAVk4RQea7wu+1npHTP8=; b=C7kXWMJ9ezDy+KXFXMw0AU/KwO+vb0NVtxR8fOM07/BUly6ZFRZxfG2oN0Y83olYAj 7kDX7w4JeudiMCk61mIArjP2Xef6buTvZ+t8rtyfcPGZnrgDBVuv4OCNeJYZUUizqoBW S6sGmy00HQEGxb1mAbVmG9CT4pzq3KpYJbBXl97vyKXdARH1bczaYVqBC+lBPts8R3wR hcGJF1aZ0Y7z0o1crLhhq3Xd404NG1gjU1I5PCoWAowQum8eTROxdWd3aOL/JrWq7VXK bwWABRpUPP8INaLEKk/GiF0mK8NKW4RoDrz25X8mruA14lTtu9qHqDWZyieCac2RoUVu UJ6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779175990; x=1779780790; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WT2XihSgFDy/lOv8L6CXXNwwAVk4RQea7wu+1npHTP8=; b=bnmRBuhvWvhjC31IktJJ3mz7woVqytYjH4Vo5F2euaWR1WJcLeh72B/9/i7R6VG28l GOhPMr5kGk0oh+dyPUGU2OhAiAWKtAPP25t6U34crkiCSXVFGx1c90LosQmYl/w6Wga+ JVBPS+H3ZxugBPXQpDKsGjE/AEmJxJRJMHLpVjtWZC9oaKOYgmuvto2JbEPRnSTBNg2R mwvnsJQ/m4TvH5ygocxq/8qUnOH7MGKX3ETYHf8UBYNMIibFVuLLXhRUQODLHh3mYslc wmw0XcB/GswsR9HeiDO90MPLPNtxQn8Z6zAZW9sUMH0USwDoELDOLb3fO/BHivXJEn5Q GefQ== X-Forwarded-Encrypted: i=1; AFNElJ9dkRQNBbdy4kGZpV3CYzn3M5pbjGMkZjpa5u1MvS6u8xD7ZiuUjufYfnqiiE/uluZBS+Gg3X5CRI8j0e4=@vger.kernel.org X-Gm-Message-State: AOJu0Yyj350ALEmQcvHiljoQnYY6yNK4DPAuNaJhgfoFo7DwGOLahsV5 0t9uXIPjWMuDe6YJuCiVpp7MxKmUjAH1TaR+xBU4/XPK4svxP+J6vkA4HJXPxTAWqhY= X-Gm-Gg: Acq92OEigMzR4IOCkys3lHaOWEw5We2GfTWuoVCVEL3jSraxtWXSuHDpmSLnU5z14fM qxdRWM7nakNtDFPjJSbcPn5fnMRYWUatRtunyxGqMeLvn2jVnyju4cpWpbOYBodsBd2FAYVKFAG 9kMByRNndAb7Fd4b1bfeUhxk/0nkGvmW2YOFfmoIn06F7MjK5fPOXO9WMc5nvG9geflOJdrmXaM ebSIuTZpwNvGyws0sC7llq23zz4xKY4NiMlwzVliLpHYZvhb7Ib7FsawcjfiaJXbUcuLVk4V5iW h5nxbD9WrYzL2YuOInK7RqBx1b6mZFMAM9XVdo6AU1mIHcyAwMlRWWJv55vK2fI8ZTMYlamgP1P 8eYE6+CLv7wv9ugqJkB6LRvPQn7PU+gxL8RGQ0vd2NybSGgSoeagp/BQ8LQqReWrBdM7A12SBrG na5PCCmGEAbKC2IR+1gOEt86nd7itfY0zNXv+ZB7TfblcBHsQ+95wv9VVC52MswlN2gZKLybXHE GFKpEp/b1LIWxs= X-Received: by 2002:a05:600c:858d:b0:48e:82b4:b54 with SMTP id 5b1f17b1804b1-48fe6514873mr222865245e9.23.1779175989618; Tue, 19 May 2026 00:33:09 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:1d4b:274c:94d:a69f? ([2a01:e0a:106d:1080:1d4b:274c:94d:a69f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48ff43f213esm136408795e9.1.2026.05.19.00.33.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 May 2026 00:33:09 -0700 (PDT) Message-ID: <4ed0c9c4-6a48-4c25-9caa-16914587e580@linaro.org> Date: Tue, 19 May 2026 09:33:08 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH 08/13] drm/meson: dw-hdmi: Use local dev variable consistently in bind() To: Jonas Karlman , Kevin Hilman , Heiko Stuebner , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jerome Brunet , Martin Blumenstingl Cc: dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org References: <20260518194744.2483580-1-jonas@kwiboo.se> <20260518194744.2483580-9-jonas@kwiboo.se> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260518194744.2483580-9-jonas@kwiboo.se> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/18/26 21:47, Jonas Karlman wrote: > Replace indirect struct device accesses via pdev->dev with the local dev > parameter already available in meson_dw_hdmi_bind(), for consistency and > readability. > > Signed-off-by: Jonas Karlman > --- > drivers/gpu/drm/meson/meson_dw_hdmi.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c > index 30099bf71aad..fcd2426af9fc 100644 > --- a/drivers/gpu/drm/meson/meson_dw_hdmi.c > +++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c > @@ -671,9 +671,9 @@ static int meson_dw_hdmi_bind(struct device *dev, struct device *master, > > DRM_DEBUG_DRIVER("\n"); > > - match = of_device_get_match_data(&pdev->dev); > + match = of_device_get_match_data(dev); > if (!match) { > - dev_err(&pdev->dev, "failed to get match data\n"); > + dev_err(dev, "failed to get match data\n"); > return -ENODEV; > } > > @@ -771,7 +771,7 @@ static int meson_dw_hdmi_bind(struct device *dev, struct device *master, > return PTR_ERR(meson_dw_hdmi->hdmi); > } > > - meson_dw_hdmi->bridge = of_drm_find_and_get_bridge(pdev->dev.of_node); > + meson_dw_hdmi->bridge = of_drm_find_and_get_bridge(dev->of_node); > if (!meson_dw_hdmi->bridge) { > devm_free_irq(dev, irq, meson_dw_hdmi); > dw_hdmi_remove(meson_dw_hdmi->hdmi); Reviewed-by: Neil Armstrong Thanks, Neil