From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Jakub Kicinski <kuba@kernel.org>, Davide Caratti <dcaratti@redhat.com>
Cc: Li Zhijian <zhijianx.li@intel.com>,
shuah@kernel.org, linux-kselftest@vger.kernel.org,
lizhijian@cn.fujitsu.com, linux-kernel@vger.kernel.org,
lkp@intel.com, philip.li@intel.com
Subject: Re: [PATCH v2 1/3] selftests/tc-testing: add exit code
Date: Wed, 17 Nov 2021 11:41:18 -0500 [thread overview]
Message-ID: <4ed23cd5-f4a1-aa70-183f-fbea407c19ee@mojatatu.com> (raw)
In-Reply-To: <20211117060535.1d47295a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 2021-11-17 09:05, Jakub Kicinski wrote:
> On Wed, 17 Nov 2021 09:55:14 +0100 Davide Caratti wrote:
>> On Wed, Nov 17, 2021 at 01:45:15PM +0800, Li Zhijian wrote:
>>> Mark the summary result as FAIL to prevent from confusing the selftest
>>> framework if some of them are failed.
>>>
>>> Previously, the selftest framework always treats it as *ok* even though
>>> some of them are failed actually. That's because the script tdc.sh always
>>> return 0.
>>
>> yes, also tdc was lacking support for KSFT_SKIP for a long time.
>
> Should this go via netdev? Is the risk of conflicts low enough
> so it doesn't matter?
>
Yes, discussions should at minimal Cc netdev + tc maintainers.
> We should probably add a MAINTAINERS entry for tdc. Adding Jamal.
Did you mean adding a maintainer for tdc or just generally point
who/what to involve when making changes? Typically the mailing list
should be sufficient. Outside the list, at the moment, any outstanding
issues on tdc are discussed/resolved in the monthly TC meetups (where
all the stake holders show up)...
cheers,
jamal
next prev parent reply other threads:[~2021-11-17 16:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 5:45 Li Zhijian
2021-11-17 5:45 ` [PATCH v2 2/3] selftests/tc-testing: add missing config Li Zhijian
2021-11-17 5:45 ` [PATCH v2 3/3] selftests/tc-testing: Fix cannot create /sys/bus/netdevsim/new_device: Directory nonexistent Li Zhijian
2021-11-17 8:55 ` [PATCH v2 1/3] selftests/tc-testing: add exit code Davide Caratti
2021-11-17 14:05 ` Jakub Kicinski
2021-11-17 16:41 ` Jamal Hadi Salim [this message]
2021-11-17 16:48 ` Jakub Kicinski
2021-11-17 16:51 ` Jamal Hadi Salim
2021-12-03 2:21 ` Li Zhijian
2021-12-03 2:47 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ed23cd5-f4a1-aa70-183f-fbea407c19ee@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=dcaratti@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lizhijian@cn.fujitsu.com \
--cc=lkp@intel.com \
--cc=philip.li@intel.com \
--cc=shuah@kernel.org \
--cc=zhijianx.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®