From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752087AbeBHQNU (ORCPT ); Thu, 8 Feb 2018 11:13:20 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:37060 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750847AbeBHQNT (ORCPT ); Thu, 8 Feb 2018 11:13:19 -0500 Subject: Re: [PATCH] coresight replicator: set default y after Kconfig rename To: Kim Phillips , Mathieu Poirier Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Suzuki K Poulose References: <20180207150351.ce930e929bc0d7f6cfb1aa56@arm.com> From: Robin Murphy Message-ID: <4ed2bf14-206a-20c6-40a6-3ab9a2ec07b4@arm.com> Date: Thu, 8 Feb 2018 16:13:16 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180207150351.ce930e929bc0d7f6cfb1aa56@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/02/18 21:03, Kim Phillips wrote: > Commit 1c8859848dbb ("coresight replicator: Cleanup programmable > replicator naming") changed the Kconfig symbol name from > QCOM_REPLICATOR, which, whilst not in the single arm64 defconfig, > was being set in my juno build script, which left the new symbol unset, > causing the following unexpected grief: > > # ./perf record -vvv -C 0 -e cs_etm/@20070000.etr/ --per-thread true > .... > sys_perf_event_open: pid -1 cpu 0 group_fd -1 flags 0x8 = 5 > mmap size 528384B > AUX area mmap length 4194304 > perf event ring buffer mmapped per cpu > failed to mmap AUX area > failed to mmap with 12 (Cannot allocate memory) > > Make it default y to help not surprise unsuspecting users. How many users are there relying on your Juno build script? :P > Fixes: 1c8859848dbb ("coresight replicator: Cleanup programmable replicator naming") Before that commit, CORESIGHT_QCOM_REPLICATOR was not "default y", nor selected by any in-tree configs, so whatever the problem may be this is clearly not the correct fix. > Cc: Mathieu Poirier > Cc: Suzuki K Poulose > Signed-off-by: Kim Phillips > --- > drivers/hwtracing/coresight/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/hwtracing/coresight/Kconfig b/drivers/hwtracing/coresight/Kconfig > index ef9cb3c164e1..b94bbd95efa6 100644 > --- a/drivers/hwtracing/coresight/Kconfig > +++ b/drivers/hwtracing/coresight/Kconfig > @@ -73,6 +73,7 @@ config CORESIGHT_SOURCE_ETM4X > config CORESIGHT_DYNAMIC_REPLICATOR > bool "CoreSight Programmable Replicator driver" > depends on CORESIGHT_LINKS_AND_SINKS > + default y CORESIGHT_LINKS_AND_SINKS is "default n" (as indeed is CORESIGHT), and not selected by any defconfigs, so in general this doesn't really help anyway. Robin. > help > This enables support for dynamic CoreSight replicator link driver. > The programmable ATB replicator allows independent filtering of the >