mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Walle <michael@walle.cc>
To: Saravana Kannan <saravanak@google.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	stable@vger.kernel.org, kernel-team@android.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] driver core: Fix device link device name collision
Date: Fri, 08 Jan 2021 01:27:24 +0100	[thread overview]
Message-ID: <4ed3da70b825e4cbe778e9b8e4619434@walle.cc> (raw)
In-Reply-To: <b3cda25a3e3911a12a8766f141c9e300@walle.cc>

Am 2021-01-08 01:14, schrieb Michael Walle:
> Am 2021-01-08 00:41, schrieb Saravana Kannan:
>> The device link device's name was of the form:
>> <supplier-dev-name>--<consumer-dev-name>
>> 
>> This can cause name collision as reported here [1] as device names are
>> not globally unique. Since device names have to be unique within the
>> bus/class, add the bus/class name as a prefix to the device names used 
>> to
>> construct the device link device name.
>> 
>> So the devuce link device's name will be of the form:
>> <supplier-bus-name>:<supplier-dev-name>--<consumer-bus-name>:<consumer-dev-name>
>> 
>> [1] - 
>> https://lore.kernel.org/lkml/20201229033440.32142-1-michael@walle.cc/
>> 
>> Cc: stable@vger.kernel.org
>> Fixes: 287905e68dd2 ("driver core: Expose device link details in 
>> sysfs")
>> Reported-by: Michael Walle <michael@walle.cc>
>> Signed-off-by: Saravana Kannan <saravanak@google.com>
>> ---
> 
> This makes it even worse.

Mhh, actually there are now other errors (the ones before might be 
fixed). Seems
to be truncated filenames and for the iommu ones, I don't know.

-- 
-michael

  reply	other threads:[~2021-01-08  0:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-07 23:41 Saravana Kannan
2021-01-08  0:14 ` Michael Walle
2021-01-08  0:27   ` Michael Walle [this message]
2021-01-08  0:43   ` Saravana Kannan
2021-01-08  1:00     ` Saravana Kannan
2021-01-08  1:10       ` Michael Walle
2021-01-08  7:45         ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ed3da70b825e4cbe778e9b8e4619434@walle.cc \
    --to=michael@walle.cc \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=saravanak@google.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®