mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marc Vertes <marc.vertes@sigfox.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: [PATCH] ALSA: hda_intel - revert a quirk that breaks all VIA chipsets
Date: Tue, 29 Nov 2011 11:13:19 +0100	[thread overview]
Message-ID: <4ed4b03f.B0tSFYR8f3fW5ehj%marc.vertes@sigfox.com> (raw)


This quirk sould be reverted. It has the following probems:

1) It breaks the default setup of all VIA chipset models (vendor
0x1106, product 0x3288), at least a dozen models are concerned, from VIA-VT82xx
to VIA-VT17xx and VT20xx. All those chips rely on azx_via_get_position()
to handle correctly dma transfers during capture. Using POS_FIX_LPIB
instead of POS_FIX_VIACOMBO leads to partially corrupted input buffers
during capture. The effects of this bug are not immediately visible,
it took strong DSP expertise, some expensive signal generator and a spectrum
analyzer to identify it and verify correct behaviour using original default.

2) The string "ASUS MV2-MX SE" refers to a motherboard, not a sound chipset
family, which is misleading on the impact of the quirk.

3) It's almost certain that the quirk did not fix the real problem, if there
was one. Refer to original submission:
http://mailman.alsa-project.org/pipermail/alsa-devel/2010-February/025109.html

Thanks,

Marc
--

Signed-of-by: Marc Vertes <mvertes@sigfox.com>

--- linux-3.2-rc3/sound/pci/hda/hda_intel.c.orig	2011-11-24 05:20:28.000000000 +0100
+++ linux-3.2-rc3/sound/pci/hda/hda_intel.c	2011-11-28 17:29:01.044095455 +0100
@@ -2508,7 +2508,6 @@ static struct snd_pci_quirk position_fix
 	SND_PCI_QUIRK(0x1043, 0x81b3, "ASUS", POS_FIX_LPIB),
 	SND_PCI_QUIRK(0x1043, 0x81e7, "ASUS M2V", POS_FIX_LPIB),
 	SND_PCI_QUIRK(0x104d, 0x9069, "Sony VPCS11V9E", POS_FIX_LPIB),
-	SND_PCI_QUIRK(0x1106, 0x3288, "ASUS M2V-MX SE", POS_FIX_LPIB),
 	SND_PCI_QUIRK(0x1297, 0x3166, "Shuttle", POS_FIX_LPIB),
 	SND_PCI_QUIRK(0x1458, 0xa022, "ga-ma770-ud3", POS_FIX_LPIB),
 	SND_PCI_QUIRK(0x1462, 0x1002, "MSI Wind U115", POS_FIX_LPIB),

             reply	other threads:[~2011-11-29 10:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-29 10:13 Marc Vertes [this message]
2011-11-29 10:30 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ed4b03f.B0tSFYR8f3fW5ehj%marc.vertes@sigfox.com \
    --to=marc.vertes@sigfox.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®