From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932272AbdJPQk2 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 16 Oct 2017 12:40:28 -0400
Received: from mailout2.w1.samsung.com ([210.118.77.12]:58249 "EHLO
        mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932198AbdJPQkV (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 16 Oct 2017 12:40:21 -0400
X-AuditID: cbfec7ef-f79ee6d000003120-ba-59e4e0f2e189
Subject: Re: [PATCH v5] crypto: s5p-sss: Add HASH support for Exynos
To: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Vladimir Zapolskiy <vz@mleia.com>,
        "David S. Miller" <davem@davemloft.net>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
From: Kamil Konieczny <k.konieczny@partner.samsung.com>
Message-id: <4ed6e790-891a-42de-8b6b-7318c8a891fd@partner.samsung.com>
Date: Mon, 16 Oct 2017 18:40:16 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
        Thunderbird/52.4.0
MIME-version: 1.0
In-reply-to: <4e9717c5-43d1-46d1-60ed-ea8168a91cc4@mentor.com>
Content-type: text/plain; charset="utf-8"
Content-language: en-US
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrLKsWRmVeSWpSXmKPExsWy7djP87qfHjyJNNh5jt9i44z1rBZzzrew
        WHS/krE4f34Du8X9ez+ZLC7vmsNmMeP8PiaLZwe2sVn8/9XM7MDpsWXlTSaPbQdUPTat6mTz
        2P21idHj38IpLB59W1YxenzeJBfAHsVlk5Kak1mWWqRvl8CVcerZV7aC58wV869cZmlg/MPU
        xcjJISFgIjHz2CtWCFtM4sK99WxdjFwcQgLLGCU2t+5nAUkICXxmlLi0wAOm4fq9/cxwRVMe
        7WCDKHrGKLG3EWySsICLxK8v05lBbBGBcok9b/oYQWxmgTlMEntuGoHYbALmEo+2nwG7glfA
        TWJ5xz+wOSwCqhLf/80HmyMqECFx/PByRogaQYkfk+8BHcTBwSlgJ3HtvhDESE2JF18msUDY
        4hLNrTehbHmJzWveMkPc/JpNYvPKYgjbRWJm83moh4UlXh3fwg5hy0hcntzNAvKXhEA/o8Ty
        G6fYIZwpjBLHp12FBpe1xOHjF1khNvBJTNoG8iQHUJxXoqNNCKLEQ+LFx29sELajxJeG+dDw
        Occose5hwgRG+VlI3pmF5IdZSH6YheSHBYwsqxhFUkuLc9NTiw31ihNzi0vz0vWS83M3MQIT
        0el/x9/vYHzaHHKIUYCDUYmHN+PQk0gh1sSy4srcQ4wSHMxKIrwOd4FCvCmJlVWpRfnxRaU5
        qcWHGKU5WJTEeW2j2iKFBNITS1KzU1MLUotgskwcnFINjJOfP2nUdfoRV/FE68n0CEHlLXIt
        xqvPR7iElfRsTnj+0uHrk7UiylvWOwZEr93PpzuH0/LEgRgF5ZnZZdtf2e1lPe6+7pplYsIE
        Do59QVEFT5dMjpjcpC39awp/y/Fzdxkz30yevXcNn8mLJ7MmdnutET0gU6cSe9bsHZPZ0pqG
        NrmDS7O9liuxFGckGmoxFxUnAgCLC17NQAMAAA==
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpmkeLIzCtJLcpLzFFi42I5/e/4Nd2PD55EGjR8MrTYOGM9q8Wc8y0s
        Ft2vZCzOn9/AbnH/3k8mi8u75rBZzDi/j8ni2YFtbBb/fzUzO3B6bFl5k8lj2wFVj02rOtk8
        dn9tYvT4t3AKi0ffllWMHp83yQWwR3HZpKTmZJalFunbJXBlnHr2la3gOXPF/CuXWRoY/zB1
        MXJySAiYSFy/t58ZwhaTuHBvPVsXIxeHkMASRolJN95COc8YJfbv/cMGUiUs4CLx68t0sA4R
        gXKJlZ9nsoDYzALzmCQmrvSBaLjAKHHkxxmwIjYBc4lH28+AreMVcJNY3vEPbBCLgKrE93/z
        WUFsUYEIiefN71khagQlfky+BzSUg4NTwE7i2n0hEJNZQF1iypRciFXiEs2tN6HWyktsXvOW
        eQKj4CwkzbMQOmYh6ZiFpGMBI8sqRpHU0uLc9NxiI73ixNzi0rx0veT83E2MwKjZduznlh2M
        Xe+CDzEKcDAq8fBmHHoSKcSaWFZcmXuIUYKDWUmE1+EuUIg3JbGyKrUoP76oNCe1+BCjNAeL
        kjhv757VkUIC6YklqdmpqQWpRTBZJg5OqQbGTB6bOV06h6v85lgvsUhQXbgjRibI++uZ78cd
        isptpJmb1Teeum3+7KyC6L/DYX+UZi2KXV3vNK+h++CMBe7a785Ju+sX7GrwMFVyud7x+TFb
        R6jLJUu9xdp5PKdvPo54Jz3NgN30gHtOgJNatWKf2KeNd7yu5qjtXzh35s+NgR5d2/L2vMpW
        YinOSDTUYi4qTgQAelEND5YCAAA=
X-CMS-MailID: 20171016164017eucas1p279f01c22d191643247f6051395fe9087
X-Msg-Generator: CA
X-Sender-IP: 182.198.249.180
X-Local-Sender: =?UTF-8?B?S2FtaWwgS29uaWVjem55G1NSUE9MLUtlcm5lbCAoVFApGw==?=
        =?UTF-8?B?7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?=
X-Global-Sender: =?UTF-8?B?S2FtaWwgS29uaWVjem55G1NSUE9MLUtlcm5lbCAoVFApG1Nh?=
        =?UTF-8?B?bXN1bmcgRWxlY3Ryb25pY3MbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?=
X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?=
CMS-TYPE: 201P
X-CMS-RootMailID: 20171009111232eucas1p1d17afaae66931a7dd234dbfa1d5a193f
X-RootMTR: 20171009111232eucas1p1d17afaae66931a7dd234dbfa1d5a193f
References: <CGME20171009111232eucas1p1d17afaae66931a7dd234dbfa1d5a193f@eucas1p1.samsung.com>
        <afa6482f-dc1e-6aab-5754-fa86f554e0b2@partner.samsung.com>
        <4e9717c5-43d1-46d1-60ed-ea8168a91cc4@mentor.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Vladimir,

>>[snip]

>> -static struct s5p_aes_dev *s5p_dev;
>> +enum hash_op {
>> +	HASH_OP_UPDATE = 1,
>> +	HASH_OP_FINAL = 2
>> +};
> 
> If this type is not going to be extended, then I'd rather suggest to
> use a boolean correspondent field in the struct s5p_hash_reqctx instead
> of a new introduced type. [...]

In prevoious mail I wrote 'op_final', but this will actually be 'op_update'.

-- 
Best regards,
Kamil Konieczny
Samsung R&D Institute Poland