From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753619AbcHQDEd (ORCPT ); Tue, 16 Aug 2016 23:04:33 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:60556 "EHLO s-opensource.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752152AbcHQDEc (ORCPT ); Tue, 16 Aug 2016 23:04:32 -0400 Subject: Re: [PATCH v2] clk: max77686: Migrate to clk_hw based OF and registration APIs To: Stephen Boyd , Michael Turquette , Stephen Boyd References: <20160816223856.1282-1-stephen.boyd@linaro.org> Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Laxman Dewangan , Krzysztof Kozlowski From: Javier Martinez Canillas Message-ID: <4edf11bf-53b9-e419-1d27-69eaed07e3ab@osg.samsung.com> Date: Tue, 16 Aug 2016 23:04:22 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <20160816223856.1282-1-stephen.boyd@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Stephen, On 08/16/2016 06:38 PM, Stephen Boyd wrote: > Now that we have clk_hw based provider APIs to register clks, we > can get rid of struct clk pointers while registering clks in > these drivers, allowing us to move closer to a clear split of > consumer and provider clk APIs. > > Cc: Javier Martinez Canillas > Cc: Laxman Dewangan > Cc: Krzysztof Kozlowski > Signed-off-by: Stephen Boyd > --- The patch looks good to me. Reviewed-by: Javier Martinez Canillas Also, I've tested this on an Exynos5800 Peach Pi Chromebook that has a max77802 (supported by this driver) and the clocks are working correctly. Tested-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America