From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Nick Desaulniers <ndesaulniers@google.com>,
Ilie Halip <ilie.halip@gmail.com>
Cc: linux-kernel@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Nathan Chancellor <nathan@kernel.org>,
Mete Durlu <meted@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
linux-s390@vger.kernel.org, llvm@lists.linux.dev,
Ulrich Weigand <Ulrich.Weigand@de.ibm.com>
Subject: Re: [PATCH] s390/test_unwind: use raw opcode instead of invalid instruction
Date: Fri, 19 Nov 2021 10:44:44 +0100 [thread overview]
Message-ID: <4ee51adb-090f-071f-6f0e-ab739fe98498@de.ibm.com> (raw)
In-Reply-To: <d9ec2704-f41c-eafa-1945-ce845d65be8a@de.ibm.com>
Am 19.11.21 um 10:39 schrieb Christian Borntraeger:
>
>
> Am 19.11.21 um 02:10 schrieb Nick Desaulniers:
>> On Wed, Nov 17, 2021 at 9:48 AM Ilie Halip <ilie.halip@gmail.com> wrote:
>>>
>>> Building with clang & LLVM_IAS=1 leads to an error:
>>> arch/s390/lib/test_unwind.c:179:4: error: invalid register pair
>>> " mvcl %%r1,%%r1\n"
>>> ^
>>>
>>> The test creates an invalid instruction that would trap at runtime, but the
>>> LLVM inline assembler tries to validate it at compile time too.
>>>
>>> Use the raw instruction opcode instead.
>>>
>>> Link: https://github.com/ClangBuiltLinux/linux/issues/1421
>>> Reported-by: Nick Desaulniers <ndesaulniers@google.com>
>>> Signed-off-by: Ilie Halip <ilie.halip@gmail.com>
>>
>> Ilie, thanks for the patch!
>>
>> So if I understand
>> https://sourceware.org/binutils/docs/as/s390-Directives.html#s390-Directives
>> https://sourceware.org/binutils/docs/as/s390-Formats.html
>> that `e,` prefix is for 16B opcodes?
>
> e is an instruction format as specified by the architecture.
> See http://publibfp.dhe.ibm.com/epubs/pdf/a227832c.pdf
(page 5-3 for the instruction formats and page 7-289 for MVCL)
next prev parent reply other threads:[~2021-11-19 9:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 17:48 Ilie Halip
2021-11-19 1:10 ` Nick Desaulniers
2021-11-19 9:39 ` Christian Borntraeger
2021-11-19 9:44 ` Christian Borntraeger [this message]
2021-11-19 10:54 ` Heiko Carstens
2021-11-19 10:57 ` Christian Borntraeger
2021-11-19 11:09 ` Heiko Carstens
2021-11-19 14:12 ` Christian Borntraeger
2021-11-19 15:15 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ee51adb-090f-071f-6f0e-ab739fe98498@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=Ulrich.Weigand@de.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=ilie.halip@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=meted@linux.ibm.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®