From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752558AbdKWECe (ORCPT ); Wed, 22 Nov 2017 23:02:34 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:44388 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752133AbdKWECc (ORCPT ); Wed, 22 Nov 2017 23:02:32 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B69D86044B Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=mgautam@codeaurora.org Subject: Re: [PATCH v3 10/16] phy: qcom-qmp: Move register offsets to header file To: Stephen Boyd , Kishon Vijay Abraham I Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, Vivek Gautam , Varadarajan Narayanan , Wei Yongjun , Fengguang Wu , open list References: <1511256206-1587-1-git-send-email-mgautam@codeaurora.org> <1511256206-1587-11-git-send-email-mgautam@codeaurora.org> From: Manu Gautam Message-ID: <4ee6af23-7b09-c25b-9e79-f08373a88826@codeaurora.org> Date: Thu, 23 Nov 2017 09:32:26 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 11/22/2017 10:56 PM, Stephen Boyd wrote: > On 11/21/2017 01:23 AM, Manu Gautam wrote: >> New revision (v3) of QMP PHY uses different offsets >> for almost all of the registers. Hence, move these >> definitions to header file so that updated offsets >> can be added for QMP v3. >> >> Signed-off-by: Manu Gautam >> --- > Why? It would only be included into one C file so it's really not necessary. Yes, it is not necessary but it keep QMP PHY driver clean. V3 PHY duplicates all the #defines and this could continue for future revisions as well. Please refer to this patch:  - [PATCH v3 11/16] phy: qcom-qmp: Add register offsets for QMP V3 PHY -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project