From: Joe Perches <joe@perches.com>
To: Maninder Singh <maninder1.s@samsung.com>,
apw@canonical.com, dwaipayanray1@gmail.com,
lukas.bulwahn@gmail.com
Cc: linux-kernel@vger.kernel.org, Vaneet Narang <v.narang@samsung.com>
Subject: Re: [PATCH RESEND v2] scripts/checkpatch.pl: remove _deferred and _deferred_once false warning
Date: Wed, 02 Feb 2022 01:16:45 -0800 [thread overview]
Message-ID: <4ee87d70d5348949787b2d747f90ecffa3119d0b.camel@perches.com> (raw)
In-Reply-To: <20220202071405.1872044-1-maninder1.s@samsung.com>
On Wed, 2022-02-02 at 12:44 +0530, Maninder Singh wrote:
> printk_deferred and printk_deferred_once requires LOGLEVEL in argument,
> but checkpatch.pl reports it as warning:
When did that occur? Please reference the specific commit.
When printk_sched (now printk_deferred) was created it did not
allow KERN_<LEVEL>.
see commit 3ccf3e830615 ("printk/sched: Introduce special printk_sched() for those awkward moments")
There are many existing printk_deferred uses without KERN_<LEVEL>.
> WARNING: Possible unnecessary KERN_ALERT
> printk_deferred(KERN_ALERT "checking deferred\n");
next prev parent reply other threads:[~2022-02-02 9:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220202071414epcas5p1d329ae4f76c281c1f8f7f07bfb36a919@epcas5p1.samsung.com>
2022-02-02 7:14 ` Maninder Singh
2022-02-02 9:16 ` Joe Perches [this message]
[not found] ` <CGME20220202071414epcas5p1d329ae4f76c281c1f8f7f07bfb36a919@epcms5p2>
2022-02-02 9:52 ` Maninder Singh
2022-02-02 9:59 ` Joe Perches
[not found] ` <CGME20220202071414epcas5p1d329ae4f76c281c1f8f7f07bfb36a919@epcms5p5>
2022-02-02 10:08 ` Maninder Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ee87d70d5348949787b2d747f90ecffa3119d0b.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=dwaipayanray1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=maninder1.s@samsung.com \
--cc=v.narang@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®