From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795080945; b=LDZKoL3d0SdhvxMqKfOyCmD79v4KyFzNA+MqsKVJdOR2BUt1jT4EQdYrPERLEjn/pdpr yXEAaKsBMpQwa54s5OkgfcGK/5DjF2gLM0OswwEL9DRlFmhRKZ2IxLfjuelRvEfi+WIWq t6mA1bHis+5SggfKefjScy7d5iEQLVzYrqUd27pIoER63IMSGoRDF1jgHjpTtxJB9pn9d wNOn6Pdx9MGpfiHGKEnVS+Zf1zeYimEeo0WLJVri4/j1AmIogbt+me30NuQBGE3L+Ou2U nHvPPCMy3A0GMj+3f9ONYG7IDxpXTKL5GsFQH43n3nYbP51DQP66QAiEiG3EcENuGlg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795080945; h=DMARC-Filter:DKIM-Signature:Received:X-MC-Unique: X-Mimecast-MFC-AGG-ID:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received: X-Received:Received:Message-ID:Date:MIME-Version:User-Agent:Subject: To:Cc:References:Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding; bh=JOFWnryy22U8bQSzM6KdqLeAcd1quBBtSo308pXYk6c=; b=2Z25CDUTaWaoog5G72iE02rJzb8ncsgvii8EsCUxVIanl49MzPyb2S15K9x780RUapdp dPiYLHGEEHjeSeoQyf4lvN2WkjV0ly/2XYGMeue5kuMNrEwvypBL7LfoM79NQkeJHwdvt OlF/vgvzfpO6yG9kBdRbwF61XzGFm2pb0igbICkJmvGXLF2obfVpZXpJEdBQdXoa4Y5gJ 9DmQqRd/y6Y5R36ZFkXY9qpgI2m+YvEEO3ZE23aiTJ7ucB9t3FER17vkbajOETM961Vm/ cE9GaJt/CEWA40zgwr0/pgoPnV2E6pjiT/z+6O6Vra8kkJimYN55CwNj9KLCWMll96Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b="EQR5k/S5"; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=google header.b=dSJBwNcU; arc=none smtp.remote-ip=170.10.133.124 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA55C60A2609 for ; Thu, 19 Nov 2026 09:35:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org DA55C60A2609 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=EQR5k/S5; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=google header.b=dSJBwNcU DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1795080943; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JOFWnryy22U8bQSzM6KdqLeAcd1quBBtSo308pXYk6c=; b=EQR5k/S5gX9O2isyt9+JvCb312lvuQU3o+Tqp4+vCflfecSErAFIy3ykBo3xSvgGk7dPsT WtLZujzuVFLpnfLmbSdniorq0OACjUOdcLIFEz/ECXMSvzNp4wZQd8wSw/fRHMsunSPAJf JibFbSVVIP21JAtWnem5KUV1Mh1omDw= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-470-QBdABVJNO7Cn0Fuh5pUUeA-1; Thu, 19 Nov 2026 04:35:42 -0500 X-MC-Unique: QBdABVJNO7Cn0Fuh5pUUeA-1 X-Mimecast-MFC-AGG-ID: QBdABVJNO7Cn0Fuh5pUUeA_1795080940 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-4aa0500c979so186678f8f.2 for ; Thu, 19 Nov 2026 01:35:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1795080940; x=1795685740; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=JOFWnryy22U8bQSzM6KdqLeAcd1quBBtSo308pXYk6c=; b=dSJBwNcUgfpqpqpcO00BqOgy6rn/27u4bSv3znU6NaisVn84/7OzU/9ig3OXS8+qsK qkKbiT4enLFnOOfvErU0mUGxO9SyqIicLhEdGhj161vtOw7rn06zu5zlfeN4M90uksHt BqdsSOZQ9+ChDM02orCwj2u0lN8u9SgDRjDOPlR2V8oX9zNrwJO8yCgUkeLrzbJGqLhe Gdo+aLVsRknjp/6HczOJxengWvca6cMc60CwN7kZnk2zIFWBWUiULNnSpqhanfL0AXUr uBGXqJNf4T4Ht1kz09UPFF3lpULA8QfuswA3BN77urak8D52Xy+IS+NFkuWseWi4Vwuk gtog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795080940; x=1795685740; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=JOFWnryy22U8bQSzM6KdqLeAcd1quBBtSo308pXYk6c=; b=XGYZej731h+shTFJ400AHpdXRZQDtlnImMsT/nFjxqtEcvIaTG5VdZ29CGZnebHei/ pdmCCJgMFKZ5vMhmC1Y1rLtFLJPewDYROGjAcNKbkuH+DIJC8cvDQ/NNxWUPA5QIXKjn Zug0ruLDkIKEO1nSd85pAqI5cs8pNHxdxEXohK9XlkiqdYJR0vl/j4e+ZqVvcZoHZsK8 j+FldWrJLi8dXILT3YraKkFunNDG8PaN3OfZpApNtTp9J4L/J/1SLK50JgIqk3sPBMGL aYVVeebfkG+EvNpwr/2ePcVu6nOz961Zb5ES9QeJ4uAq0oFdLoVAlHttF4qTE42gO9Ui 0UZQ== X-Forwarded-Encrypted: i=1; AL+hErF33oej6kLvHWElmsZNw/XZEwqSU0k3qF+2e5Z6G2jveIVWrZ5tg2TocwG7LektVPfOpQrk+rlk49vrwsQ=@vger.kernel.org X-Gm-Message-State: APuU4Z+7f/JUZ57XlF1Q1ScrNwOm/wyn8HWaMK9ibBFDJ3L+l2MzavnX Dp7ZZKf8cSEaFUJ94hWAVoYxrNHI6on2ozCjoTo1OQdbV4jYf3VGLeQhSPFWo1SRKKCoqCPe5DP iS+CG40cPptrpWpKp5zIS8sKG55KUSgxaNedapbyOOFRP9GJovzMfUHPM5nkZeacaaQ== X-Gm-Gg: AZFdTZf4ZZUD0ykw9iOh2W9dbyzpkXsqcQ78n0NEKh7Gjrzs/QUVAc1kfNtSWJt/dTH gYBcS0aoMllhFUrhDvXCpE3ie4qfQfqCmbE04p0It+EXpEebui+lgOt7w3GHXlpwE9ijfJi8gh5 U3XoMAYBAfl2Rn9QEGDpLOiR+P8QO0wItZlWKVfduCrnVp0nYeXCHCPEAY0BVQF7qvk3yuUqDsD mi7S1tHadlPoqzFAzoQcnOiHnS2aybPlUZOc7hzKY+KREl/mmsuSkjfBdz6OMrbW7Yv/sqF7xpr vSRkzdtuSQdWAbEClenecdS3F6/v/EHAMN7dtgh5QnWdYkS9/K0YXaMIHIPNkaVFiy9JFC+/1Y0 fnfzfnVRyMPZhb62EWlUnf1JLuYQU4UZTf7ka2y9ESttgvCVfWrpKBLG6J+iFdhhvNQgshp0WBy f9uXN52gktUc05B6NC4jYzzfO2CWTJx2/uLVzNWQjNbhC1 X-Received: by 2002:a05:6000:184b:b0:48f:bcdf:6f7d with SMTP id ffacd0b85a97d-4a63b6fbd88mr11817870f8f.34.1795080939801; Thu, 19 Nov 2026 01:35:39 -0800 (PST) X-Received: by 2002:a05:6000:184b:b0:48f:bcdf:6f7d with SMTP id ffacd0b85a97d-4a63b6fbd88mr11817756f8f.34.1795080939199; Thu, 19 Nov 2026 01:35:39 -0800 (PST) Received: from [192.168.88.30] (ip231-128-192-82.pool-bba.aruba.it. [82.192.128.231]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4a654a8c39bsm9495655f8f.17.2026.11.19.01.35.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Nov 2026 01:35:38 -0800 (PST) Message-ID: <4eea6d32-4200-4cd1-860a-70e81356678e@redhat.com> Date: Thu, 19 Nov 2026 10:35:36 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v6 1/4] net: qrtr: Allow the host QRTR to assign a unique node id To: netdev-bot+sashiko@kernel.org, manivannan.sadhasivam@oss.qualcomm.com Cc: mani@kernel.org, davem@davemloft.net, kuba@kernel.org, horms@kernel.org, jjohnson@kernel.org, edumazet@kernel.org, linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, andersson@kernel.org, christopher.lew@oss.qualcomm.com, deepak.singh@oss.qualcomm.com, raj.bhagat@oss.qualcomm.com, juha-matti.tilli@iki.fi, jeff.hugo@oss.qualcomm.com, daizhuang.bai@oss.qualcomm.com, jeff.johnson@oss.qualcomm.com References: <20261114-qrtr-multi-ep-v6-1-2eb9885659e2@oss.qualcomm.com> <179478985187.3136.15328141866524028119@kernel.org> Content-Language: en-US From: Paolo Abeni In-Reply-To: <179478985187.3136.15328141866524028119@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 11/16/26 01:44, netdev-bot+sashiko@kernel.org wrote: > Thank you for your contribution! Sashiko AI review found 5 potential > issue(s) to consider. > > Critical: 0 · High: 0 · Medium: 2 · Low: 3 > > If you believe none of the issues are legitimate, please reply to each > issue of Medium severity or higher and explain why the AI is wrong. > If any of them are legitimate and you plan to respin, please let patchwork > know by including "pw-bot: cr" as a separate line at the end of your reply > (one such reply per series is enough). > > - [Medium] A failed node-id insert now drops the packet, where the old > code still delivered it, and a dropped HELLO is never recovered. > - [Medium] In AUTO mode, nid and ep_nid can end up different, which the > commit message says cannot happen, and the rewrite logic then… The first concern above looks relevant, and the 2nd deserves at least an explicit answer. In general you need to address (either debate or fix) every AI comment with prio >= Mid. Next patch as more of such comments. /P