From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DD745495F1 for ; Wed, 10 Jan 2024 14:00:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0E5CE2F4; Wed, 10 Jan 2024 06:01:41 -0800 (PST) Received: from [10.57.46.83] (unknown [10.57.46.83]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 230AE3F5A1; Wed, 10 Jan 2024 06:00:54 -0800 (PST) Message-ID: <4eef0b8d-3702-429b-bf9b-50e176498833@arm.com> Date: Wed, 10 Jan 2024 14:00:52 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 8/8] coresight: Remove unused stubs Content-Language: en-GB To: James Clark , coresight@lists.linaro.org Cc: Mike Leach , Alexander Shishkin , Maxime Coquelin , Alexandre Torgue , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com References: <20231212155407.1429121-1-james.clark@arm.com> <20231212155407.1429121-9-james.clark@arm.com> <01c15dbe-57d3-4aa1-9d68-81a01ec2a3a7@arm.com> From: Suzuki K Poulose In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 09/01/2024 16:48, James Clark wrote: > > > On 09/01/2024 10:38, Suzuki K Poulose wrote: >> Hi James >> >> On 12/12/2023 15:54, James Clark wrote: >>> These are a bit annoying to keep up to date when the function signatures >>> change. But if CONFIG_CORESIGHT isn't enabled, then they're not used >>> anyway so just delete them. >>> >> >> Have you tried building an arm32 kernel with this change in ? Looks like >> arch/arm/kernel/hw_breakpoint.c includes linux/coresight.h and a build >> with CONFIG_CORSIGHT=n might break the build ? So is > > arm32 and CONFIG_CORESIGHT=n works because hw_breakpoint.c doesn't use > any of those symbols, only #defines that were outside the #if > IS_ENABLED(CONFIG_CORESIGHT), specifically CORESIGHT_UNLOCK. > >> drivers/accel/habanalabs/common/habanalabs.h. Now, I am not sure if they > > habanalabs is interesting, it depends on X86_64, but CONFIG_CORESIGHT > depends on ARM || ARM64, so I think we can assume it's also only looking > for #defines and inlines, and not actual code. > > Either way I can't find any build config that actually ever built this, > meaning it's always been dead code. I would have expected some build > robot to have flagged an error by now as I've seen that on other > coresight patches. > >> really need it (even if they do, we may be able to remove the dependency >> on the header file. >> > > They do really need it, also for the CORESIGHT_UNLOCK definition, but > not any functions. Thanks for checking this. Suzuki