From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Stanislav Fomichev <sdf.kernel@gmail.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<anthony.l.nguyen@intel.com>, <przemyslaw.kitszel@intel.com>,
<andrew+netdev@lunn.ch>, <saeedm@nvidia.com>, <tariqt@nvidia.com>,
<mbloch@nvidia.com>, <maxime.chevallier@bootlin.com>,
<mcoquelin.stm32@gmail.com>, <alexandre.torgue@foss.st.com>,
<horms@kernel.org>, <magnus.karlsson@intel.com>,
<maciej.fijalkowski@intel.com>, <sdf@fomichev.me>,
<ast@kernel.org>, <daniel@iogearbox.net>, <hawk@kernel.org>,
<john.fastabend@gmail.com>, <alice.kernel@fastmail.im>,
<dtatulea@nvidia.com>, <witu@nvidia.com>, <martin.lau@kernel.org>,
<yoong.siang.song@intel.com>, <rohan.g.thomas@intel.com>,
<intel-wired-lan@lists.osuosl.org>,
<linux-kernel@vger.kernel.org>, <linux-rdma@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>, <bpf@vger.kernel.org>,
<leon@kernel.org>
Subject: Re: [PATCH net-next 2/3] xsk: honor XDP_TX_METADATA in zero-copy path
Date: Wed, 12 Aug 2026 13:05:56 +0200 [thread overview]
Message-ID: <4ef38557-8181-463b-a19c-1447d6ae10ab@intel.com> (raw)
In-Reply-To: <20260810184753.135756-3-sdf@fomichev.me>
From: Stanislav Fomichev <sdf.kernel@gmail.com>
Date: Mon, 10 Aug 2026 11:47:52 -0700
> The zero-copy path reads TX metadata whenever the UMEM has metadata space,
> even if the descriptor does not set XDP_TX_METADATA. Pass descriptor
> options through the metadata helpers and ignore metadata unless the option
> is set.
>
> This does not change the existing per-WQE metadata handling for mlx5
> MPWQEs, where the descriptor that starts a session configures offload state
> shared by the batch. Supporting mixed metadata states within one MPWQE
> requires a separate fix.
>
> Fixes: 48eb03dd2630 ("xsk: Add TX timestamp and TX checksum offload support")
> Signed-off-by: Stanislav Fomichev <sdf@fomichev.me>
Reviwed-by: Alexander Lobakin <aleksander.lobakin@intel.com>
Thanks,
Olek
next prev parent reply other threads:[~2026-08-12 11:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 18:47 [PATCH net-next 0/3] xsk: pre-existing AF_XDP TX metadata fixes from Sashiko Stanislav Fomichev
2026-08-10 18:47 ` [PATCH net-next 1/3] xsk: align TX metadata layout across ABIs Stanislav Fomichev
2026-08-10 18:47 ` [PATCH net-next 2/3] xsk: honor XDP_TX_METADATA in zero-copy path Stanislav Fomichev
2026-08-12 11:05 ` Alexander Lobakin [this message]
2026-08-10 18:47 ` [PATCH net-next 3/3] net: stmmac: skip queueMaxSDU check for AF_XDP Stanislav Fomichev
2026-08-10 18:52 ` [PATCH net-next 0/3] xsk: pre-existing AF_XDP TX metadata fixes from Sashiko Stanislav Fomichev
2026-08-10 19:40 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ef38557-8181-463b-a19c-1447d6ae10ab@intel.com \
--to=aleksander.lobakin@intel.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alice.kernel@fastmail.im \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=martin.lau@kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=mbloch@nvidia.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=rohan.g.thomas@intel.com \
--cc=saeedm@nvidia.com \
--cc=sdf.kernel@gmail.com \
--cc=sdf@fomichev.me \
--cc=tariqt@nvidia.com \
--cc=witu@nvidia.com \
--cc=yoong.siang.song@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®