From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756562AbcIGKgI (ORCPT <rfc822;w@1wt.eu>);
        Wed, 7 Sep 2016 06:36:08 -0400
Received: from mail-yw0-f169.google.com ([209.85.161.169]:33910 "EHLO
        mail-yw0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751499AbcIGKgG (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 7 Sep 2016 06:36:06 -0400
Subject: Re: [PATCH V10 2/8] ACPI: Add new IORT functions to support MSI
 domain handling
References: <1473152938-17388-1-git-send-email-tn@semihalf.com>
 <1473152938-17388-3-git-send-email-tn@semihalf.com>
 <alpine.DEB.2.20.1609061219230.5647@nanos>
 <f469f024-b1c9-8616-c841-663e3e3d0731@semihalf.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, marc.zyngier@arm.com,
        jason@lakedaemon.net, helgaas@kernel.org, rafael@kernel.org,
        Lorenzo.Pieralisi@arm.com, will.deacon@arm.com,
        catalin.marinas@arm.com, hanjun.guo@linaro.org, shijie.huang@arm.com,
        robert.richter@caviumnetworks.com, mw@semihalf.com,
        linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linaro-acpi@lists.linaro.org, andrea.gallo@linaro.org,
        linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
        al.stone@linaro.org, graeme.gregory@linaro.org, ddaney.cavm@gmail.com,
        okaya@codeaurora.org
To: rjw@rjwysocki.net
From: Tomasz Nowicki <tn@semihalf.com>
Message-ID: <4ef60b61-666c-2be0-1fad-81aa441360bd@semihalf.com>
Date: Wed, 7 Sep 2016 12:35:57 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Firefox/45.0 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <f469f024-b1c9-8616-c841-663e3e3d0731@semihalf.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Rafael,

There are two fixes for iort.c:
1. patch 1 - convert switch to if-else in iort_match_node_callback()
2. patch 2 - remove static local variable for iort_get_device_domain()

Do you want me to repost these patches to get your ACK, or you want new V11?

Thanks,
Tomasz

On 06.09.2016 12:27, Tomasz Nowicki wrote:
> On 06.09.2016 12:20, Thomas Gleixner wrote:
>> On Tue, 6 Sep 2016, Tomasz Nowicki wrote:
>>> +/**
>>> + * iort_get_device_domain() - Find MSI domain related to a device
>>> + * @dev: The device.
>>> + * @req_id: Requester ID for the device.
>>> + *
>>> + * Returns: the MSI domain for this device, NULL otherwise
>>> + */
>>> +struct irq_domain *iort_get_device_domain(struct device *dev, u32
>>> req_id)
>>> +{
>>> +    static struct fwnode_handle *handle;
>>
>> static ??????
>>
>>> +    int its_id;
>>> +
>>> +    if (iort_dev_find_its_id(dev, req_id, 0, &its_id))
>>> +        return NULL;
>>> +
>>> +    handle = iort_find_domain_token(its_id);
>>
>> You reevaluate that on every call.
>>
>
> Obviously it is the bug. Thanks for spotting this.
>
> Tomasz