From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx.nabladev.com (mx.nabladev.com [178.251.229.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1A714BF932; Wed, 30 Sep 2026 21:49:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.251.229.89 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790804952; cv=none; b=eBrwQpGkL7BJjLIItf5cByZyAQ6aqQeH3NIyuGoTJE8aWij21Zkb6pQb686aqqsUs77Z5hve/SKO5mlyoLL1KITO8VQM8z4+LNqQ+6IYgjaitxiD+DJrX9Z9YYKv0C9Cm6KutAmg35rBRQnooZVsZR6VdTzXEohvWz7dzp2z0RA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790804952; c=relaxed/simple; bh=2k5l6LtRrBi2ihPJ4QrwUC9ZzTJmwXDTgSGZ1qFNpVA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ljze+unnoUJPctNPMhDOPHffyLs/JpJRzVilahF1kaoPyUn9bTRBxp1C6uxK50rrHEEGwCBpJnTeRs4yP/9bmatMJhFhyTkTSwQaZiL1WsBRDm3Qn3A2jlTGPeIrwv/QKFuGSu83fhzzvjsob/+IdpQ0cuH2cAHyQRkOTq6YvK4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nabladev.com; spf=pass smtp.mailfrom=nabladev.com; dkim=pass (2048-bit key) header.d=nabladev.com header.i=@nabladev.com header.b=EosciR1g; arc=none smtp.client-ip=178.251.229.89 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nabladev.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nabladev.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nabladev.com header.i=@nabladev.com header.b="EosciR1g" Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 5BD7110709D; Wed, 30 Sep 2026 23:49:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nabladev.com; s=dkim; t=1790804944; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=nGkVLFh4t1/duKSh5UdjNw/Yth278XKTFrmEUlELumM=; b=EosciR1gI97ZJNuK6lrn0GImUmlmIuHdU8v5TNXFFsOGPPBDf74Wx3PvUrE2V7b1W0yfat 7QbAILUNAKBddNzuiLY8Ztq2Dr71Y6hontqdji74WqPB4ucP3AMEYnWNN7cV5QoWhFZaWE gU+PjUoXMvcCUDmR75c9OtqI5ruT+S68m4xgd0XfPyMiVog0dw4BVehfwY5R8eOdzmps2j +4nT4VWT04iFVDS83fof/X+tn9Q0eQ70vh16sh5FfOSC48G5ySpuKXXT5kIVwT46AtYyZ/ /O4ttEd8fuHGh/jY4nyvK2L5hhftjaptATMz2X2M9P9r+hwgMkrejGhSOY9Qew== Message-ID: <4efdcea6-a099-46a6-8d07-dd5c583b962a@nabladev.com> Date: Wed, 30 Sep 2026 23:49:02 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 3/3] arm64: dts: imx95: Add support for Data Modul i.MX95 eDM SBC To: Frank Li Cc: Francesco Dolcini , linux-arm-kernel@lists.infradead.org, Aswath Govindraju , Conor Dooley , Fabio Estevam , Frank Li , Krzysztof Kozlowski , Marc Kleine-Budde , Rob Herring , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-can@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260928204741.175754-1-marex@nabladev.com> <20260928204741.175754-3-marex@nabladev.com> <49303872-5622-4e1d-8e1a-01394ec29367@nabladev.com> <20260930174413.GA2463938@francesco-nb> <17f240e5-9c65-4562-ba51-535b0c69c5fd@nabladev.com> Content-Language: en-US From: Marek Vasut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 On 9/30/26 11:21 PM, Frank Li wrote: > On Wed, Sep 30, 2026 at 09:29:34PM +0200, Marek Vasut wrote: >> On 9/30/26 8:57 PM, Frank Li wrote: >>> On Wed, Sep 30, 2026 at 07:44:13PM +0200, Francesco Dolcini wrote: >>>> On Tue, Sep 29, 2026 at 05:20:27PM +0200, Marek Vasut wrote: >>>>> On 9/29/26 4:45 PM, Frank Li wrote: >>>>> >>>>> Hello Frank, >>>>> >>>>>>> + backlight_lvds: backlight-lvds { >>>>>>> + compatible = "pwm-backlight"; >>>>>>> + pinctrl-names = "default"; >>>>>>> + pinctrl-0 = <&pinctrl_panel_backlight_lvds>; >>>>>>> + brightness-levels = <0 1 10 20 30 40 50 60 70 75 80 90 100>; >>>>>>> + default-brightness-level = <7>; >>>>>>> + enable-gpios = <&gpio2 27 GPIO_ACTIVE_HIGH>; >>>>>>> + pwms = <&tpm3 3 5000000 0>; >>>>>>> + /* Disabled by default, unless display board plugged in. */ >>>>>>> + status = "disabled"; >>>>>>> + }; >>>>>> >>>>>> The both backlight is not used in this dts, can you remove it and >>>>>> add these when it real use. >>>>> It's the same thing we do on the other boards, so I would prefer to keep >>>>> this consistent: >>>> >>>> I agree with Marek, and I would not use the criteria about being used or >>>> not. >>> >>> >>> Others boards: some has dtso, which use it. And krzy have some concern for >>> similar case although he have not reply alex's answer. >>> >>> https://lore.kernel.org/imx/30599533-91de-41fd-9420-3f8693ec92ac@kernel.org/ >>> >>> And it is most likely go through nexus connector node to support display >>> panel in future. >> >> I do not think nexus node will apply to this connector, no. >> >>> So I suggest remove it now and add it when need. >> Can we please go with consistency between these boards from one vendor ? > > Yes, I am keeping consistency, then ask remove it. I applied alex's v2 > version. I put v1 link to show krzy's concern. > > https://lore.kernel.org/imx/20260319125013.2421621-3-alexander.stein@ew.tq-group.com/ > > Changes in v2: > * Changed commit message to imperative form > * Remove (currently unused) display and backlight nodes I sent you a V6 with those nodes removed.