From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C462C433E1 for ; Mon, 13 Jul 2020 14:36:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5666D206F4 for ; Mon, 13 Jul 2020 14:36:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Z9nkb3sv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729837AbgGMOgc (ORCPT ); Mon, 13 Jul 2020 10:36:32 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:44567 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729695AbgGMOgc (ORCPT ); Mon, 13 Jul 2020 10:36:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594650991; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=utDsxiJbHEkm2Fob90PfdlUV1I68F8zwYkv/4x3NbvE=; b=Z9nkb3sv/6SfKD1iioN/w6ugrRbxyP8xTZurh4Iyc53k2OJaBqkZC3SvSITvzspq7vOOMb 1AbL7lq7n1QhPjJCD6kDfG6JJZElKQWynUTNPg4jThXiKXOvkvobM6ltrE5OkO/MJCX13d KmsoA0ZR3ncOm+HYRH+WzVO/JKMoV2A= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-360-hqfeB6laNreoEjaa1iWBoQ-1; Mon, 13 Jul 2020 10:36:29 -0400 X-MC-Unique: hqfeB6laNreoEjaa1iWBoQ-1 Received: by mail-qt1-f197.google.com with SMTP id l53so10241869qtl.10 for ; Mon, 13 Jul 2020 07:36:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=utDsxiJbHEkm2Fob90PfdlUV1I68F8zwYkv/4x3NbvE=; b=hi0DU2MusO+K9sLYALbin3EI96eB0K6ct9jTU1Hiuu+PFHRxyOBgp2WYQrAUO1bbAw YoS+pxYHcDGu1yyTS7Tv1eVMnGKOVPrSgjzCOXyu6hW0zMQl595Xr4H1juNgQAQNU97U IFl8JA+2awm1AijvvuVkuACl3aOIqCMTE7hgYoR50kii6jLTk7xL4SHM7vmoawCGluNv AsKO5VdnrhDIFo4o9euH1QlhKRGh1vWJR2pxBaf4oL/NVgG6kt8afIkBlQT2KYWQt6ZC qQ7Jh+OMjm8xkF9m5T1YTKdhKMsPOsyWfoBTts5CGptZSbPjO3Iejv4K9Hcgcmsr9fTs 1SKQ== X-Gm-Message-State: AOAM532QNzeARgrlvFQMXMmnL9SQycboUZtbXTqJJ3tXxTz49SMiD6kt JtQFpeoOPSpOl85wbairszRtEH97Z2JAeVz3i47w/ap/+ms0oOeSG9sugmvfX8w61fR6BBm80xL p97QI5nfRK3bqOuEUgpogvrWS X-Received: by 2002:a37:6503:: with SMTP id z3mr78457624qkb.439.1594650989243; Mon, 13 Jul 2020 07:36:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyntha6qH4OqLYs+Aw/+Ul63oVHCE5s/a6MbC4bAbOEfy0jDN0mdDBf5bhWChHo+7pbRt1Y/Q== X-Received: by 2002:a37:6503:: with SMTP id z3mr78457606qkb.439.1594650989040; Mon, 13 Jul 2020 07:36:29 -0700 (PDT) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id k6sm17845686qki.123.2020.07.13.07.36.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jul 2020 07:36:28 -0700 (PDT) Subject: Re: [PATCH v2] fpga: dfl: pci: add device id for Intel FPGA PAC N3000 To: Xu Yilun , mdf@kernel.org, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org Cc: lgoncalv@redhat.com, Wu Hao , Matthew Gerlach , Russ Weight References: <1594604866-30877-1-git-send-email-yilun.xu@intel.com> From: Tom Rix Message-ID: <4efe6ee9-4e88-5b31-01a2-414f752a3d2e@redhat.com> Date: Mon, 13 Jul 2020 07:36:26 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <1594604866-30877-1-git-send-email-yilun.xu@intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > @@ -64,6 +64,7 @@ static void cci_pci_free_irq(struct pci_dev *pcidev) > #define PCIE_DEVICE_ID_PF_INT_5_X 0xBCBD > #define PCIE_DEVICE_ID_PF_INT_6_X 0xBCC0 > #define PCIE_DEVICE_ID_PF_DSC_1_X 0x09C4 > +#define PCIE_DEVICE_ID_INTEL_PAC_N3000 0x0B30 My point about consistency.  These are all intel  and all should have their pf parts removed. #define PCIE_DEVICE_ID_INTEL_INT_5_X 0xBCBD #define PCIE_DEVICE_ID_INTEL_INT_6_X 0xBCC0 #define PCIE_DEVICE_ID_INTEL_DSC_1_X 0x09C4 Let's revisit this for the d5005. trix