From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751379AbdFBNqq (ORCPT ); Fri, 2 Jun 2017 09:46:46 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:34170 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751247AbdFBNqo (ORCPT ); Fri, 2 Jun 2017 09:46:44 -0400 Subject: Re: [PATCH v3 3/8] nvmet: implement namespace identify descriptor list To: Johannes Thumshirn , Christoph Hellwig , Keith Busch References: <20170602094536.25775-1-jthumshirn@suse.de> <20170602094536.25775-4-jthumshirn@suse.de> Cc: Hannes Reinecke , maxg@mellanox.com, Linux NVMe Mailinglist , Linux Kernel Mailinglist From: Sagi Grimberg Message-ID: <4f03d4c0-6f7b-dbc4-b0ee-bebe77e80ea6@grimberg.me> Date: Fri, 2 Jun 2017 16:46:40 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170602094536.25775-4-jthumshirn@suse.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > switch (type) { > case NVME_NQN_NVME: > diff --git a/drivers/nvme/target/nvmet.h b/drivers/nvme/target/nvmet.h > index cfc5c7fb0ab7..4c6cb5ea1186 100644 > --- a/drivers/nvme/target/nvmet.h > +++ b/drivers/nvme/target/nvmet.h > @@ -46,6 +46,7 @@ struct nvmet_ns { > u32 blksize_shift; > loff_t size; > u8 nguid[16]; > + uuid_be uuid; This should be uuid_le to match the rest of NVMe. Also, it would be useful to generate a random default with uuid_le_gen() for a better out-of-the-box experience.