From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DB8FEE57E0 for ; Fri, 8 Sep 2023 08:12:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241958AbjIHIMb (ORCPT ); Fri, 8 Sep 2023 04:12:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241183AbjIHIMa (ORCPT ); Fri, 8 Sep 2023 04:12:30 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5D031BE9; Fri, 8 Sep 2023 01:12:25 -0700 (PDT) Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3887o2U5013098; Fri, 8 Sep 2023 08:12:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=hVCntPRLTuC9NKb+OMsIJEaUsBSq03rRzLhET4RZ2sg=; b=EujqcZQzz5/u3AWmYF1fZBq7FMpI03WrUPZnQ3tjPdUDYOVk+Mf0azEpN1reaENiYrcn l/EM8VIudpA6bDeQarBeLHSHlrBztjwLEao0s0YGPHol04z1S3J9LSOA2jpPP82Lgc7x UXkmOUXz+pkvQ7aG1sGdvvsdlE2yPrX5feIlu+87tD1WJ5cyxG7eU5JIDqcVcSHotL0L qgynKd4JrIGOtsUkLiA3ofCLoU2axWCMldq4wt7EL5f1pBtg9IxLzZczI0ud7E/DEg3s bxpPT4FtkUUsHNu8YlqWeA1yrpO7BOJi1SUWLJoC2sovOHDVYJz50hJsxgWBaDYAsmll Wg== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3synyq93bw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 08 Sep 2023 08:12:18 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3888CHOb015885 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 8 Sep 2023 08:12:17 GMT Received: from [10.239.132.204] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.36; Fri, 8 Sep 2023 01:12:09 -0700 Message-ID: <4f0533bb-96d7-4e5e-9315-eb2fcdc0c745@quicinc.com> Date: Fri, 8 Sep 2023 16:12:06 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/6] arm64: dts: qcom: sm4450: Add apps_rsc and cmd_db node To: Krzysztof Kozlowski , , , , , , , , , CC: , , , , , , , , , , , , , Ajit Pandey References: <20230908065847.28382-1-quic_tengfan@quicinc.com> <20230908065847.28382-5-quic_tengfan@quicinc.com> <59626d1b-8407-9370-21ab-bf15853f24c0@linaro.org> From: Tengfei Fan In-Reply-To: <59626d1b-8407-9370-21ab-bf15853f24c0@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: QXY0ODtO5XBAB1Z88VeKTq8Agu37KQry X-Proofpoint-GUID: QXY0ODtO5XBAB1Z88VeKTq8Agu37KQry X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-08_05,2023-09-05_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxscore=0 spamscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 suspectscore=0 mlxlogscore=648 impostorscore=0 phishscore=0 bulkscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2309080075 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 9/8/2023 4:10 PM, Krzysztof Kozlowski 写道: > On 08/09/2023 08:58, Tengfei Fan wrote: >> From: Ajit Pandey >> >> Add apps_rsc node and cmd_db memory region for sm4450. >> >> Signed-off-by: Ajit Pandey >> Signed-off-by: Tengfei Fan >> --- >> arch/arm64/boot/dts/qcom/sm4450.dtsi | 34 ++++++++++++++++++++++++++++ >> 1 file changed, 34 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sm4450.dtsi b/arch/arm64/boot/dts/qcom/sm4450.dtsi >> index c4e5b33f5169..eb544d875806 100644 >> --- a/arch/arm64/boot/dts/qcom/sm4450.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sm4450.dtsi >> @@ -5,6 +5,7 @@ >> >> #include >> #include >> +#include >> >> / { >> interrupt-parent = <&intc>; >> @@ -328,6 +329,18 @@ >> }; >> }; >> >> + reserved_memory: reserved-memory { >> + #address-cells = <2>; >> + #size-cells = <2>; >> + ranges; >> + >> + aop_cmd_db_mem: cmd-db@80860000 { >> + compatible = "qcom,cmd-db"; >> + reg = <0x0 0x80860000 0x0 0x20000>; >> + no-map; >> + }; >> + }; >> + >> soc: soc@0 { >> #address-cells = <2>; >> #size-cells = <2>; >> @@ -335,6 +348,27 @@ >> dma-ranges = <0 0 0 0 0x10 0>; >> compatible = "simple-bus"; >> >> + apps_rsc: rsc@17a00000 { >> + label = "apps_rsc"; > > It does not look like you tested the DTS against bindings. Please run > `make dtbs_check W=1` (see > Documentation/devicetree/bindings/writing-schema.rst or > https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ > for instructions). > >> + compatible = "qcom,rpmh-rsc"; > > compatible is always the first property. reg/reg-names/ranges follow. yes, dtbs_check verify done, maybe miss this error, will update this sequence. > > > > Best regards, > Krzysztof > -- Thx and BRs, Tengfei Fan