From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3161135A53 for ; Fri, 13 Mar 2026 05:07:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773378440; cv=none; b=oyifRIuMS5g6G1yyTP6q9bbg0+G8tMFyEE8bHyfbwu4ANkeItGVFVfsLcFHoEkYLV3a0NrHE/L5b8/J2evtmTOdlMQuqu+FbXZT+oVgWzoDXeeCGYrrvci0c8DrYLGGBZk80VaTVED2xFTkgk3YhQStjF3k5YKZB0V2aZv42v2o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773378440; c=relaxed/simple; bh=Mk8tq1fYj+LUFOPyKiSxAe5xxXcsnd9nKLa7hnj9TdE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lZ+WK9l8N3HsMx5ppNK0XQI0rF967b4wkP9Kf8aNisL5CqBAdMTiWRQQZMsEQ1WY4rlXzC0TiPqVEfxnh/7KAk//fCKqAzrBpapZ1wiQ1DFGmtY6DcVCzdlYhEFbMcq4gND6QhgculMENE1I4mSSqcgSh5WWZxRkhzn1jt3LXeI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RWkRBaOY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dtwgOqpr; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RWkRBaOY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dtwgOqpr" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62D17pIN2612634 for ; Fri, 13 Mar 2026 05:07:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0tmtKRvDIIv8WAEFm75w85Ye5S2Qw6tGLx83eZwEjjs=; b=RWkRBaOYP7GBlNO8 DE2TPiL/lbUPa4jNQpcLJ5jne33pyBrLnlTs6pPEcV+T7zu/UtaPSiskg/f+x8cr Ye+AopQuHXkZNkiN7KO/zIuurh2gmz2SpyJ385Bscr3lMy8XtjP4kysXLgb7g2pu NQ1tBvSY1d7OhR0R+XuH8S4yyFHlMqx3V3swCB9Dxnpimf6dDsaevmEao+LKnj1V EmF/GamvMpZmmtZJXHDW0u45kt3kPjBH//iH9sl9qzrFH/u6NGrT4GalObB+vS+0 hkRKAcQXmhXh56xX0HqE85o0c5maSZaMa2uVTkpfsvGnkcl0QXRM8BwsZcZ1lzsN q01fGw== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cv8n7gk4a-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 13 Mar 2026 05:07:18 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c7381a95fffso1093401a12.0 for ; Thu, 12 Mar 2026 22:07:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773378437; x=1773983237; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0tmtKRvDIIv8WAEFm75w85Ye5S2Qw6tGLx83eZwEjjs=; b=dtwgOqprzCWna6XCJ+QWDPCOxwi1zsJoT4rJyJelNFHOUnP8/6dRPSS+qx2IwN+vIb Ztvh676WxKLqNyqmXD9ehxKFvrDItg92QoShKQzV9/j2KXHaqRmMIpvExS25GE8C2EEF Alg8/tSuLFctlKwu8s6tT2tQqdTI8LSYbnNn90bcc1Wrbvb51b7EHMGjk3S/CZqsNp7H JqpFG6KrOzIqrhNqNBGs/QlgghaQHKiOQy3lIcJpwBxTeKoCoC6GomQER2+ITSYvvzmU L4AIsgoz/z3j3T1bBYZPPzB3KYmKl9mX7T5K6o0dfmCPWjvw0hlpBA91yUY3YFtkgh6L LsMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773378437; x=1773983237; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0tmtKRvDIIv8WAEFm75w85Ye5S2Qw6tGLx83eZwEjjs=; b=Ytd241GUMwp7UYJ4g9Yrgw0lRThRSiNM3OtwEY0XEjjzAUj0OgKtcRMvuXKOI5p91z 5hs7MtbElL6nJJHMh4j7obPffsaletXHG/o2da7b8sHY+3/TISRd3iaKd0qQzCPJhyaW 8y9ns0hUA8hyVROt4IXqw/S2Fw4VGGpU0WXSn13WnkTRuzZefkhj947844w0M0y8bEI5 sbj4j1Ud/wFOHHDiROlWM8ik5+jk/a48pvZI1445C4Ye5CbeLzq3LSbKHpytuspp56dB zb7TVjJhPuwglvExl/lBJjfKRF4rrsuVk4tay3TUoz+Ls7EMhWQRrJPZvDwqfLlbdtfS t4IQ== X-Forwarded-Encrypted: i=1; AJvYcCVZ8br4MZWhyMxoWYe/bLOlaw2++KDcDF2dCi2JWwclPVcnJKo0rwzRyNWn0fp2d/K7dmlDc/DDhySpiGc=@vger.kernel.org X-Gm-Message-State: AOJu0YyeGOaCdFRD/vM+A2fzpQBl3kT1U3xhAzCVGP6jIXCwZz8EzVsC Ggz91sPtguHu4W2nBIiO9oCHcNJcbYA3y8W3S/wZM973hLjkhELORJkLNAng9EQy6KgvtdRIAO7 sKyGCG7CN8bFhdPegMCN521qRMAWK9Z41A95YPb/dbv+UK0+5wYu7Emc7IJ7+Yfwsu/+5YvXVJd k= X-Gm-Gg: ATEYQzzptL+DjqNDW0tAdYRXMWX5863hE/Qk7BkE3M7eJAm45ZVD/S+WZQrFoJxk2nw V9CwOcPw/mU6Y5zdyZLajUqoecZJlbWnuauA4F/3j1LVDnHMfHZjr6QHGQOB77BP9VjlJm+iu55 OrOdrVMZ+lbJcm+5mJokXsJxM6LcKODz8JG2RIxxyWi3d3ft+ggFAw+TD60mR+lgtjMt1gOPi3c 2AJcwco35tFDWFKJuhwctKGEWBmPilt3msk2jd68YS0cvJkxAMcOKmtfoO5UhNcYNjpaxozlDFx tM2P9zwwdo1eyfiKawPw4nMheDH4RZ53wDrMcouLXHDaIgpu0YheTVZmAmqT7pgowSjtmSFZ0/v TUKW59fOeqNCH/ledpZCo0BBdgb0Ui0T2cfQHNKcdF4AxvuLBV450 X-Received: by 2002:a05:6a00:21cb:b0:81f:993e:ecf6 with SMTP id d2e1a72fcca58-82a198d04b4mr1676321b3a.33.1773378437352; Thu, 12 Mar 2026 22:07:17 -0700 (PDT) X-Received: by 2002:a05:6a00:21cb:b0:81f:993e:ecf6 with SMTP id d2e1a72fcca58-82a198d04b4mr1676300b3a.33.1773378436905; Thu, 12 Mar 2026 22:07:16 -0700 (PDT) Received: from [10.0.0.3] ([106.222.229.52]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82a07365b22sm4537101b3a.45.2026.03.12.22.07.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Mar 2026 22:07:16 -0700 (PDT) Message-ID: <4f053da5-1804-9a75-4fbe-ee23974f3726@oss.qualcomm.com> Date: Fri, 13 Mar 2026 10:37:12 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v4 2/8] media: qcom: iris: use common set_preset_registers function Content-Language: en-US To: Dmitry Baryshkov , Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260313-iris-platform-data-v4-0-14927df4906d@oss.qualcomm.com> <20260313-iris-platform-data-v4-2-14927df4906d@oss.qualcomm.com> From: Dikshita Agarwal In-Reply-To: <20260313-iris-platform-data-v4-2-14927df4906d@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: WW_PxNa6X5zhPObXqcSj1QF3jV-iZic3 X-Proofpoint-GUID: WW_PxNa6X5zhPObXqcSj1QF3jV-iZic3 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEzMDAzOSBTYWx0ZWRfX6CqyRaCnWczY poVboMl2Vvv7QMhApvgc674c6kA3THvSJ9M685N44Rsma+Tp8xMghpGcEgDXN3I4haWAHueDnMZ BIz3k3WKgHPpBSEvvPjrTZ3eMI16ztKw9XWQrWCaiqBqO6obZMXo0Ef5zy+m5jmxwjK1wffN86b 5lJQD7nqH93oqV9YzwH3qD8XnUMmErEEeuDvgMeN6gqycwPKFUpqCoTphspSoKaOvF7rntBepp6 ApC5ThzDxA87IJLQlluOZTmCRFt2y/HahuNt8JL8P2qyVrv9URw2NGfeLsADA0Pb215hGhfpRSH EPmmme/qWeQUp+hbhOuipNoXtfwiyRyQMhk0paS/G2TIaFg74vQVm8dcV/oWjmpk6Ozqppyn4rD UXxWp1olvDlgPozYGGzMe7MDjP5gBxItvG6BkMrmmHGTh6QH/z44Vg7SHd/Jzbw8N//P3odXZMJ lVDgueWMa5N3x5qJ9Dg== X-Authority-Analysis: v=2.4 cv=CpCys34D c=1 sm=1 tr=0 ts=69b39b86 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=ndT/fs+coltRyMHftQWjTw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=xm1I8ePgU3ACQa9n1MUA:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_03,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 spamscore=0 priorityscore=1501 adultscore=0 suspectscore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603130039 On 3/13/2026 9:00 AM, Dmitry Baryshkov wrote: > The set_preset_registers is (currently) common to all supported devices. > Extract it to a iris_vpu_common.c and call it directly from > iris_vpu_power_on(). Later, if any of the devices requires special > handling, it can be sorted out separately. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/media/platform/qcom/iris/iris_platform_common.h | 1 - > drivers/media/platform/qcom/iris/iris_platform_gen1.c | 7 ------- > drivers/media/platform/qcom/iris/iris_platform_gen2.c | 9 --------- > drivers/media/platform/qcom/iris/iris_vpu_common.c | 7 ++++++- > drivers/media/platform/qcom/iris/iris_vpu_common.h | 2 ++ > 5 files changed, 8 insertions(+), 18 deletions(-) > Reviewed-by: Dikshita Agarwal Thanks, Dikshita