From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86F05C43441 for ; Thu, 29 Nov 2018 06:24:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5413320863 for ; Thu, 29 Nov 2018 06:24:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5413320863 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727956AbeK2R2p (ORCPT ); Thu, 29 Nov 2018 12:28:45 -0500 Received: from mga07.intel.com ([134.134.136.100]:4622 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727406AbeK2R2p (ORCPT ); Thu, 29 Nov 2018 12:28:45 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Nov 2018 22:24:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,293,1539673200"; d="scan'208";a="95626981" Received: from yjin15-mobl.ccr.corp.intel.com (HELO [10.239.196.43]) ([10.239.196.43]) by orsmga006.jf.intel.com with ESMTP; 28 Nov 2018 22:24:28 -0800 Subject: Re: [PATCH v3 0/3] perf report/annotate: Support average IPC and IPC coverage for function To: Jiri Olsa Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com References: <1543418098-10435-1-git-send-email-yao.jin@linux.intel.com> <20181128101757.GA11280@krava> <20181128101846.GB11280@krava> From: "Jin, Yao" Message-ID: <4f05c9c6-f82f-1a23-ce8b-b061d5758400@linux.intel.com> Date: Thu, 29 Nov 2018 14:24:27 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: <20181128101846.GB11280@krava> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/28/2018 6:18 PM, Jiri Olsa wrote: > On Wed, Nov 28, 2018 at 11:17:57AM +0100, Jiri Olsa wrote: >> On Wed, Nov 28, 2018 at 11:14:55PM +0800, Jin Yao wrote: >>> Add supporting of displaying the average IPC and IPC coverage >>> percentage per function. >>> >>> For example, >>> >>> $ perf record -b ... >>> $ perf report -s symbol or >>> perf report -s symbol --stdio >>> >>> Overhead Symbol IPC [IPC Coverage] >>> 39.60% [.] __random 2.30 [ 54.8%] >>> 18.02% [.] main 0.43 [ 54.3%] >>> 14.21% [.] compute_flag 2.29 [100.0%] >>> 14.16% [.] rand 0.36 [100.0%] >>> 7.06% [.] __random_r 2.57 [ 70.5%] >>> 6.85% [.] rand@plt 0.00 [ 0.0%] >>> ... >>> >>> $ perf annotate --stdio2 >>> >>> Percent IPC Cycle (Average IPC: 2.30, IPC Coverage: 54.8%) >>> >>> Disassembly of section .text: >>> >>> 000000000003aac0 : >>> 8.32 3.28 sub $0x18,%rsp >>> 3.28 mov $0x1,%esi >>> 3.28 xor %eax,%eax >>> 3.28 cmpl $0x0,argp_program_version_hook@@GLIBC_2.2.5+0x1e0 >>> 11.57 3.28 1 ↓ je 20 >>> lock cmpxchg %esi,__abort_msg@@GLIBC_PRIVATE+0x8a0 >>> ↓ jne 29 >>> ↓ jmp 43 >>> 11.57 1.10 20: cmpxchg %esi,__abort_msg@@GLIBC_PRIVATE+0x8a0 >>> ... >>> >>> v3: >>> --- >>> Remove the sortkey "ipc" from command-line. The columns "IPC" >>> and "[IPC Coverage]" are automatically enabled when "symbol" >>> is specified. >>> >>> Patch "perf report: Display average IPC and IPC coverage per symbol" >>> is impacted. >>> >>> v2: >>> --- >>> 1. Merge in Jiri's patch to support stdio mode >>> >>> 2. Add a new patch "perf annotate: Create a annotate2 flag >>> in struct symbol" which records if the symbol has been >>> annotated yet. >>> >>> 3. Minor update such as adding { } for multiline code in 'if' >>> condition. >>> >>> Jin Yao (3): >>> perf annotate: Compute average IPC and IPC coverage per symbol >>> perf annotate: Create a annotate2 flag in struct symbol >>> perf report: Display average IPC and IPC coverage per symbol >> >> hi, >> I took he liberty and moved the annotation retrieval into >> resort phase under progress bar scope. It's currently on top >> of my perf/fixes branch, could you please check it? >> >> git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git > > commits: > 7f3ffdb9783f perf tools: Move symbol annotation to resort > e87f7d3c4f10 perf tools: Add perf_evsel__output_resort_cb function > 40012b422108 perf tools: Add argument to hists__resort_cb_t callback > > jirka > Hi Jiri, Thanks for your patches. I have tested with your repo. Now I can see 2 progress bars. One is displayed at the events processing phase, the other is displayed at resorting phase. I have only one concern that is, in my test, much of time is consumed by the event processing phase, for example, 90% of time. Only 10% of time is consumed at resorting phase. So do we really need the second progress bar? Thanks Jin Yao